Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import from Yandex browser #16441

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Add import from Yandex browser #16441

merged 1 commit into from
Dec 22, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Dec 21, 2022

Resolves brave/brave-browser#27301

History, Bookmarks and Extensions can be now imported.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Install Yandex browser and check that History, Bookmarks and Extensions can be imported.

@spylogsster spylogsster self-assigned this Dec 21, 2022
@spylogsster spylogsster requested a review from a team as a code owner December 21, 2022 14:39
@@ -59,6 +59,7 @@ void RecordImporterP3A(importer::ImporterType type) {
metric = ImporterSource::kMicrosoft;
break;
case importer::TYPE_VIVALDI:
case importer::TYPE_YANDEX:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iefremov Added it as ImporterSource::kOther same as Vivaldi

@spylogsster spylogsster requested a review from iefremov December 21, 2022 14:40
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 83640acc824b1f0c4afade44a9fe643c5025c129
reason: unsigned
Please follow the handbook to configure commit signing
cc: @spylogsster

@spylogsster spylogsster force-pushed the brave-27301-y branch 3 times, most recently from 8d8f769 to 8803887 Compare December 21, 2022 15:55
@spylogsster spylogsster merged commit 0c7b397 into master Dec 22, 2022
@spylogsster spylogsster deleted the brave-27301-y branch December 22, 2022 08:57
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 22, 2022
@bsclifton
Copy link
Member

bsclifton commented Dec 23, 2022

Awesome work here, @spylogsster! Thanks for helping review @iefremov

With the new import in brave://welcome, are we going to show Yandex? If so - do we need to add an icon there?
cc: @rebron

@spylogsster
Copy link
Contributor Author

spylogsster commented Dec 24, 2022

Awesome work here, @spylogsster! Thanks for helping review @iefremov

With the new import in brave://welcome, are we going to show Yandex? If so - do we need to add an icon there? cc: @rebron

yes, it detects Yandex profiles on computers now

@jenn-rhim
Copy link
Contributor

Yandex logo

yandex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add import from Yandex browser
4 participants