-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import from Yandex browser #16441
Conversation
@@ -59,6 +59,7 @@ void RecordImporterP3A(importer::ImporterType type) { | |||
metric = ImporterSource::kMicrosoft; | |||
break; | |||
case importer::TYPE_VIVALDI: | |||
case importer::TYPE_YANDEX: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iefremov Added it as ImporterSource::kOther
same as Vivaldi
cf9645f
to
83640ac
Compare
|
8d8f769
to
8803887
Compare
8803887
to
aa83abf
Compare
Awesome work here, @spylogsster! Thanks for helping review @iefremov With the new import in brave://welcome, are we going to show Yandex? If so - do we need to add an icon there? |
yes, it detects Yandex profiles on computers now |
Resolves brave/brave-browser#27301
History, Bookmarks and Extensions can be now imported.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: