-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yandex icon for browser list #16667
Conversation
66ec218
to
c311afe
Compare
import * as React from 'react' | ||
|
||
const SvgComponent = (props: any) => ( | ||
<svg viewBox="0 0 200 200" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aguscruiz pls help with correct svg, this seems a bit bigger than expected. I took this one #16441 (comment), maybe we have to use something other, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
c311afe
to
bff5927
Compare
bff5927
to
476d7d6
Compare
ee98140
to
72aae2b
Compare
315f064
to
b88f008
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b88f008
to
577a60b
Compare
A Storybook has been deployed to preview UI for the latest push |
Verified
|
Brave | 1.49.37 Chromium: 109.0.5414.87 (Official Build) nightly (x86_64) |
---|---|
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
OS | macOS Version 11.7.2 (Build 20G1020) |
Steps:
- populated a Yandex browser with at least bookmarks
- installed
1.49.37
- launched Brave
- on
brave://welcome
looked for Yandex as an import option
Confirmed the Yandex
logo and name show up in brave://welcome
and profiles are imported successfully
brave://welcome |
Yandex profiles |
all profiles selected |
Setup complete |
brave://extensions |
brave://history |
brave://bookmarks |
---|---|---|---|---|---|---|
Resolves brave/brave-browser#27760
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: