Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yandex icon for browser list #16667

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add Yandex icon for browser list #16667

merged 1 commit into from
Jan 13, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 13, 2023

Resolves brave/brave-browser#27760

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Steps from issue

@spylogsster spylogsster self-assigned this Jan 13, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 13, 2023
import * as React from 'react'

const SvgComponent = (props: any) => (
<svg viewBox="0 0 200 200" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Contributor Author

@spylogsster spylogsster Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aguscruiz pls help with correct svg, this seems a bit bigger than expected. I took this one #16441 (comment), maybe we have to use something other, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
@spylogsster spylogsster requested a review from a team as a code owner January 13, 2023 17:09
@spylogsster spylogsster force-pushed the brave-27760 branch 2 times, most recently from ee98140 to 72aae2b Compare January 13, 2023 17:33
@spylogsster spylogsster removed the request for review from a team January 13, 2023 17:33
@spylogsster spylogsster force-pushed the brave-27760 branch 2 times, most recently from 315f064 to b88f008 Compare January 13, 2023 17:38
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster changed the title Add Yandex icon for browser lists Add Yandex icon for browser list Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave brave deleted a comment from github-actions bot Jan 13, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster merged commit adee9a2 into master Jan 13, 2023
@spylogsster spylogsster deleted the brave-27760 branch January 13, 2023 20:53
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 13, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.49.37 Chromium: 109.0.5414.87 (Official Build) nightly (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. populated a Yandex browser with at least bookmarks
  2. installed 1.49.37
  3. launched Brave
  4. on brave://welcome looked for Yandex as an import option

Confirmed the Yandex logo and name show up in brave://welcome and profiles are imported successfully

brave://welcome Yandex profiles all profiles selected Setup complete brave://extensions brave://history brave://bookmarks
Screen Shot 2023-01-17 at 1 45 27 PM Screen Shot 2023-01-17 at 1 55 47 PM Screen Shot 2023-01-17 at 1 55 56 PM Screen Shot 2023-01-17 at 1 56 00 PM Screen Shot 2023-01-17 at 1 56 14 PM Screen Shot 2023-01-17 at 1 56 20 PM Screen Shot 2023-01-17 at 1 56 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave://welcome import is missing Yandex
4 participants