Fix 27492 (broken facebook popup when screen farbling enabled) #16571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Jan 17, 2023
bridiver
reviewed
Jan 17, 2023
chromium_src/third_party/blink/renderer/core/page/chrome_client_impl.cc
Outdated
Show resolved
Hide resolved
arthuredelstein
force-pushed
the
issues/27492
branch
from
24c41a7 to
dde383a
Compare
bridiver
approved these changes
Jan 19, 2023
When farbling screen size, make sure window.resizeTo and window.moveTo use the farbled coordinate system. When a window.open(...) popup is opened with very small dimensions, scripts should not be told that the screen is extremely small. So we put a minimum screen width and height, with a random number between 0 and 8 added to each dimension. Fixes #27492
arthuredelstein
force-pushed
the
issues/27492
branch
from
473b2e6 to
b8587dd
Compare
Verified
|
| Brave | 1.49.45 Chromium: 109.0.5414.87 (Official Build) nightly (x86_64) |
|---|---|
| Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
| OS | macOS Version 11.7.2 (Build 20G1020) |
Used my original steps to reproduce in brave/brave-browser#27492 (comment), to verify.
Confirmed Facebook's sharing popup loads without expanding the viewport character-by-character
arthuredelstein
added a commit
that referenced
this pull request
Feb 23, 2023
kjozwiak
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Fix 27492 (broken facebook popup when screen farbling enabled) (uplift to 1.48.x) (#16571) * fix re-enable full FarbleScreenPopupPosition test (uplift to 1.48.x) (#17277) * fix re-enable full FarbleScreenPopupPosition test * make window smaller before offseting it * fix broken screen farbling regression test (uplift to 1.48.x) (#17341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#27492
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: