Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken screen farbling regression test #17341

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

arthuredelstein
Copy link
Collaborator

@arthuredelstein arthuredelstein commented Feb 23, 2023

Resolves brave/brave-browser#28673
Resolves brave/brave-browser#28674
Resolves brave/brave-browser#28675
Resolves brave/brave-browser#28676
Resolves brave/brave-browser#28677
Resolves brave/brave-browser#28678
Resolves brave/brave-browser#28679
Resolves brave/brave-browser#28680

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@arthuredelstein
Copy link
Collaborator Author

thanks for the reviews!

@arthuredelstein arthuredelstein merged commit 1f86187 into master Feb 23, 2023
@arthuredelstein arthuredelstein deleted the issues/28673 branch February 23, 2023 17:46
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 23, 2023
kjozwiak pushed a commit that referenced this pull request Feb 27, 2023
* fix re-enable full FarbleScreenPopupPosition test (uplift to 1.49.x) (#17277)

* fix re-enable full FarbleScreenPopupPosition test

* make window smaller before offseting it

* fix broken screen farbling regression test (uplift to 1.49.x) (#17341)
kjozwiak pushed a commit that referenced this pull request Feb 27, 2023
* Fix 27492 (broken facebook popup when screen farbling enabled) (uplift to 1.48.x) (#16571)

* fix re-enable full FarbleScreenPopupPosition test (uplift to 1.48.x) (#17277)

* fix re-enable full FarbleScreenPopupPosition test

* make window smaller before offseting it

* fix broken screen farbling regression test (uplift to 1.48.x) (#17341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment