-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken screen farbling regression test #17341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaiplesa
approved these changes
Feb 23, 2023
bridiver
approved these changes
Feb 23, 2023
thanks for the reviews! |
arthuredelstein
added a commit
that referenced
this pull request
Feb 23, 2023
arthuredelstein
added a commit
that referenced
this pull request
Feb 23, 2023
This was referenced Feb 24, 2023
kjozwiak
pushed a commit
that referenced
this pull request
Feb 27, 2023
kjozwiak
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Fix 27492 (broken facebook popup when screen farbling enabled) (uplift to 1.48.x) (#16571) * fix re-enable full FarbleScreenPopupPosition test (uplift to 1.48.x) (#17277) * fix re-enable full FarbleScreenPopupPosition test * make window smaller before offseting it * fix broken screen farbling regression test (uplift to 1.48.x) (#17341)
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#28673
Resolves brave/brave-browser#28674
Resolves brave/brave-browser#28675
Resolves brave/brave-browser#28676
Resolves brave/brave-browser#28677
Resolves brave/brave-browser#28678
Resolves brave/brave-browser#28679
Resolves brave/brave-browser#28680
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: