Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Twitter's redirector (fixes brave/brave-browser#28184) #16968

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Feb 1, 2023

The t parameter is required for the Twitter redirector to work.

This reverts commit 2c2afa6 added to fix brave/brave-browser#26756.

Resolves brave/brave-browser#28184

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

In a new profile in which you have never visited Twitter:

  1. Open https://twitter.com/i/redirect?url=https%3A%2F%2Ftwitter.com%2Fmask_3dcg%2Fstatus%2F1617094871818596354%3Fcn%3DZmxleGlibGVfcmVjcw%253D%253D%26refsrc%3Demail&t=1+1674400145805&cn=ZmxleGlibGVfcmVjcw%3D%3D&sig=5d71ce9ef69b11a9f5e9ad0489166c17e89947ce&iid=93b0f359fc6f4fe795753cb5475c6801&uid=1360753837754048512&nid=244+276893697 in a new tab.
  2. Confirm that it loads https://twitter.com/mask_3dcg/status/1617094871818596354?cn=ZmxleGlibGVfcmVjcw%3D%3D&refsrc=email instead of an error page.

@fmarier fmarier self-assigned this Feb 1, 2023
@fmarier fmarier requested a review from iefremov as a code owner February 1, 2023 21:52
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Feb 1, 2023
The `t` parameter is required for the Twitter redirector to work.

This reverts commit 2c2afa6.
@fmarier fmarier force-pushed the fix-twitter-redirector-28184 branch from 674f566 to a3038b4 Compare February 3, 2023 00:07
@fmarier fmarier added this to the 1.50.x - Nightly milestone Feb 3, 2023
@fmarier fmarier merged commit 3905efd into master Feb 3, 2023
@fmarier fmarier deleted the fix-twitter-redirector-28184 branch February 3, 2023 05:38
brave-builds added a commit that referenced this pull request Feb 3, 2023
brave-builds added a commit that referenced this pull request Feb 3, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.6 Chromium: 110.0.5481.77 (Official Build) nightly (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 22H2 (Build 22621.1194)

Using the STR/Cases outlined via #16968 (comment), ensured that loading the following URL within a new tab correctly loaded the Twitter page rather than displaying an error as per the following:

https://twitter.com/i/redirect?url=https%3A%2F%2Ftwitter.com%2Fmask_3dcg%2Fstatus%2F1617094871818596354%3Fcn%3DZmxleGlibGVfcmVjcw%253D%253D%26refsrc%3Demail&t=1+1674400145805&cn=ZmxleGlibGVfcmVjcw%3D%3D&sig=5d71ce9ef69b11a9f5e9ad0489166c17e89947ce&iid=93b0f359fc6f4fe795753cb5475c6801&uid=1360753837754048512&nid=244+276893697

fixedIssue1

https://twitter.com/mask_3dcg/status/1617094871818596354?cn=ZmxleGlibGVfcmVjcw%3D%3D&refsrc=email

kjozwiak pushed a commit that referenced this pull request Feb 6, 2023
kjozwiak pushed a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter link doesn't work Remove Twitter's t tracking parameter
3 participants