Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter link doesn't work #28184

Closed
A-t-s-u-s-h-i opened this issue Feb 1, 2023 · 10 comments · Fixed by brave/brave-core#16968
Closed

Twitter link doesn't work #28184

A-t-s-u-s-h-i opened this issue Feb 1, 2023 · 10 comments · Fixed by brave/brave-core#16968
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@A-t-s-u-s-h-i
Copy link

Description

A user reported that it would be an error page(please see the attachment) if he click the twitter link like this. It’s solved by disabling Shields. But I would like to avoid replying like “Please access Twitter without Shields”. I hope we can find any solution for that.

Related issue: #26756

Steps to Reproduce

  1. copy&paste twitter URL that has t parameter

Actual result:

スクリーンショット 2023-02-01 14 39 08

Expected result:

Twitter page will be shown.

Reproduces how often:

Easily reproduced

Desktop Brave version:

1.47.186

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    yes
  • Can you reproduce this issue with the beta channel?
    yes
  • Can you reproduce this issue with the nightly channel?
    yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    yes
@A-t-s-u-s-h-i A-t-s-u-s-h-i added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 1, 2023
@fmarier fmarier self-assigned this Feb 1, 2023
@fmarier fmarier added privacy/query-filter webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Feb 1, 2023
@fmarier
Copy link
Member

fmarier commented Feb 1, 2023

There are a few query string parameters in the sample URL:

  • t
  • cn
  • sig
  • iid
  • uid
  • nid

With the exception of cn, all of these are required for the redirect to work.

fmarier added a commit to brave/brave-core that referenced this issue Feb 3, 2023
The `t` parameter is required for the Twitter redirector to work.

This reverts commit 2c2afa6.
fmarier added a commit to brave/brave-core that referenced this issue Feb 3, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 3, 2023
kjozwiak pushed a commit to brave/brave-core that referenced this issue Feb 6, 2023
kjozwiak pushed a commit to brave/brave-core that referenced this issue Feb 6, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

The above requires 1.48.157 for 1.48.x verification 👍

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 6, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 6, 2023

Verification PASSED using

Brave | 1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Verified in 1.47.156 using original STR #28184 (comment)
image

  • Install 1.48.157
  • launch brave
  • open a new-tab page
  • visited twitter with following link
    -https://twitter.com/i/redirect?url=https%3A%2F%2Ftwitter.com%2Fmask_3dcg%2Fstatus%2F1617094871818596354%3Fcn%3DZmxleGlibGVfcmVjcw%253D%253D%26refsrc%3Demail&cn=ZmxleGlibGVfcmVjcw%3D%3D&sig=5d71ce9ef69b11a9f5e9ad0489166c17e89947ce&iid=93b0f359fc6f4fe795753cb5475c6801&uid=1360753837754048512&nid=244+276893697

Confirmed no error page shown and loaded correct page

  - https://twitter.com/mask_3dcg/status/1617094871818596354?cn=ZmxleGlibGVfcmVjcw%3D%3D&refsrc=email 

image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 6, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.48.155 Chromium: 110.0.5481.77 (Official Build) (32-bit)
--- | ---
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Android 13; Build/TQ1A.230105.002

Using the STR/Cases outlined via brave/brave-core#16968 (comment), ensured that loading the following URL within a new tab correctly loaded the Twitter page rather than displaying an error as per the following:

https://twitter.com/i/redirect?url=https%3A%2F%2Ftwitter.com%2Fmask_3dcg%2Fstatus%2F1617094871818596354%3Fcn%3DZmxleGlibGVfcmVjcw%253D%253D%26refsrc%3Demail&t=1+1674400145805&cn=ZmxleGlibGVfcmVjcw%3D%3D&sig=5d71ce9ef69b11a9f5e9ad0489166c17e89947ce&iid=93b0f359fc6f4fe795753cb5475c6801&uid=1360753837754048512&nid=244+276893697

image

https://twitter.com/mask_3dcg/status/1617094871818596354?cn=ZmxleGlibGVfcmVjcw%3D%3D&refsrc=email

@LightColoredLines
Copy link

Hello. i still can't get Twitter to work on Brave since yesterday.
I'm using Arch Linux.
Brave version: [Version 1.48.158 Chromium: 110.0.5481.77 (Official Build) (64-bit)]
twitter

@fmarier
Copy link
Member

fmarier commented Feb 9, 2023

@LightColoredLines Twitter has been having lots of outages / problems lately (on their end). Try clearing your cookies and then accessing Twitter again.

@LightColoredLines
Copy link

@LightColoredLines Twitter has been having lots of outages / problems lately (on their end). Try clearing your cookies and then accessing Twitter again.

i already clear the cookies with All time option. still can't access it.
twitbrave

@fmarier
Copy link
Member

fmarier commented Feb 10, 2023

@LightColoredLines Thanks for trying that. Would you mind filing a new GitHub issue so that we can investigate? It's unlikely to be related to this problem since you're running the version with our fix.

@LightColoredLines
Copy link

@LightColoredLines Thanks for trying that. Would you mind filing a new GitHub issue so that we can investigate? It's unlikely to be related to this problem since you're running the version with our fix.

i have created the issue. #28459

@fmarier
Copy link
Member

fmarier commented Feb 13, 2023

Thanks @LightColoredLines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants