-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter link doesn't work #28184
Comments
There are a few query string parameters in the sample URL:
With the exception of |
Sample URL that breaks when `t` is removed: https://twitter.com/i/redirect?url=https%3A%2F%2Ftwitter.com%2Fmask_3dcg%2Fstatus%2F1617094871818596354%3Fcn%3DZmxleGlibGVfcmVjcw%253D%253D%26refsrc%3Demail&t=1+1674400145805&cn=ZmxleGlibGVfcmVjcw%3D%3D&sig=5d71ce9ef69b11a9f5e9ad0489166c17e89947ce&iid=93b0f359fc6f4fe795753cb5475c6801&uid=1360753837754048512&nid=244+276893697 See brave/brave-browser#28184.
The `t` parameter is required for the Twitter redirector to work. This reverts commit 2c2afa6.
Fix Twitter's redirector (fixes brave/brave-browser#28184)
The above requires |
Verification
Verified in 1.47.156 using original STR #28184 (comment)
Confirmed no error page shown and loaded correct page
|
Verification PASSED on
Using the STR/Cases outlined via brave/brave-core#16968 (comment), ensured that loading the following URL within a new tab correctly loaded the Twitter page rather than displaying an error as per the following:
|
@LightColoredLines Twitter has been having lots of outages / problems lately (on their end). Try clearing your cookies and then accessing Twitter again. |
i already clear the cookies with All time option. still can't access it. |
@LightColoredLines Thanks for trying that. Would you mind filing a new GitHub issue so that we can investigate? It's unlikely to be related to this problem since you're running the version with our fix. |
i have created the issue. #28459 |
Thanks @LightColoredLines |
Description
A user reported that it would be an error page(please see the attachment) if he click the twitter link like this. It’s solved by disabling Shields. But I would like to avoid replying like “Please access Twitter without Shields”. I hope we can find any solution for that.
Related issue: #26756
Steps to Reproduce
t
parameterActual result:
Expected result:
Twitter page will be shown.
Reproduces how often:
Easily reproduced
Desktop Brave version:
1.47.186
Version/Channel Information:
yes
yes
yes
Other Additional Information:
yes
The text was updated successfully, but these errors were encountered: