Uplift #1805 to 0.63 - OS appearance mode controls Brave appearance mode (light / dark theme) #1936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an uplift request for 0.63.x of #1805.
Reason for uplift request is that C63 has the 'Same as macOS' theme functionality launched in chrome. That is, the chrome light / dark mode will follow the macOS light / dark appearance mode. Without this PR, Brave will not automatically change, and has to be done manually from Settings.
Therefore this can be seen as a regression fix for 2 reasons:
Like this:
Fix brave/brave-browser#1189
Fix brave/brave-browser#1289