Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac build error with sdk 10.13 #1958

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 14, 2019

sdk_forward_declarations.h should be included when dark theme
related constants is used.

Fix brave/brave-browser#3724

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

sdk_forward_declarations.h should be included when dark theme
related constants is used.
@simonhong simonhong added this to the 0.64.x - Nightly milestone Mar 14, 2019
@simonhong simonhong self-assigned this Mar 14, 2019
@mihaiplesa mihaiplesa merged commit c35d559 into master Mar 15, 2019
@mihaiplesa mihaiplesa deleted the fix_mac_build_error_with_sdk_10_13 branch March 15, 2019 00:01
simonhong pushed a commit that referenced this pull request Mar 15, 2019
simonhong added a commit that referenced this pull request Mar 15, 2019
Uplift #1958 to 0.63.x - Fix mac build error with sdk 10.13
simonhong pushed a commit that referenced this pull request Mar 15, 2019
simonhong added a commit that referenced this pull request Mar 15, 2019
Uplift #1958 to 0.62.x - Fix mac build error with sdk 10.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error on mac with SDK 10.13
2 participants