Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change payment token redemption timing #1943

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Change payment token redemption timing #1943

merged 1 commit into from
Mar 25, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 14, 2019

fixes brave/brave-browser#3659

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • View an Ad and confirm token was redeemed on the server (speak with @maikelmclauflin and/or Jimmy for help with confirming). You can pass --rewards=debug=true to reduce token redemption from 7 days +/- jitter to 25 minutes +/- jitter. Test both fresh and existing user profiles. See console log and search for Start paying out for diagnostic information.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 14, 2019
@tmancey tmancey self-assigned this Mar 14, 2019
@tmancey tmancey requested a review from emerick March 15, 2019 12:11
emerick
emerick previously approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

components/services/bat_ledger/bat_ledger_service_impl.cc Show resolved Hide resolved
@tmancey tmancey requested review from diracdeltas and removed request for diracdeltas March 15, 2019 12:37
@tmancey tmancey requested a review from emerick March 19, 2019 13:23
emerick
emerick previously approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/3659 branch 2 times, most recently from 6cc6a2d to 007bbb3 Compare March 22, 2019 16:39
@tmancey tmancey requested a review from emerick March 25, 2019 13:18
emerick
emerick approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emerick
emerick approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit aa0bb45 into master Mar 25, 2019
@tmancey tmancey deleted the issues/3659 branch March 25, 2019 14:17
@tmancey tmancey mentioned this pull request Mar 25, 2019
Merged
@yrliou yrliou mentioned this pull request Mar 25, 2019
Closed
yrliou added a commit that referenced this pull request Mar 25, 2019
@yrliou
Merge pull request #2058 from brave/revert_pr_1943_and_2035
9f10c0c 
Revert PR #1943 and #2035
yrliou added a commit that referenced this pull request Mar 25, 2019
@yrliou
Merge pull request #2067 from brave/uplift_2058
a5452f4 
Uplift Revert PR #1943 and #2035 for 0.63.x
@tmancey tmancey restored the issues/3659 branch March 25, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@yrliou yrliou Awaiting requested review from yrliou

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@tmancey tmancey

Labels
feature/ads security
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.

Change payment token redemption timing
2 participants
@tmancey @emerick