Enable crash report on dev/nightly channel by default #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Mar 18, 2019
| * License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| #ifndef BRAVE_BROWSER_METRICS_METRICS_UTIL_H_ |
There was a problem hiding this comment.
nit: header guard doesn’t match file path
There was a problem hiding this comment.
Oops! I forgot to run lint again after renaming.
Done.
simonhong
force-pushed
the
enable_crash_report_on_dev_ni
branch
from
46ea27a
to
10f1181
Compare
darkdh
approved these changes
Mar 18, 2019
|
@darkdh Thanks for review! 👍 |
|
@bsclifton Should this be an uplift candidate for dev? |
|
@simonhong yes please! 😄 |
|
@simonhong you can actually go ahead and uplift this to beta |
simonhong
added a commit
that referenced
this pull request
Mar 18, 2019
Enable crash report on dev/nightly channel by default
|
@bsclifton I think uplifting to dev is sufficient because beta would not be changed at all with this PR. |
|
@simonhong makes sense 😄 thanks! |
|
@simonhong please also do this for Beta channel. We have updates to the website to indicate that as well. |
simonhong
added a commit
that referenced
this pull request
Mar 22, 2019
Enable crash report on dev/nightly channel by default
simonhong
added a commit
that referenced
this pull request
Mar 25, 2019
[0.62.x] Merge pull request #1985 from brave/enable_crash_report_on_dev_ni
This was referenced Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#1630
Test case only runs on linux because test is hard for different channel on other platforms.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
yarn test brave_unit_tests --filter=MetricsUtilTest.DefaultValueTestReviewer Checklist: