Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable crash report on dev/nightly channel by default (uplift to 0.63.x) #2002

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Enable crash report on dev/nightly channel by default (uplift to 0.63.x) #2002

merged 1 commit into from
Mar 19, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 18, 2019 •
edited by bsclifton
Loading

Enable crash report on dev/nightly channel by default

Uplift for #1985
Fixes brave/brave-browser#1630

@simonhong
Merge pull request #1985 from brave/enable_crash_report_on_dev_ni
8c340ed 
Enable crash report on dev/nightly channel by default
@simonhong simonhong added this to the 0.63.x - Dev milestone Mar 18, 2019
@simonhong simonhong self-assigned this Mar 18, 2019
bsclifton
bsclifton approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @rebron, @kjozwiak, @srirambv, and @bbondy - we're all 👍 on including this in dev 😄

@bsclifton bsclifton merged commit 175a27a into 0.63.x Mar 19, 2019
@bsclifton bsclifton deleted the enable_crash_report_on_dev_uplift_63 branch March 19, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bsclifton