Fix release mode brave_unit_tests crash on Windows #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regression of #158.
During the initialization of unit test, channel info is accessed.
However, |g_module_details| isn't initialized in test.
Before the above PR, channel was always Channel::UNKNOWN.
So, channel info can be fetched without accessing |g_module_details|.
After the above PR, channel info is fetched via |g_module_details| in
release mode. So crash is happened because |g_module_details| is
nullptr.
Fixed by initializing install details explicitly.
Close: brave/brave-browser#443
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Run
yarn test brave_unit_tests Release
on WindowsReviewer Checklist: