Sync dont send bookmarks when no chain #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found it sends extra create device record if upgraded from the old version. PR is not ready yet. |
AlexeyBarabash
force-pushed
the
sync_dont_send_bookmarks_when_no_chain
branch
from
dff630d
to
ec12bf4
Compare
darkdh
reviewed
Mar 21, 2019
darkdh
approved these changes
Mar 21, 2019
AlexeyBarabash
added a commit
that referenced
this pull request
Mar 25, 2019
…chain Sync dont send bookmarks when no chain
AlexeyBarabash
added a commit
that referenced
this pull request
Mar 25, 2019
…chain Sync dont send bookmarks when no chain
This was referenced Mar 25, 2019
AlexeyBarabash
added a commit
that referenced
this pull request
Mar 29, 2019
…chain_0.63.x Merge pull request #2016 from brave/sync_dont_send_bookmarks_when_no_…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3777 (Sync: not all bookmarks synced).
Fixes brave/brave-browser#3509 (Bookmarks are synced when not connected to sync chain).
Fixes brave/brave-browser#2687 (Sync sends bookmarks even when chain is not fully created).
For #3509 and #2687 fix is obvious.
For #3777 description is brave/brave-browser#3777 (comment).
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Use STR from
brave/brave-browser#3777
brave/brave-browser#3509
brave/brave-browser#2687
Reviewer Checklist: