Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks are synced when not connected to sync chain #3509

Closed
btlechowski opened this issue Feb 27, 2019 · 5 comments · Fixed by brave/brave-core#2016
Closed

Bookmarks are synced when not connected to sync chain #3509

btlechowski opened this issue Feb 27, 2019 · 5 comments · Fixed by brave/brave-core#2016

Comments

@btlechowski
Copy link

Found when verifying #3225

Steps to Reproduce

  1. Create sync chain brave-core device1
  2. Connect to sync chain brave-core device2
  3. Create bookmark on device1 and ensure it is synced to device2
  4. Copy sync codes from device1
  5. On device2 press Leave Sync Chain
  6. Wait until both devices will get sync turned off
  7. Try to sync brave-core device3 with sync codes from 4.

Actual result:

bookmark is synced, even though joining sync chain fails.

On device3:
sync fail

Expected result:

bookmark is not synced.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

device1: brave 0.61.38 on Windows 7
device2: brave 0.62.8 on Windows 7
device3: brave 0.61.38 on Ubuntu 17.10

Brave 0.61.38 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Related issues: #2687

cc @brave/legacy_qa @AlexeyBarabash

@rebron
Copy link
Collaborator

rebron commented Mar 1, 2019

Related to #2148

@kjozwiak
Copy link
Member

@AlexeyBarabash did this land in 0.64.x? Can you add the appropriate milestone to this issue including brave/brave-core#2016?

@AlexeyBarabash AlexeyBarabash added this to the 0.64.x - Nightly milestone Mar 22, 2019
@AlexeyBarabash
Copy link
Contributor

@kjozwiak , yes, sorry, missed milestone 2nd time in row after merging.
Done.

@btlechowski
Copy link
Author

btlechowski commented Apr 4, 2019

Verification passed on

Brave 0.63.30 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Used test plan from the description

Verified passed with

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X
  • Verified STR from description 3x, each time bookmark was not synced.

Verification passed on

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Used test plan from the description

@bsclifton
Copy link
Member

Removed from release-notes/include since impact to customer is the same as #2687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment