Device removed from sync chain still receives new bookmarks/folders

[srirambv]

Description:

Device removed from sync chain still receives new bookmarks/folders

Devices

Device 1: Ubuntu 18 running 0.61.47
Device 2: iPhone 7+ running 1.9(19.3.6.15)

Steps to Reproduce

1. Add bookmarks and create sync chain on desktop
2. Add iPhone to sync chain using QR code, ensure bookmarks sync
3. Remove desktop from iPhone under devices, ensure desktop shows sync home page
4. Add new bookmarks/folders on iPhone, after a while, new bookmarks/folders are sync'd on desktop as well

Actual result:
Desktop getting bookmarks after removed from sync chain

iOS sync chain with only one device

Expected result:
Once device is removed any new bookmarks added should not be propagated to any device that was removed from the sync chain

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

[srirambv]

Any bookmark added on desktop gets sync'd to iOS device as well.

[iccub]

Could you check if this happens on Android?

From my tests I noticed that the device doesn't get correctly deleted on desktop.
Look at SS below,

I synced 3 devices: iPhone, iPad, desktop
On iPad removed desktop, and as on the screenshot, it still shows sync menu with only iPhone and iPad

This still might indicate that our delete device command is wrong and doesn't work well with desktop

[iccub]

Found this issue on desktop brave/brave-browser#3509

I think it needs a fix on desktop, not on iOS

[jhreis]

This is certainly a desktop issue. It got the removal request from iOS since it updated the UI, but continues retrieving and sending bookmarks. Closing per @iccub's investigation.

[GeetaSarvadnya]

The issue is reproducible on 1.9 (19.03.25.21)- iPhone8

@srirambv As per above comments issue is with Desktop, are you going to add an issue in bc desktop?

[iccub]

@GeetaSarvadnya it's logged here brave/brave-browser#3509

[srirambv]

This issue needs to be reverified once brave/brave-browser#3509 is fixed.

cc: @brave/legacy_qa

[kjozwiak]

Reproduced the original issue using the following builds:

• 1.9 (19.3.27.19) on iPad Mini 4
• 0.61.52 Chromium: 73.0.3683.86

I couldn't reproduce the issue using the following builds:

• 1.9 (19.3.27.19) on iPad Mini 4
• 0.64.22 Chromium: 73.0.3683.75

Went through the original STR three times using 0.64.22 Chromium: 73.0.3683.75 and waited ~30min. Once desktop was removed from the sync chain, it never received new changes as expected.

[kjozwiak]

• Verification PASSED with 1.9 (19.3.27.19) on iPad Mini 4 using the original STR mentioned under Device removed from sync chain still receives new bookmarks/folders #952 (comment). Also left comment under Device removed from sync chain still receives new bookmarks/folders #952 (comment).