Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert c74 with deps #2088

Merged
merged 4 commits into from
Mar 27, 2019
Merged

Revert c74 with deps #2088

merged 4 commits into from
Mar 27, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Mar 27, 2019

DO NOT MERGE. Just testing if DEPS are needed for C74 revert.

bsclifton and others added 4 commits March 26, 2019 18:35
@bsclifton
Revert "Tokens that fail to redeem due to network errors should be ad…
93a028b 
…ded to a queue and retried"

This reverts commit fded297.
@bsclifton
Revert Chromium 74
66e6c95 
(originally implemented with #2013)

Fixes brave/brave-browser#3898
@jumde @bsclifton
Revert "Merge pull request #2029 from brave/fix_3816"
e882cec 
This reverts commit 27c5932, reversing
changes made to 2a6fe67.
@jumde
Updated DEPS
c04301c
@jumde jumde self-assigned this Mar 27, 2019
@mihaiplesa mihaiplesa self-requested a review March 27, 2019 09:29
@mihaiplesa mihaiplesa changed the title WIP: Revert c74 with deps Revert c74 with deps Mar 27, 2019
@bbondy bbondy merged commit f6cfa13 into master Mar 27, 2019
jumde added a commit that referenced this pull request Mar 27, 2019
@jumde
Revert "Merge pull request #2088 from brave/revert-c74-with-deps"
6fa3646 
This reverts commit f6cfa13, reversing
changes made to 6143676.
This was referenced Mar 27, 2019
Merged
Closed
mkarolin added a commit that referenced this pull request Mar 28, 2019
@mkarolin
Revert "Merge pull request #2088 from brave/revert-c74-with-deps"
ec2bfa1 
Reland C74 on master.

This reverts commit f6cfa13, reversing
changes made to 6143676.
@mkarolin mkarolin mentioned this pull request Mar 28, 2019
Closed
19 tasks
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 28, 2019
@bsclifton bsclifton deleted the revert-c74-with-deps branch March 28, 2019 06:45
mkarolin added a commit that referenced this pull request Apr 1, 2019
@mkarolin
Revert "Merge pull request #2088 from brave/revert-c74-with-deps"
8114d82 
Reland C74 on master.

This reverts commit f6cfa13, reversing
changes made to 6143676.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa mihaiplesa approved these changes

@bbondy bbondy bbondy approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@jumde @bbondy @mihaiplesa @bsclifton