Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove X-Brave-Partner from CORS safelisted request headers #22539

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Mar 11, 2024

Fixes brave/brave-browser#6041

This reverts commit 0ffd590.

It should have been removed as part of 4cb8c2f (brave/brave-browser#34971).

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@fmarier fmarier self-assigned this Mar 11, 2024
@fmarier fmarier requested review from a team as code owners March 11, 2024 21:58
@fmarier fmarier requested a review from bsclifton March 11, 2024 21:59
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ++

@fmarier fmarier merged commit 03cf508 into master Mar 13, 2024
20 checks passed
@fmarier fmarier deleted the remove-partner-header-from-cors-6041 branch March 13, 2024 19:11
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove X-Brave-Partner from CORS safelist
3 participants