Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove X-Brave-Partner from CORS safelist #6041

Closed
bsclifton opened this issue Sep 16, 2019 · 3 comments · Fixed by brave/brave-core#22539
Closed

Remove X-Brave-Partner from CORS safelist #6041

bsclifton opened this issue Sep 16, 2019 · 3 comments · Fixed by brave/brave-core#22539
Assignees
@fmarier
Labels
custom headers OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude sec-low
Milestone
1.65.x - Release

Comments

@bsclifton
Copy link
Member

Description

Initially added after Chromium 77 upgrade with brave/brave-core#3434

Per security review, this should be a temporary change.

A great time to do this would be when switching to our own user-agent for partners (see #1052)
@bsclifton bsclifton mentioned this issue Sep 16, 2019
Merged
32 tasks
@bridiver bridiver changed the title Remove safelisting for X-Brave-Partner CORS request header Remove X-Brave-Partner header and CORS safelist Jun 12, 2020
@kkuehlz kkuehlz mentioned this issue Jun 12, 2020
Closed
32 tasks
kkuehlz added a commit to brave/brave-core that referenced this issue Jun 13, 2020
@kkuehlz
Deprecate partner headers
8aa730b 
navigator.brave.isBrave() can be used to identify brave.

Resolves brave/brave-browser#6041
@fmarier
Copy link
Member

fmarier commented Jun 16, 2021

Also see #16455 for an interim step in the deprecation process.

@bsclifton
Copy link
Member Author

This is now gone; we should remove the unused constant:
https://github.com/brave/brave-core/blob/cd4c8a416df4a66ba892ba5de9a92253544e28cd/components/constants/network_constants.h#L70

@fmarier
Copy link
Member

fmarier commented Mar 11, 2024

Thanks @bsclifton I will use this issue for the CORS cleanup.

@fmarier fmarier reopened this Mar 11, 2024
@fmarier fmarier self-assigned this Mar 11, 2024
@fmarier fmarier changed the title Remove X-Brave-Partner header and CORS safelist Remove X-Brave-Partner from CORS safelist Mar 11, 2024
fmarier added a commit to brave/brave-core that referenced this issue Mar 11, 2024
@fmarier
Remove X-Brave-Partner from CORS safelisted request headers (fixes br…
7e0363d 
…ave/brave-browser#6041)

This reverts commit 0ffd590.

It should have been removed as part of 4cb8c2f.
@fmarier fmarier mentioned this issue Mar 11, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 13, 2024
@fmarier fmarier added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
custom headers OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude sec-low
Projects
Security & Privacy
Status: Completed
Milestone
1.65.x - Release
4 participants
@fmarier @bsclifton @kkuehlz @brave-builds