-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 5952: Add X-Brave-Partner to CORS safelisted request headers #3434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this works great! Nice work 😄
I cherry-picked into 0.68.x... will let @bridiver assess the patch and other aspects of this PR
46aa192
to
0ffd590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security review for this passed; it has been deployed to release channel with 0.68.136
As noted in security review, we'll want to revert this at some point:
- when partners can whitelist the header
- we change to a UA based detection for partners
Created brave/brave-browser#6041 as a follow up |
Issue 5952: Add X-Brave-Partner to CORS safelisted request headers
Issue 5952: Add X-Brave-Partner to CORS safelisted request headers
Fix brave/brave-browser#5952
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.