Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5952: Add X-Brave-Partner to CORS safelisted request headers (uplift to 0.71.x) #3451

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Issue 5952: Add X-Brave-Partner to CORS safelisted request headers (uplift to 0.71.x) #3451

merged 1 commit into from
Sep 16, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 16, 2019 •
edited by bsclifton
Loading

Uplift of #3434

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Sep 16, 2019
@brave-builds brave-builds added this to the 0.71.x - Dev milestone Sep 16, 2019
bsclifton
bsclifton approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since changes have already been deployed with 0.68.x (Chromium 77) and this is needed before a new build is queued

@bsclifton bsclifton merged commit 7ad489a into 0.71.x Sep 16, 2019
@bsclifton bsclifton deleted the pr3434_update_safelisted_headers_0.71.x branch September 16, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

@bbondy bbondy Awaiting requested review from bbondy

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @bsclifton @brave-browser-releases