Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): compressed NFTs frontend support #24396

Merged
merged 3 commits into from
Jul 11, 2024
Merged

feat(wallet): compressed NFTs frontend support #24396

merged 3 commits into from
Jul 11, 2024

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Jun 26, 2024 •
edited
Loading

Resolves brave/brave-browser#39408

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See STR in attached issue

@josheleonard josheleonard self-assigned this Jun 26, 2024
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jun 26, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the feat--wallet-compressed-nfts-frontend-support branch from f040463 to c61fdde Compare June 27, 2024 16:46
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the feat--wallet-compressed-nfts-frontend-support branch from c61fdde to e6c73ae Compare June 28, 2024 15:06
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard marked this pull request as ready for review July 2, 2024 16:16
@josheleonard josheleonard requested review from a team as code owners July 2, 2024 16:16
onyb
onyb reviewed Jul 2, 2024
View reviewed changes
components/brave_wallet_ui/common/slices/endpoints/transaction.endpoints.ts
Comment on lines +1788 to +1791
const priorityFee =
(BigInt(fee.computeUnits) * BigInt(fee.feePerComputeUnit)) /
BigInt(BraveWallet.MICRO_LAMPORTS_PER_LAMPORT)
const totalFee = BigInt(fee.baseFee) + priorityFee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to use Amount here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just formatting changes. I did not author this logic

@nvonpentz
Copy link
Member

Probably should merge this after #24571

nvonpentz
nvonpentz approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@nvonpentz nvonpentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending merge of https://github.com/brave/brave-core/pull/24571/files

Douglashdaniel
Douglashdaniel approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@josheleonard josheleonard merged commit 5a23072 into master Jul 11, 2024
19 checks passed
@josheleonard josheleonard deleted the feat--wallet-compressed-nfts-frontend-support branch July 11, 2024 21:33
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyb onyb onyb left review comments

@nvonpentz nvonpentz nvonpentz approved these changes

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

Assignees

@josheleonard josheleonard

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging this pull request may close these issues.

[Wallet] Support Solana Compressed NFTs (cNFTs) in wallet frontend
5 participants
@josheleonard @brave-builds @nvonpentz @onyb @Douglashdaniel