Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip preflight checks for compressed NFT transfers #24571

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

nvonpentz
Copy link
Member

@nvonpentz nvonpentz commented Jul 9, 2024

Unless preflight checks have been explicitly set to true by dapps.

Resolves brave/brave-browser#39704

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Unless preflight checks have been explicitly set to true by dapps.
@nvonpentz nvonpentz force-pushed the skip-preflight-compressed-transfers branch from dcc8d78 to af9e275 Compare July 10, 2024 21:09
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nvonpentz nvonpentz force-pushed the skip-preflight-compressed-transfers branch from af9e275 to 45dae6a Compare July 10, 2024 22:39
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nvonpentz nvonpentz force-pushed the skip-preflight-compressed-transfers branch from 45dae6a to 5020fbc Compare July 11, 2024 13:33
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

1 similar comment
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nvonpentz nvonpentz enabled auto-merge (squash) July 11, 2024 18:03
@nvonpentz nvonpentz force-pushed the skip-preflight-compressed-transfers branch from 9f3aff5 to 5020fbc Compare July 11, 2024 18:13
@nvonpentz nvonpentz merged commit 0def99a into master Jul 11, 2024
18 checks passed
@nvonpentz nvonpentz deleted the skip-preflight-compressed-transfers branch July 11, 2024 18:13
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preflight checks fail frequently for NFT transfers
3 participants