Disable domain reliability service #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses brave/brave-browser#514
darkdh
approved these changes
Jul 12, 2018
bridiver
reviewed
Jul 12, 2018
| @@ -17,6 +17,9 @@ using BraveProfilePrefsBrowserTest = InProcessBrowserTest; | |||
| IN_PROC_BROWSER_TEST_F(BraveProfilePrefsBrowserTest, DownloadPromptDefault) { | |||
| EXPECT_TRUE( | |||
| browser()->profile()->GetPrefs()->GetBoolean(prefs::kPromptForDownload)); | |||
| } | |||
|
|
|||
| IN_PROC_BROWSER_TEST_F(BraveProfilePrefsBrowserTest, WidevineOptInDisabledByDefault) { | |||
There was a problem hiding this comment.
I just happened to notice it was wrongly grouped in DownloadPromptDefault so I added a line to make it its own test.
srirambv
pushed a commit
to srirambv/brave-core
that referenced
this pull request
Aug 20, 2018
cezaraugusto
added a commit
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses brave/brave-browser#514
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: