Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service text to match button #2481

Merged
merged 1 commit into from
May 23, 2019
Merged

Added service text to match button #2481

merged 1 commit into from
May 23, 2019

Conversation

jdkuki
Copy link
Contributor

@jdkuki jdkuki commented May 22, 2019

image

Related: brave/brave-browser#4489
brave/brave-ui/pull/473

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

ryanml
ryanml previously approved these changes May 22, 2019
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ lgtm. once we confirm jenkins failure is unrelated (highly unlikely that it is the result of something in this pull) we can go ahead and update the UI hash

@ryanml ryanml self-requested a review May 23, 2019 21:18
@ryanml ryanml merged commit 73ddace into master May 23, 2019
@ryanml ryanml deleted the service-text-ready branch May 23, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants