Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Service text ready #473

Merged
merged 1 commit into from
May 23, 2019
Merged

Service text ready #473

merged 1 commit into from
May 23, 2019

Conversation

jdkuki
Copy link
Contributor

@jdkuki jdkuki commented May 21, 2019

Related: brave/brave-browser#4489

Changes

Changed service text to match the text on button.

Test plan

Link / storybook path to visual changes

https://brave-ui-mfe6xww2v.now.sh

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@jdkuki jdkuki requested review from ryanml and NejcZdovc May 21, 2019 21:32
@jdkuki jdkuki merged commit af9554c into master May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants