Adds retries for unverified publishers

[NejcZdovc]

Resolves brave/brave-browser#3741

UI PR: brave/brave-ui#482

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
  • Windows
  • macOS
  • Linux
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection

Test Plan:

• enable rewards
• close browser
• go to publisher_list and change second value for 3zsistemi.si to false from ["3zsistemi.si",true,false.... to ["3zsistemi.si",false,false....
• start the browser
• add tip to unverified site
• add tip for 10, 10, 5 and 10 to 3zsistemi.si
• add another tip to unverified site
• go to 3zsistemi.si, open panel and click check again
• go to settings page and observe the page after couple of minutes 3 pending contributions (10, 10, 5) should be processed and you should have two notifications (new publisher verified and out of funds)
• open pending contributions dialog and make sure that you see 3 tips (2 to your unverified site and one to 3zsistemi for 10)

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[emerick]

Basically LGTM, just had a few comments.

[emerick]

LGTM, just had one suggestion.

[emerick]

LGTM

[LaurenWags]

Tested the following items on Nightly - primarily using:

Brave	0.68.39 Chromium: 75.0.3770.87 (Official Build) nightly(64-bit)
Revision	9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS	Mac OS X

1. Ran test plan as is from above. Worked as described. Tried 3x.
2. After running thru test plan, navigated to an unverified site and clicked 'Refresh Status'. Got 2nd Notification for 'Insufficient Funds - You have pending tips due to insufficient funds'. Per Retries for unverified Publishers  brave-browser#3741 (comment) was only expecting this once (one bullet pt in comment says "if tips fail due to lack of funds, notify first time ONLY when users retry"). - logged multiple Insufficient Funds due to pending tips notification - follow up to 3741 brave-browser#4757
3. Verified all 'Types' (shown on pending contributions list - Auto Contribute, One-time Tip, Recurring Tip) are removed from pending list when publisher verifies. All are converted to 'One-time' tips in Tips panel. Note - AC values are rounded down to nearest whole number, i.e. 2.6 BAT in list becomes a 2.0 BAT tip. Logged pending AC values are rounded once publisher verifies - follow up to 3741 brave-browser#4886 for this.
4. Re-ran test plan but substituted some of the Tips from test plan to be auto contribute values and recurring tips. All were removed from pending list and added to Tips panel as one-time tips expected.
5. Verified sites were removed from 'Pending Contributions' list. Used the following general outline: populated pending contributions list. Closed Brave. Modified DB so that the 'Pending Until' date was today's date. Opened Brave, verified I could see the date changes on pending contributions list. Navigated to a site and clicked 'Refresh Status' in panel. Verified that when I went back to pending contributions list the sites I had changed were no longer displayed. Verified that the amount of pending BAT (on brave://rewards and visible from panel when accessed from BAT logo) decreased appropriately.
6. Verified that if a YouTube, Twitch, or Twitter publisher is in the pending contributions list and the publisher verifies, they are removed from the list, and their pending contribution is converted to a one-time tip (listed in tips panel on brave://rewards). Note, the notification which shows on BAT logo when a publisher from pending list has verified, does not list platform - i.e. 'on YouTube', 'on Twitch', etc. Asked about this, was told it's expected due to space constraints.

cc @kjozwiak

[kjozwiak]

Basically went through the same cases @LaurenWags did above on Windows during the weekend everything seems like it's working as expected. Thanks for the detailed summary @LaurenWags! It was really helpful when going through checks on me end 👍