This repository has been archived by the owner on May 13, 2024. It is now read-only.
Adds Add Funds button to the notification #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
unverified-retries
branch
from
873329a
to
a269943
Compare
28 tasks
NejcZdovc
force-pushed
the
unverified-retries
branch
from
a269943
to
6ac10fa
Compare
NejcZdovc
force-pushed
the
unverified-retries
branch
2 times, most recently
from
654ae70
to
00beef4
Compare
| @@ -170,7 +170,7 @@ export default class Profile extends React.PureComponent<Props, {}> { | |||
| { | |||
| this.getUnverifiedInfo() | |||
| } | |||
| <StyledVerifiedCheckLink onClick={onRefreshPublisher}> | |||
| <StyledVerifiedCheckLink onClick={onRefreshPublisher} data-test-id={'unverified-check-button'}> | |||
There was a problem hiding this comment.
Are you going to need this across the other instances or just the "clickable"
There was a problem hiding this comment.
it's just so that I can trigger a click
| 'tipsProcessed' | | ||
| 'error' | | ||
| 'pendingContribution' | | ||
| '' |
There was a problem hiding this comment.
I know this is just alignment mod but do we need the ''. The default case already handles
There was a problem hiding this comment.
isn't default case right for this use case, when you have empty string as type can't be null
NejcZdovc
force-pushed
the
unverified-retries
branch
7 times, most recently
from
b443c06
to
8e50405
Compare
NejcZdovc
force-pushed
the
unverified-retries
branch
from
8e50405
to
b8d7ace
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed in brave/brave-core#2512
Changes
Test plan
Link / storybook path to visual changes
Integration
Does this contain changes to src/components or src/
Does this contain changes to src/features for brave-core?