Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Commit

Permalink
Merge pull request #482 from brave/unverified-retries
Browse files Browse the repository at this point in the history
Adds Add Funds button to the notification
  • Loading branch information
NejcZdovc authored Jun 5, 2019
2 parents dbc5cda + b8d7ace commit 7f88568
Show file tree
Hide file tree
Showing 13 changed files with 43 additions and 11 deletions.
1 change: 1 addition & 0 deletions src/features/rewards/amount/__snapshots__/spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ exports[`Amount tests basic tests matches the snapshot 1`] = `
<button
className="c0"
data-test-id="amount-wrapper"
id="amount"
onClick={[Function]}
>
Expand Down
2 changes: 1 addition & 1 deletion src/features/rewards/amount/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default class Amount extends React.PureComponent<Props, {}> {
const { id, onSelect, amount, selected, type, converted, currency, isMobile } = this.props

return (
<StyledWrapper id={id} onClick={onSelect.bind(this, amount)} isMobile={isMobile}>
<StyledWrapper id={id} onClick={onSelect.bind(this, amount)} isMobile={isMobile} data-test-id={'amount-wrapper'}>
<StyledAmount selected={selected} type={type} isMobile={isMobile}>
<StyledLogo isMobile={isMobile}><BatColorIcon /></StyledLogo><StyledNumber>{amount}</StyledNumber> <StyledTokens>{type === 'big' ? 'BAT' : null}</StyledTokens>
</StyledAmount>
Expand Down
1 change: 1 addition & 0 deletions src/features/rewards/donate/__snapshots__/spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ exports[`Donate tests basic tests matches the snapshot 1`] = `
</div>
<div
className="c4"
data-test-id="send-tip-button"
onClick={[Function]}
>
<div
Expand Down
4 changes: 2 additions & 2 deletions src/features/rewards/donate/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export default class Donate extends React.PureComponent<Props, State> {
<StyledAmountsWrapper isMobile={isMobile}>
{
donationAmounts && donationAmounts.map((donation: Donation) => {
return <div key={`${id}-donate-${donation.tokens}`}>
return <div key={`${id}-tip-${donation.tokens}`}>
<Amount
isMobile={isMobile}
amount={donation.tokens}
Expand All @@ -130,7 +130,7 @@ export default class Donate extends React.PureComponent<Props, State> {
{children}
</StyledContent>

<StyledSend onClick={this.validateDonation}>
<StyledSend onClick={this.validateDonation} data-test-id={'send-tip-button'}>
<StyledButtonWrapper isMobile={isMobile}>
<StyledSendButton>
<StyledIconSend disabled={disabled} donateType={donateType}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,13 @@ exports[`Grant complete tests basic tests matches the snapshot 1`] = `
>
<button
className="c5 c6"
id="grant-completed-ok"
size="call-to-action"
type="accent"
>
<div
className="c7"
id="grant-completed-ok"
size="call-to-action"
type="accent"
>
Expand Down
1 change: 1 addition & 0 deletions src/features/rewards/grantComplete/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export default class GrantComplete extends React.PureComponent<Props, {}> {
size={'call-to-action'}
type={'accent'}
onClick={onClose}
id={'grant-completed-ok'}
/>
</StyledButtonWrapper>
</StyledWrapper>
Expand Down
5 changes: 3 additions & 2 deletions src/features/rewards/listToken/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export interface Props {
size?: Size
color?: Type
border?: 'first' | 'last' | 'default'
testId?: string
}

export default class ListToken extends React.PureComponent<Props, {}> {
Expand All @@ -23,10 +24,10 @@ export default class ListToken extends React.PureComponent<Props, {}> {
}

render () {
const { id, title, value, converted, isNegative, size, color, border } = this.props
const { id, title, value, converted, isNegative, size, color, border, testId } = this.props

return (
<StyledWrapper id={id} border={border}>
<StyledWrapper id={id} border={border} data-test-id={testId}>
<StyledTitle>{title}</StyledTitle>
<StyledContentWrapper>
<Tokens
Expand Down
2 changes: 1 addition & 1 deletion src/features/rewards/profile/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export default class Profile extends React.PureComponent<Props, {}> {
{
this.getUnverifiedInfo()
}
<StyledVerifiedCheckLink onClick={onRefreshPublisher}>
<StyledVerifiedCheckLink onClick={onRefreshPublisher} data-test-id={'unverified-check-button'}>
{getLocale('unVerifiedCheck')}
</StyledVerifiedCheckLink>
</StyledProviderWrap>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,7 @@ exports[`List tests basic tests matches the snapshot 1`] = `
</div>
<div
className="c27"
data-test-id="send-tip-button"
onClick={[Function]}
>
<div
Expand Down
1 change: 1 addition & 0 deletions src/features/rewards/tip/__snapshots__/spec.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ exports[`Tip tests basic tests matches the snapshot 1`] = `
</div>
<div
className="c16"
data-test-id="send-tip-button"
onClick={[Function]}
>
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ exports[`WalletSummary tests basic tests matches the snapshot 1`] = `
<div>
<div
className="c4"
data-test-id="summary-grant"
>
<div
className="c5"
Expand Down Expand Up @@ -233,6 +234,7 @@ exports[`WalletSummary tests basic tests matches the snapshot 1`] = `
</div>
<div
className="c4"
data-test-id="summary-ads"
>
<div
className="c5"
Expand Down Expand Up @@ -274,6 +276,7 @@ exports[`WalletSummary tests basic tests matches the snapshot 1`] = `
</div>
<div
className="c4"
data-test-id="summary-contribute"
>
<div
className="c5"
Expand Down Expand Up @@ -315,6 +318,7 @@ exports[`WalletSummary tests basic tests matches the snapshot 1`] = `
</div>
<div
className="c4"
data-test-id="summary-donation"
>
<div
className="c5"
Expand Down Expand Up @@ -356,6 +360,7 @@ exports[`WalletSummary tests basic tests matches the snapshot 1`] = `
</div>
<div
className="c4"
data-test-id="summary-tips"
>
<div
className="c5"
Expand Down
5 changes: 3 additions & 2 deletions src/features/rewards/walletSummary/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export default class WalletSummary extends React.PureComponent<Props, {}> {
current++
result.push((
<ListToken
testId={`summary-${item.key}`}
key={`summary-${tokenSize}-${index}-${data.tokens}`}
size={tokenSize}
value={data.tokens}
Expand Down Expand Up @@ -144,8 +145,8 @@ export default class WalletSummary extends React.PureComponent<Props, {}> {
{this.generateList()}
{
reservedAmount && reservedAmount > 0
? <StyledReservedWrapper>
{getLocale('reservedAmountText', { reservedAmount })} <StyledReservedLink href={reservedMoreLink} target={'_blank'}>
? <StyledReservedWrapper data-test-id={'pending-contribution-box'}>
{getLocale('reservedAmountText', { reservedAmount: reservedAmount.toFixed(1) })} <StyledReservedLink href={reservedMoreLink} target={'_blank'}>
{getLocale('reservedMoreLink')}
</StyledReservedLink>
{
Expand Down
24 changes: 21 additions & 3 deletions src/features/rewards/walletWrapper/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,17 @@ export interface ActionWallet {
testId?: string
}

export type NotificationType = 'ads' | 'ads-launch' | 'backupWallet' | 'contribute' | 'grant' | 'insufficientFunds' | 'tipsProcessed' | 'error' | ''
export type NotificationType =
'ads' |
'ads-launch' |
'backupWallet' |
'contribute' |
'grant' |
'insufficientFunds' |
'tipsProcessed' |
'error' |
'pendingContribution' |
''

export interface Notification {
id: string
Expand Down Expand Up @@ -264,6 +274,10 @@ export default class WalletWrapper extends React.PureComponent<Props, State> {
buttonText = getLocale('backupNow')
buttonAction = this.onNotificationClick
break
case 'insufficientFunds':
buttonText = getLocale('addFunds')
buttonAction = this.onNotificationClick
break
default:
buttonText = getLocale('ok').toUpperCase()
break
Expand All @@ -289,8 +303,8 @@ export default class WalletWrapper extends React.PureComponent<Props, State> {

return (
<>
<StyledNotificationCloseIcon>
<CloseCircleOIcon onClick={onClose} />
<StyledNotificationCloseIcon data-test-id={'notification-close'} onClick={onClose}>
<CloseCircleOIcon />
</StyledNotificationCloseIcon>
<StyledNotificationContent>
{this.getNotificationIcon(notification)}
Expand Down Expand Up @@ -323,6 +337,7 @@ export default class WalletWrapper extends React.PureComponent<Props, State> {
break
case 'contribute':
case 'tipsProcessed':
case 'pendingContribution':
icon = loveIconUrl
break
case 'grant':
Expand Down Expand Up @@ -370,6 +385,9 @@ export default class WalletWrapper extends React.PureComponent<Props, State> {
case 'tipsProcessed':
typeText = getLocale('contributionTips')
break
case 'pendingContribution':
typeText = getLocale('pendingContributionTitle')
break
default:
typeText = ''
break
Expand Down

0 comments on commit 7f88568

Please sign in to comment.