Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs]: Increase opacity, decrease size of separator, remove unused patch #25353

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Aug 27, 2024

Resolves brave/brave-browser#40714

New separators:

Light:
Screenshot from 2024-08-28 11-53-30

Dark:
Screenshot from 2024-08-28 11-53-11

cc @rebron @aguscruiz

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open 4 tabs
  2. Separators should be more subtle and smaller
  3. Change to dark mode - same thing

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patches++

Copy link
Collaborator

@aguscruiz aguscruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @rebron what do you think?

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) August 28, 2024 00:39
@fallaciousreasoning fallaciousreasoning merged commit bd20b9b into master Aug 28, 2024
22 checks passed
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Aug 28, 2024
mkarolin pushed a commit that referenced this pull request Aug 28, 2024
…atch (#25353)

* [Tabs]: Increase opacity, decrease size of separator, remove unused patch

* Change color to 75% opacity after talking to @aguscruiz again

* Better height override
mkarolin pushed a commit that referenced this pull request Aug 28, 2024
…atch (#25353)

* [Tabs]: Increase opacity, decrease size of separator, remove unused patch

* Change color to 75% opacity after talking to @aguscruiz again

* Better height override
@LaurenWags
Copy link
Member

Verified with

Brave	1.71.42 Chromium: 128.0.6613.85 (Official Build) nightly (x86_64) 
Revision	506b78c7d47f45d56fbc580616ca8626847e345d
OS	macOS Version 13.6.9 (Build 22G830)

Confirmed tab separator appears smaller and lighter when compared to 1.71.37 when using both light and dark themes.

1.71.37 1.71.42
37 lt 42 lt
37 dk 42 dk

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.71.42 Chromium: 128.0.6613.85 (Official Build) nightly (64-bit)
-- | --
Revision | 506b78c7d47f45d56fbc580616ca8626847e345d
OS | Windows 11 Version 23H2 (Build 22631.4037)

Using the STR/Cases and examples from both #25353 (comment) & brave/brave-browser#40714 (comment), ensured that the new tab separator's are being used with the reduced contrast as per the following:

1.71.37 1.71.42
oldLight latestLight
oldDark latestDark

@fallaciousreasoning
Copy link
Contributor Author

Thanks for making the uplifts @mkarolin

kjozwiak pushed a commit that referenced this pull request Aug 28, 2024
….x) (#25362)

[Tabs]: Increase opacity, decrease size of separator, remove unused patch (#25353)

* [Tabs]: Increase opacity, decrease size of separator, remove unused patch

* Change color to 75% opacity after talking to @aguscruiz again

* Better height override

Co-authored-by: Jay Harris <jay.harris@outlook.co.nz>
kjozwiak pushed a commit that referenced this pull request Aug 28, 2024
….x) (#25363)

[Tabs]: Increase opacity, decrease size of separator, remove unused patch (#25353)

* [Tabs]: Increase opacity, decrease size of separator, remove unused patch

* Change color to 75% opacity after talking to @aguscruiz again

* Better height override

Co-authored-by: Jay Harris <jay.harris@outlook.co.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up - Tab separator has too much contrast on both light and dark mode
7 participants