-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs]: Increase opacity, decrease size of separator, remove unused patch #25353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patches
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @rebron what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
…atch (#25353) * [Tabs]: Increase opacity, decrease size of separator, remove unused patch * Change color to 75% opacity after talking to @aguscruiz again * Better height override
…atch (#25353) * [Tabs]: Increase opacity, decrease size of separator, remove unused patch * Change color to 75% opacity after talking to @aguscruiz again * Better height override
Verification PASSED on
Using the STR/Cases and examples from both #25353 (comment) & brave/brave-browser#40714 (comment), ensured that the new tab separator's are being used with the reduced contrast as per the following:
|
Thanks for making the uplifts @mkarolin |
….x) (#25362) [Tabs]: Increase opacity, decrease size of separator, remove unused patch (#25353) * [Tabs]: Increase opacity, decrease size of separator, remove unused patch * Change color to 75% opacity after talking to @aguscruiz again * Better height override Co-authored-by: Jay Harris <jay.harris@outlook.co.nz>
….x) (#25363) [Tabs]: Increase opacity, decrease size of separator, remove unused patch (#25353) * [Tabs]: Increase opacity, decrease size of separator, remove unused patch * Change color to 75% opacity after talking to @aguscruiz again * Better height override Co-authored-by: Jay Harris <jay.harris@outlook.co.nz>
Resolves brave/brave-browser#40714
New separators:
Light:
Dark:
cc @rebron @aguscruiz
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: