Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs]: Increase opacity, decrease size of separator, remove unused patch #25353

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[Tabs]: Increase opacity, decrease size of separator, remove unused patch #25353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
360e4c5
[Tabs]: Increase opacity, decrease size of separator, remove unused p…
fallaciousreasoning Aug 27, 2024
2ec073e
Change color to 75% opacity after talking to @aguscruiz again
fallaciousreasoning Aug 27, 2024
5a0ed78
Better height override
fallaciousreasoning Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/ui/brave_layout_constants.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ std::optional<int> GetBraveLayoutConstant(LayoutConstant constant) {
case LOCATION_BAR_CHILD_CORNER_RADIUS:
return 4;
case TAB_SEPARATOR_HEIGHT: {
return 24;
return 16;
fallaciousreasoning marked this conversation as resolved.
Show resolved Hide resolved
}
case TOOLBAR_BUTTON_HEIGHT: {
return touch ? 48 : 28;
Expand Down
6 changes: 4 additions & 2 deletions browser/ui/color/brave_color_mixer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,6 +831,8 @@ void AddBravifiedTabStripColorMixer(ui::ColorProvider* provider,
mixer[kColorTabBackgroundActiveFrameInactive] = {
nala::kColorDesktopbrowserTabbarBackground};

mixer[kColorTabDividerFrameInactive] = {nala::kColorDividerStrong};
mixer[kColorTabDividerFrameActive] = {nala::kColorDividerStrong};
mixer[kColorTabDividerFrameActive] =
ui::AlphaBlend({nala::kColorDividerStrong},
{kColorTabBackgroundInactiveFrameActive}, 0.75 * 0xff);
mixer[kColorTabDividerFrameInactive] = {kColorTabDividerFrameActive};
}
16 changes: 2 additions & 14 deletions patches/chrome-browser-ui-views-tabs-tab_style_views.cc.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/chrome/browser/ui/views/tabs/tab_style_views.cc b/chrome/browser/ui/views/tabs/tab_style_views.cc
index 65676013fece9815be2046fcbf554ca857ce896c..8a541ff9f709822fcec5612dd2839f641ad72e53 100644
index 65676013fece9..3d3c8a6c02e7d 100644
--- a/chrome/browser/ui/views/tabs/tab_style_views.cc
+++ b/chrome/browser/ui/views/tabs/tab_style_views.cc
@@ -138,6 +138,7 @@ class TabStyleViewsImpl : public TabStyleViews {
Expand All @@ -18,19 +18,7 @@ index 65676013fece9815be2046fcbf554ca857ce896c..8a541ff9f709822fcec5612dd2839f64

SkPath path;

@@ -668,9 +670,10 @@ TabStyle::SeparatorBounds TabStyleViewsImpl::GetSeparatorBounds(
TabStyle::SeparatorBounds separator_bounds;

const int extra_vertical_space =
+ 2 * (
aligned_bounds.height() -
(separator_size.height() + separator_margin.bottom() +
- separator_margin.top());
+ separator_margin.top()));

separator_bounds.leading = gfx::RectF(
aligned_bounds.x() + corner_radius - separator_margin.right() -
@@ -1042,14 +1045,18 @@ void TabStyleViewsImpl::PaintSeparators(gfx::Canvas* canvas) const {
@@ -1042,14 +1044,18 @@ void TabStyleViewsImpl::PaintSeparators(gfx::Canvas* canvas) const {
SK_AlphaOPAQUE));
};

Expand Down
Loading