Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 132 to Chromium 133 (1.75.x) #27365

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Upgrade from Chromium 132 to Chromium 133 (1.75.x) #27365

merged 12 commits into from
Jan 30, 2025
+7,695 −5,974

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jan 28, 2025 •
edited
Loading

Resolves brave/brave-browser#43347
Resolves brave/brave-browser#42364
Resolves brave/brave-browser#43220
Resolves brave/brave-browser#43528
Resolves brave/brave-browser#43534
Resolves brave/brave-browser#43541
Resolves brave/brave-browser#43603
Resolves brave/brave-browser#43591

Uplift from #26537
Uplift from #27185
Uplift from #27372
Uplift from #27373
Uplift from #27378
Uplift from #27402
Uplift from #27394

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team as a code owner January 28, 2025 01:37
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet feature/web3/wallet/core labels Jan 28, 2025
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mkarolin mkarolin force-pushed the cr133-1.75.x branch 2 times, most recently from 4f289ba to 47aaac0 Compare January 28, 2025 21:05
mkarolin and others added 9 commits January 29, 2025 09:25
@mkarolin
Merge pull request #26537 from brave/cr133
4a0d45f 
Upgrade from Chromium 132 to Chromium 133.
@mkarolin
[cr133][1.75.x] base::make_span was removed.
f74b194 
All uses of `base::make_span` can be just `span{}`.

Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/6066402

commit b394ea77c33ed427269ad91712467c2da6e12e7e
Author: Peter Kasting <pkasting@chromium.org>
Date:   Tue Dec 3 23:04:42 2024 +0000

    Remove make_span.

    This is no longer used.

    Bug: 341907909
@mkarolin
[cr133][1.75.x] Avoid TabHandle refactor
34f70b2 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/936ba32422c40d955ab2e1f77a41eea870e1170c

commit 936ba32422c40d955ab2e1f77a41eea870e1170c
Author: Taylor Bergquist <tbergquist@chromium.org>
Date:   Wed Nov 13 19:10:18 2024 +0000

    Clean up TabHandle usage.

    TabHandle should only be used when there is a possibility the tab might
    be closed during the lifetime of the handle. This wasn't true of most
    uses; switch those over to TabInterface*. This will make it easier to
    move TabHandle over to TabInterface.

    This CL also includes some cleanup in TabStripModel, removing some
    TabHandle convenience methods and switching use of TabModel methods to
    the TabInterface equivalents. Some of it is a bit forward looking - the
    next CL will remove some of those TabModel only methods.

    The CL also includes a small cleanup in TabInterface::MaybeGetFromHandle
    so it resolves TabHandle IDs in the normal way (no behavior change).

    Bug: 376752361
@bridiver @mkarolin
also patch cxx crate from https://github.com/brave/brave-core/commit/… (
5658d9c 
#27185)

also patch cxx crate from a22fc31
Change presubmit patch empty line to error to allow upstream patches that do not comply with Brave patching standards
@mkarolin
Merge pull request #27359 from brave/maxk-disable-kOneTimePermission
4c2220c 
[cr133 follow up] Disables kOneTimePermission permissions feature.
@mkarolin
Merge pull request #27372 from brave/maxk-hide-settings-cookies-row
ec55196 
[cr133 follow up] Hide cookies row on Settings' privacy page.
@samartnik @mkarolin
[Android] Clean up modern_grey colors for 1.75.x
6449855 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/e99dac41a65779af4bfb8a15cde443478f51cc2f

[clank-q4-fixit] Clean up modern_grey colors pt 2

Bug: 40910276
@kylehickinson @mkarolin
Merge pull request #27373 from brave/ios-cr133-private-mode-crash
6be5c4c 
[iOS] Pass in correct browser when creating sync tabs
@kylehickinson @mkarolin
Merge pull request #27378 from brave/ios-cr133-profile-creation-fix
ea69d6a 
[iOS] Use original initial profile name for main profile creation
@mkarolin
Merge pull request #27371 from brave/maxk-cr133-upstream-memory-press…
cba3808 
…ure-fix

[cr133 upstream fix] Fix Prevent Hang in Memory Pressure Calculation …
@mkarolin
Merge pull request #27402 from brave/maxk-disable-history-embeddings
321d4d3 
[cr133 follow up] Disables history embeddings features.
@mkarolin
Merge pull request #27394 from brave/133.0.6943.39_master
deec2a1 
Upgrade from Chromium 133.0.6943.27 to Chromium 133.0.6943.39.
@kjozwiak kjozwiak added this to the 1.75.x - Release milestone Jan 30, 2025
kjozwiak
kjozwiak approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.75.x approved 👍

@kjozwiak kjozwiak merged commit 330f5fa into 1.75.x Jan 30, 2025
16 checks passed
@kjozwiak kjozwiak deleted the cr133-1.75.x branch January 30, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging this pull request may close these issues.
6 participants
@mkarolin @brave-builds @kjozwiak @bridiver @samartnik @kylehickinson