Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Pass in correct browser when creating sync tabs #27373

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[iOS] Pass in correct browser when creating sync tabs #27373

merged 1 commit into from
Jan 28, 2025

Conversation

kylehickinson
Copy link
Collaborator

This ensures we pass the correct Browser instance for the given mode since the profile is now passed into the BrowserWebStateListDelegate from the Browser provided

Resolves brave/brave-browser#43534

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson
[iOS] Pass in correct browser when creating sync tabs
f886f71 
This ensures we pass the correct Browser instance for the given mode since the profile is now passed into the BrowserWebStateListDelegate from the Browser provided

Chromium change:

commit b3988605f0dfe77bb107168522317407908e7d90
Author: Sylvain Defresne <sdefresne@chromium.org>
Date:   Mon Dec 2 13:13:59 2024 +0000

    [ios] Enforce Browser invariant in BrowserWebStateListDelegate

    The Browser implementation has an invariant that all inserted WebStates
    share the same ProfileIOS but it is not enforced. Change the delegate
    implementation to take the ProfileIOS as a parameter and to check that
    it is the same as those of all WebState that are inserted into it (via
    the WillAddWebState(...) delegate method).

    Fixed: 379806634
    Change-Id: I4e1023c48698deb14577341ded2a589dffab2726
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Jan 28, 2025
@kylehickinson kylehickinson self-assigned this Jan 28, 2025
@kylehickinson kylehickinson requested a review from a team as a code owner January 28, 2025 15:23
@kylehickinson kylehickinson merged commit 01b1eb7 into master Jan 28, 2025
19 checks passed
@kylehickinson kylehickinson deleted the ios-cr133-private-mode-crash branch January 28, 2025 19:59
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 28, 2025
mkarolin pushed a commit that referenced this pull request Jan 28, 2025
@kylehickinson @mkarolin
Merge pull request #27373 from brave/ios-cr133-private-mode-crash
47aaac0 
[iOS] Pass in correct browser when creating sync tabs
@mkarolin mkarolin mentioned this pull request Jan 28, 2025
Merged
24 tasks
@brave-builds
Copy link
Collaborator

Released in v1.76.44

mkarolin pushed a commit that referenced this pull request Jan 29, 2025
@kylehickinson @mkarolin
Merge pull request #27373 from brave/ios-cr133-private-mode-crash
6be5c4c 
[iOS] Pass in correct browser when creating sync tabs
kjozwiak pushed a commit that referenced this pull request Jan 30, 2025
@mkarolin @bridiver
@samartnik @kylehickinson
Upgrade from Chromium 132 to Chromium 133 (1.75.x) (#27365)
330f5fa 
* Merge pull request #26537 from brave/cr133

Upgrade from Chromium 132 to Chromium 133.

* [cr133][1.75.x] base::make_span was removed.

All uses of `base::make_span` can be just `span{}`.

Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/6066402

commit b394ea77c33ed427269ad91712467c2da6e12e7e
Author: Peter Kasting <pkasting@chromium.org>
Date:   Tue Dec 3 23:04:42 2024 +0000

    Remove make_span.

    This is no longer used.

    Bug: 341907909

* [cr133][1.75.x] Avoid TabHandle refactor

Chromium change:
https://chromium.googlesource.com/chromium/src/+/936ba32422c40d955ab2e1f77a41eea870e1170c

commit 936ba32422c40d955ab2e1f77a41eea870e1170c
Author: Taylor Bergquist <tbergquist@chromium.org>
Date:   Wed Nov 13 19:10:18 2024 +0000

    Clean up TabHandle usage.

    TabHandle should only be used when there is a possibility the tab might
    be closed during the lifetime of the handle. This wasn't true of most
    uses; switch those over to TabInterface*. This will make it easier to
    move TabHandle over to TabInterface.

    This CL also includes some cleanup in TabStripModel, removing some
    TabHandle convenience methods and switching use of TabModel methods to
    the TabInterface equivalents. Some of it is a bit forward looking - the
    next CL will remove some of those TabModel only methods.

    The CL also includes a small cleanup in TabInterface::MaybeGetFromHandle
    so it resolves TabHandle IDs in the normal way (no behavior change).

    Bug: 376752361

* also patch cxx crate from https://github.com/brave/brave-core/commit/… (#27185)

also patch cxx crate from a22fc31
Change presubmit patch empty line to error to allow upstream patches that do not comply with Brave patching standards

* Merge pull request #27359 from brave/maxk-disable-kOneTimePermission

[cr133 follow up] Disables kOneTimePermission permissions feature.

* Merge pull request #27372 from brave/maxk-hide-settings-cookies-row

[cr133 follow up] Hide cookies row on Settings' privacy page.

* [Android] Clean up modern_grey colors for 1.75.x

Chromium change:
https://chromium.googlesource.com/chromium/src/+/e99dac41a65779af4bfb8a15cde443478f51cc2f

[clank-q4-fixit] Clean up modern_grey colors pt 2

Bug: 40910276

* Merge pull request #27373 from brave/ios-cr133-private-mode-crash

[iOS] Pass in correct browser when creating sync tabs

* Merge pull request #27378 from brave/ios-cr133-profile-creation-fix

[iOS] Use original initial profile name for main profile creation

* Merge pull request #27371 from brave/maxk-cr133-upstream-memory-pressure-fix

[cr133 upstream fix] Fix Prevent Hang in Memory Pressure Calculation …

* Merge pull request #27402 from brave/maxk-disable-history-embeddings

[cr133 follow up] Disables history embeddings features.

* Merge pull request #27394 from brave/133.0.6943.39_master

Upgrade from Chromium 133.0.6943.27 to Chromium 133.0.6943.39.

---------

Co-authored-by: Brian Johnson <34129+bridiver@users.noreply.github.com>
Co-authored-by: Artem Samoilenko <artem@brave.com>
Co-authored-by: Kyle Hickinson <kylehickinson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHeaps StephenHeaps StephenHeaps approved these changes

Assignees

@kylehickinson kylehickinson

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.76.x - Beta
Development

Successfully merging this pull request may close these issues.

[cr133 follow-up] iOS crashes when creating a private tab
3 participants
@kylehickinson @brave-builds @StephenHeaps