Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict target list that can depend on brave/components/omnibox/browser #308

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Restrict target list that can depend on brave/components/omnibox/browser #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions components/omnibox/browser/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
source_set("browser") {
# Only //components/omnibox/browser target can depend on this target
# because this target expands //components/omnibox/browser implementation.
visibility = [ "//components/omnibox/browser" ]

sources = [
"brave_autocomplete_controller.cc",
"brave_autocomplete_controller.h",
Expand All @@ -7,8 +11,6 @@ source_set("browser") {
"topsites_provider.h",
]

# Don't make this target depends on chrome layer.
# This target is compiled together with //components/omnibox/browser static lib.
deps = [
"//skia",
"//third_party/metrics_proto",
Expand Down