Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade WebTorrent forks #3114

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Upgrade WebTorrent forks #3114

merged 1 commit into from
Aug 7, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Aug 7, 2019

Fix brave/brave-browser#5581
Fix brave/brave-browser#5489

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yrliou yrliou added this to the 0.70.x - Nightly milestone Aug 7, 2019
@yrliou yrliou requested a review from feross August 7, 2019 20:02
@yrliou yrliou self-assigned this Aug 7, 2019
@yrliou yrliou force-pushed the upgrade_webtorrent_forks branch from 565833a to 41d72e3 Compare August 7, 2019 20:07
Copy link
Contributor

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross
Copy link
Contributor

feross commented Aug 7, 2019

This fixes: brave/brave-browser#5489. I added it to the PR description.

@bsclifton
Copy link
Member

@yrliou once merged, can you help me uplift this back to 0.68.x? 😄

@yrliou yrliou merged commit a8ce90f into master Aug 7, 2019
@yrliou yrliou deleted the upgrade_webtorrent_forks branch August 7, 2019 22:44
yrliou added a commit that referenced this pull request Aug 9, 2019
yrliou added a commit that referenced this pull request Aug 9, 2019
Revert "Merge pull request #3114 from brave/upgrade_webtorrent_forks"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade WebTorrent forks WebTorrent: server serves files with "Content-Type: null"
3 participants