Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift "Upgrade WebTorrent forks" to 0.68.x #3119

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Uplift "Upgrade WebTorrent forks" to 0.68.x #3119

merged 1 commit into from
Aug 8, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Aug 8, 2019 •
edited
Loading

Issue: brave/brave-browser#5581
Original PR: #3114

Issues that would be fixed because of updating WebTorrent to its latest version:
brave/brave-browser#5460
brave/brave-browser#5489
brave/brave-browser#5358 (This is actually not introduced in 0.69.x and 0.68.x yet since these two are using an older version of WebTorrent (less than v0.105.1) before this uplift PR.)

@yrliou yrliou added this to the 0.68.x - Beta milestone Aug 8, 2019
@yrliou yrliou requested a review from a team August 8, 2019 00:00
@yrliou yrliou self-assigned this Aug 8, 2019
@yrliou
Copy link
Member Author

yrliou commented Aug 8, 2019 •
edited
Loading

CI failed only at Publish xUnit test result report

kjozwiak
kjozwiak approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.68.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are added and the associated issue(s) are moved into the correct milestone.

@yrliou yrliou merged commit 87acfe5 into 0.68.x Aug 8, 2019
@yrliou yrliou deleted the upgrade_webtorrent_forks_0.68.x branch August 8, 2019 15:55
yrliou added a commit that referenced this pull request Aug 9, 2019
@yrliou
Revert "Merge pull request #3119 from brave/upgrade_webtorrent_forks_…
f7c5ffa 
…0.68.x"

This reverts commit 87acfe5, reversing
changes made to 0628e4e.
yrliou added a commit that referenced this pull request Aug 9, 2019
@yrliou
Merge pull request #3137 from brave/rollback_webtorrent_forks_upgrade…
b06f642 
…_0.68.x

Revert "Merge pull request #3119 from brave/upgrade_webtorrent_forks_…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@yrliou @kjozwiak