Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get more extensions link to brave://settings #3166

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 14, 2019

Fixes brave/brave-browser#5540

Submitter Checklist:

Test Plan:

  1. Visit chrome://settings/extensions
  2. Verify new Get more extensions item shows up. Looks like this:

Screen Shot 2019-08-13 at 11 36 03 PM

1. Click link and verify it goes to the Chrome Web Store

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 0.71.x - Nightly milestone Aug 14, 2019
@bsclifton bsclifton self-assigned this Aug 14, 2019
@bsclifton
Copy link
Member Author

Ready for review! 😄

@petemill
Copy link
Member

Did we make all new strings because we didn't want to re-use the existing ones from the extensions page @bsclifton ? Shouldn't we prefix the new strings resource IDs with BRAVE_?

@bsclifton bsclifton changed the title Add Get more extension link to brave://settings Add Get more extensions link to brave://settings Aug 20, 2019
emerick
emerick previously approved these changes Aug 20, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton
Copy link
Member Author

@petemill good call - I didn't see those... I can re-use one of the two strings. Will update + put BRAVE prefix

@bsclifton
Copy link
Member Author

@petemill @emerick updated! 😄

@bsclifton
Copy link
Member Author

All checks passed! WOW

@bsclifton bsclifton merged commit 3dcbf8f into master Aug 20, 2019
@bsclifton bsclifton deleted the bsc-web-store-link branch August 20, 2019 21:48
brave-builds pushed a commit that referenced this pull request Aug 20, 2019
bsclifton added a commit that referenced this pull request Aug 20, 2019
Add `Get more extensions` link to brave://settings
@kjozwiak
Copy link
Member

Quickly went through a quick check using the test case outlined under #3166 (comment) before bringing up #3229 and #3231 to @brave/uplift-approvers. Verified using 0.71.24 CR: 76.0.3809.100. Example:

Screen Shot 2019-08-21 at 5 42 21 PM

Screen Shot 2019-08-21 at 5 40 06 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to 'Get more extensions' in Settings
5 participants