-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Get more extensions
link to brave://settings
#3166
Conversation
browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.js
Outdated
Show resolved
Hide resolved
03f4786
to
e4db2bc
Compare
Ready for review! 😄 |
Did we make all new strings because we didn't want to re-use the existing ones from the extensions page @bsclifton ? Shouldn't we prefix the new strings resource IDs with |
Get more extension
link to brave://settingsGet more extensions
link to brave://settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@petemill good call - I didn't see those... I can re-use one of the two strings. Will update + put BRAVE prefix |
All checks passed! WOW |
Add `Get more extensions` link to brave://settings
Quickly went through a quick check using the test case outlined under #3166 (comment) before bringing up #3229 and #3231 to @brave/uplift-approvers. Verified using
|
Fixes brave/brave-browser#5540
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Get more extensions
item shows up. Looks like this:1. Click link and verify it goes to the Chrome Web Store
Reviewer Checklist:
After-merge Checklist:
changes has landed on.