Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get more extensions link to brave://settings (uplift to 0.69.x) #3231

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 20, 2019

Uplift of #3166
Fixes brave/brave-browser#5540

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Add `Get more extensions` link to brave://settings
@bsclifton bsclifton added this to the 0.69.x - Beta milestone Aug 20, 2019
@bsclifton bsclifton requested a review from a team August 20, 2019 22:57
@bsclifton bsclifton self-assigned this Aug 20, 2019
@bsclifton bsclifton changed the title Merge pull request #3166 from brave/bsc-web-store-link Add Get more extensions link to brave://settings (uplift to 0.69.x) Aug 20, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins and CI/Travis passed without any errors/failures. I also went through #3166 (comment) and ensured it was working as expected using 0.71.24 CR: 76.0.3809.100.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit b483063 into 0.69.x Aug 22, 2019
@bsclifton bsclifton deleted the pr3166_bsc-web-store-link_0.69.x branch August 22, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants