Chromium change:

https://chromium.googlesource.com/chromium/src/+/5e32b68410004c00a852edddad7f7c5183defbd1

commit 5e32b68410004c00a852edddad7f7c5183defbd1
Author: Thomas Tangl <tangltom@chromium.org>
Date:   Tue Aug 13 11:03:30 2019 +0000

    Rename ProfileChooserView to ProfileMenuView

    Bug: 966388

ButtonPressed override in ProfileMenuViewBase has been marked `final`,
we don't need to override it any more. Also, Reset was moved to the
base, we don't need to override it either.

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/7cbff633bb1691549909f3bc85a627a465de7a82

commit 7cbff633bb1691549909f3bc85a627a465de7a82
Author: Thomas Tangl <tangltom@chromium.org>
Date:   Wed Aug 14 17:44:17 2019 +0000

    [profile-menu] Move button handling to ProfileMenuViewBase

    - The logic of the button actions remains in ProfileMenuView.
    - The button handling is done in ProfileMenuViewBase.

    Bug: 966388

https://chromium.googlesource.com/chromium/src/+/5d41b7ef83207bf7c01eb53c5378760a7bbc7042

commit 5d41b7ef83207bf7c01eb53c5378760a7bbc7042
Author: Thomas Tangl <tangltom@chromium.org>
Date:   Wed Aug 21 09:50:44 2019 +0000

    [profile-menu] Move bubble creation to ProfileMenuViewBase

    Bug: 966388

Chromium change:

https://chromium.googlesource.com/chromium/src/+/fd4db3db83c7564f55679d9700a6f2e6641e3b13

commit fd4db3db83c7564f55679d9700a6f2e6641e3b13
Author: Clark DuVall <cduvall@chromium.org>
Date:   Tue Jul 30 19:10:43 2019 +0000

    Remove all references to UIThreadExtensionFunction

    UIThreadExtensionFunction was merged into ExtensionFunction in
    http://crrev.com/c/1718990. This removes the stub
    UIThreadExtensionFunction class and renames all the references from
    UIThreadExtensionFunction to ExtensionFunction.

    This CL was generated with the command:
      git grep --name-only UIThreadExtensionFunction | \
        xargs sed -i 's/UIThreadExtensionFunction/ExtensionFunction/g'

    Bug: 980774

Chromium change:

https://chromium.googlesource.com/chromium/src/+/eadf58863bcf6a3365841ef88c6ed686c2ba3485

commit eadf58863bcf6a3365841ef88c6ed686c2ba3485
Author: Gabriel Charette <gab@chromium.org>
Date:   Thu Aug 29 05:20:27 2019 +0000

    [ThreadPool] Move thread_pool.h to thread_pool_instance.h

    The only class defined in this header is ThreadPoolInstance and this
    is thus more correct.

To avoid compilation error:

In file included from ../../brave/components/omnibox/browser/topsites_provider.cc:6:
In file included from ../..\brave/components/omnibox/browser/topsites_provider.h:13:
In file included from ../..\components/omnibox/browser/autocomplete_match.h:23:
In file included from ../..\components/url_formatter/url_formatter.h:28:
In file included from ../..\components/url_formatter/spoof_checks/idn_spoof_checker.h:17:
../..\third_party/icu/source/common/unicode/uniset.h(16,10): fatal error: 'unicode/ucpmap.h' file not found
\#include "unicode/ucpmap.h"
         ^~~~~~~~~~~~~~~~~~

Chromium change:

https://chromium.googlesource.com/chromium/src/+/92bf36029638ae236920177e722650bed2a40e84

commit 92bf36029638ae236920177e722650bed2a40e84
Author: John Abd-El-Malek <jam@chromium.org>
Date:   Wed Jul 31 02:25:48 2019 +0000

    Move ResourceRequestInfo::WebContentsGetter to WebContents::Getter.

    This is in preparation of removing ResourceRequestInfo which isn't needed anymore.

    Bug: 934009

Note, that ResourceRequestInfo::WebContentsGetter has been moved to
WebContents::Getter in a separate commit.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/346c99158a1ea8b52d4837dac679693289e5a308

commit 346c99158a1ea8b52d4837dac679693289e5a308
Author: John Abd-El-Malek <jam@chromium.org>
Date:   Wed Jul 31 20:48:58 2019 +0000

    Remove ResourceRequestInfo.

    Bug: 934009

Chromium change:

https://chromium.googlesource.com/chromium/src/+/1d53a36128a1be255c8009995b6ef47f59eceec2

commit 1d53a36128a1be255c8009995b6ef47f59eceec2
Author: Gabriel Charette <gab@chromium.org>
Date:   Mon Aug 26 13:16:01 2019 +0000

    Reland "Reland "Reland "Reland [base] Require task posters to specify an explicit destination"""

    This is a reland of 0567f059231c64f5f20316896b6ad79dfb6fddca

----

This change causes static assertions during build if the thread
destination is not explicitly specified. Also see earlier change:

https://chromium.googlesource.com/chromium/src/+/44ba2ec36163930bed47227af5bddeea5785c9af

commit 44ba2ec36163930bed47227af5bddeea5785c9af
Author: Sami Kyostila <skyostil@chromium.org>
Date:   Thu Jun 20 17:01:44 2019 +0000

    base: Always specify thread affinity when posting tasks

    *** Note: there is no behavior change from this patch. ***

    The PostTask APIs will shortly be changed to require all tasks to explicitly
    specify their thread affinity, i.e., whether the task should run on the thread
    pool or a specific named thread such as a BrowserThread. This patch updates all
    call sites with thread affinity annotation. We also remove the "WithTraits"
    suffix to keep the call sites readable.

    Before:

        // Thread pool task.
        base::PostTaskWithTraits(FROM_HERE, {...}, ...);

        // UI thread task.
        base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

    After:

        // Thread pool task.
        base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

        // UI thread task.
        base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

    This patch was semi-automatically prepared with these steps:

        1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
           to make thread affinity a build-time requirement.
        2. Run an initial pass with a clang rewriter:
           https://chromium-review.googlesource.com/c/chromium/src/+/1635623
        2. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
               uniq > errors.txt
        3. while read line; do
             f=$(echo $line | cut -d: -f 1)
             r=$(echo $line | cut -d: -f 2)
             c=$(echo $line | cut -d: -f 3)
             sed -i "${r}s/./&base::ThreadPool(),/$c" $f
           done < errors.txt
        4. GOTO 2 until build succeeds.
        5. Remove the "WithTraits" suffix from task API call sites:

           $ tools/git/mffr.py -i <(cat <<EOF
           [
             ["PostTaskWithTraits",                            "PostTask"],
             ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
             ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
             ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
             ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
             ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
             ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
             ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
           ]
           EOF
           )

    Bug: 968047

Chromium change:

https://chromium.googlesource.com/chromium/src/+/3d80498323e08ace69936c542b6ed907fc7f523c

commit 3d80498323e08ace69936c542b6ed907fc7f523c
Author: Yutaka Hirano <yhirano@chromium.org>
Date:   Mon Jul 29 06:41:34 2019 +0000

    Reland "Unify allow_credentials and credentials_mode on network::ResourceRequest"

    This is a reland of 1ccc5eeed0f535fe0c181f1ad3e6f0a05ed7f186

    Original change's description:
    > Unify allow_credentials and credentials_mode on network::ResourceRequest
    >
    > Remove allow_credentials, map allow_credentials: false to
    > credentials_mode: kOmit and map allow_credentials: true to
    > credentials_mode: kInclude.
    >
    > network::URLLoader cannot handle kSameOrigin. This CL doesn't change
    > that. CORSURLLoader translates the value to either kOmit or kInclude.
    >
    > This works correctly even when OOR-CORS is disabled because in that
    > case load flags are set in the renderer. One caveat is we will not
    > be able to remove the load flags until we remove the blink-side CORS
    > code (M78? M79?) with this change.
    >
    > This CL removes a validity check for credentials related settings in
    > CorsURLLoaderFactory. Originally the check was introduced to check the
    > inconsistency between credentials_mode and load flags. After that
    > allow_credentials was introduced, and at
    > https://crrev.com/c/chromium/src/+/1443976 the logic was changed to
    > check the inconsistency between credentials_mode and allow_credentials.
    > Now they are merged and we don't need the check.
    >
    > Bug: 799935

Chromium change:

https://chromium.googlesource.com/chromium/src/+/2687ab53d96be061473d170ee88060b59067cd66

commit 2687ab53d96be061473d170ee88060b59067cd66
Author: Joel Hockey <joelhockey@chromium.org>
Date:   Wed Aug 14 23:59:46 2019 +0000

    Refactor Browser::Type

    Change from {TABBED, POPUP}, to {NORMAL, POPUP, APP, DEVTOOLS}

    Browser::is_type_tabbed() => Browser::is_type_normal()
    Browser::is_type_popup() (used to include POPUP, APP, DEVTOOLS)
    split into:
     * Browser::is_type_popup()
     * Browser::is_type_app()
     * Browser::is_type_devtools()

    Browser::is_app() => Browser::deprecated_is_app() (APP or DEVTOOLS)
    and also split into:
     * Browser::is_type_app()
     * Browser::is_type_devtools()

    This is quite a large change, but there is hopefully no or very
    little change to any logic.  To help reviewers, I have uploaded
    10 different patchsets which each perform a small refactoring change
    that make up this CL.

    Patchset 12: s/TYPE_TABBED/TYPE_NORMAL/
    Patchset 13: s/kMatchTabbed/kMatchNormal/
    Patchset 14: s/is_type_tabbed/is_type_normal/
    Patchset 15: s/is_devtools/is_type_devtools/
    Patchset 16: s/is_app/deprecated_is_app/
    Patchset 17: s/is_type_popup/!is_type_normal/
    Patchset 18: Add TYPE_APP and TYPE_DEVTOOLS (main change)
    Patchset 19: SyncedWindowDelegate
    Patchset 20: little fixes, git cl format
    Patchset 21: Fix types in tests

    Patchset 18 is the only one that has any change to non-test
    code which is not a pure refactor.

    Bug: 990158

Patched to add BraveProfileManager as a friend and make the method
virtual again.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/b54a5d84c888637178e6b633c669d4dadb9c70f5

commit b54a5d84c888637178e6b633c669d4dadb9c70f5
Author: Evan Stade <estade@chromium.org>
Date:   Fri Aug 30 21:35:03 2019 +0000

    Remove NOTIFICATION_SESSION_STARTED from AccessibilityManager

    Previously, this code used NOTIFICATION_SESSION_STARTED for initial
    login, and then UserManager::SessionStateObserver::ActiveUserChanged
    for swapping between users. It should be possible just to always
    rely on ActiveUserChanged. If the profile isn't loaded yet (as with
    initial login), add a profile created observer.

    This should mean SetProfile gets called slightly earlier as
    SESSION_STARTED comes rather late. This seems like an improvement
    because SetProfile will not be delayed until after the post-login
    steps (e.g. when the profile picture is being chosen).

    ChromeUserManager is changed slightly, listening to
    NOTIFICATION_PROFILE_ADDED rather than NOTIFICATION_PROFILE_CREATED.
    For async profile creation, NOTIFICATION_PROFILE_ADDED comes after
    NOTIFICATION_PROFILE_CREATED, but for synchronous profile creation
    (e.g. the startup profile), it's inverted; in both cases the two
    notifications are sent synchronously, i.e. as part of the same
    task. To make sure the profile is both initialized and
    registered with ProfileManager by the time ProfileCreatedObservers
    get notified, ChromeUserManager should make use of
    NOTIFICATION_PROFILE_ADDED.

    Bug: 268984

No longer needs `thread` param.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/16395195c71cc831e85e10524f2c18311b325df5

commit 16395195c71cc831e85e10524f2c18311b325df5
Author: Clark DuVall <cduvall@chromium.org>
Date:   Tue Jul 30 18:04:24 2019 +0000

    Remove unused IOThreadExtensionFunction

    This also merges UIThreadExtensionFunction and ExtensionFunction since
    there's no need for them to be separate anymore. This was made possible
    because WebRequest has moved to the UI thread, and it was the only API
    using IOThreadExtensionFunction.

    Follow up CL will remove references to UIThreadExtensionFunction.

    Bug: 980774

Replaced the call with a new function AutocompleteMatch::AllowedToBeDefault.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/91b19173a930d04bf9612b7eba2122c9c33701fe

commit 91b19173a930d04bf9612b7eba2122c9c33701fe
Author: manuk <manukh@chromium.org>
Date:   Fri Aug 9 16:44:46 2019 +0000

    [omnibox]: Allow autocompleting URLs for inputs with trailing whitespace.

    Previously, URLs were forbidden from autocompleting for inputs such as
    'google.com/?q=x '. This would cause the suggestion 'google.com/?q=x y'
    dropping when the user typed the space, and reappearing when the user typed
    the 'y'.

    With this CL, inputs with trailing whitespaces allow URL suggestions to
    autocomplete only when the match fill_into_edit text also contains the
    whitespace or if the inline autocomplete text is empty.

    - Input "x" will allow default matches "x", "xy", and "x y".
    - Input "x " will allow default matches "x" and "x y".
    - Input "x  " will allow default match "x".
    - Input "x y" will allow default match "x y".
    - Input "x" with prevent_inline_autocomplete will allow default match "x".

    This differs from current behavior only in the 2nd example, where current
    behavior would prohibit input "x " from inline autocompleting match "x y".

    Bug: 26902

Chromium change:

https://chromium.googlesource.com/chromium/src/+/61df041e1167a60f73b5968fcb2816a88b1ba2f9

commit 61df041e1167a60f73b5968fcb2816a88b1ba2f9
Author: Ken Rockot <rockot@google.com>
Date:   Fri Jul 26 17:12:19 2019 +0000

    Move Unzip service off Service Manager

    Gets rid of all Service Manager dependencies from the Unzip service and
    its client library. Also introduces a Content library under
    components/services/unzip/content/ for Content embedders to launch new
    Unzip service processes as needed.

    Bug: 977637

Chromium change:

https://chromium.googlesource.com/chromium/src/+/61df041e1167a60f73b5968fcb2816a88b1ba2f9

commit 61df041e1167a60f73b5968fcb2816a88b1ba2f9
Author: Ken Rockot <rockot@google.com>
Date:   Fri Jul 26 17:12:19 2019 +0000

    Move Unzip service off Service Manager

    Gets rid of all Service Manager dependencies from the Unzip service and
    its client library. Also introduces a Content library under
    components/services/unzip/content/ for Content embedders to launch new
    Unzip service processes as needed.

    Bug: 977637

Chromium change:

https://chromium.googlesource.com/chromium/src/+/d6ac38de3efaffd786410d84d75edea546599946

commit d6ac38de3efaffd786410d84d75edea546599946
Author: Ken Rockot <rockot@google.com>
Date:   Tue Jul 30 21:08:58 2019 +0000

    Move FilePatcher service off Service Manager

    Removes all dependences from patch service onto Service Manager in favor
    of the simplified service model and direct mojom interface acquisition.

    This CL mirrors what was done for the Unzipper service, providing a
    Content library in components/services/patch for launching a sandboxed
    process, and an in-process helper for tests and iOS.

    Bug: 977637

BrowserContextDestroyed became non-virtual. Patched to make it virtual
again.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/a362f6a9cc2c8080b858df13eecf5cc7e95a808d

commit a362f6a9cc2c8080b858df13eecf5cc7e95a808d
Author: Chris Davis <chrdavis@microsoft.com>
Date:   Tue Aug 13 21:40:14 2019 +0000

    Remove unused virtuals to save disk space

    These changes reduce chrome.exe by 11k, chrome.dll by 80k and
    chrome_child.dll by 51k. Total of 143k in disk savings.

    Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=985505

As part of the conversion params referrer was converted from
content::Referrer to network::mojom::Referrer. Updated our
MaybeHideReferrer method to take mojom param.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/ef8290afc569e8ad87bb8b921f97827018f30031

commit ef8290afc569e8ad87bb8b921f97827018f30031
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date:   Mon Jul 29 20:27:51 2019 +0000

    Convert content::CommonNavigationParams to mojom.

    Bug: 984550

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/4a834b3fbcf509a2f1bb1211b57bb338256768cf

commit 4a834b3fbcf509a2f1bb1211b57bb338256768cf
Author: Karan Bhatia <karandeepb@chromium.org>
Date:   Fri Aug 16 22:26:44 2019 +0000

    Reland "ContentBrowserClient: Introduce enum to denote the type of URLLoaderFactory."

    This is a reland of b00902f1cd54e58660ed1482d8cf98aba4d825d6. This conflicted with
    b032c63 which has since been reverted (ecbd9b5).

    Original change's description:
    > ContentBrowserClient: Introduce enum to denote the type of URLLoaderFactory.
    >
    > Introduce a URLLoaderFactory enum and use it in
    > ContentBrowserClient::WillProxyURLLoaderFactory. This should help with code
    > readability and make the interface more explicit for content embedders.
    >
    > BUG=993485
    >
    > Change-Id: I20a5651a210ca1fa8b3fed99a48b1b3001b6eb83
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754716
    > Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#687506}

    Bug: 993485

https://chromium.googlesource.com/chromium/src/+/47499a0c48e454e8637c6ab7ab97b08f012f0d4a

commit 47499a0c48e454e8637c6ab7ab97b08f012f0d4a
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date:   Wed Aug 28 07:23:18 2019 +0000

    Convert TrustedURLLoaderHeaderClient to new Mojo types

    This CL converts TrustedURLLoaderHeaderClientRequest,
    TrustedURLLoaderHeaderClientPtrInfo and
    TrustedURLLoaderHeaderClientPtr to new Mojo types.

    Bug: 955171, 978694

Chromium change:

https://chromium.googlesource.com/chromium/src/+/4a062c36d58a1effd44855c7d1f2367711fbf964

commit 4a062c36d58a1effd44855c7d1f2367711fbf964
Author: John Abd-El-Malek <jam@chromium.org>
Date:   Tue Jul 30 19:46:41 2019 +0000

    Remove now unused kURLLoadOptionPauseOnResponseStarted.

    Bug: 934009, 791049

Chromium change:

https://chromium.googlesource.com/chromium/src/+/81e294be8a67411b7c00802063efeae13531edd8

commit 81e294be8a67411b7c00802063efeae13531edd8
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date:   Thu Aug 29 16:26:32 2019 +0000

    Remove the typemap from network::mojom::URLResponseHead.

    This CL also adds a conversion to and from the mojom type to
    network::ResourceResponseHead. This will allow the conversion of the
    struct to the mojom type to be split into smaller CLs.

    Bug: 984550

Chromium change:

https://chromium.googlesource.com/chromium/src/+/9797cc66ad6e9987f00272120835b840d7c132b5

commit 9797cc66ad6e9987f00272120835b840d7c132b5
Author: Hector Carmona <hcarmona@chromium.org>
Date:   Fri Aug 9 20:35:35 2019 +0000

    [Reland] Navi: Remove usage of 'Onboarding' most places in welcome code.

    Bug: 986979

Chromium change:

https://chromium.googlesource.com/chromium/src/+/8da4c333d6baae2739b7220bce9e0a5ee2c87873

commit 8da4c333d6baae2739b7220bce9e0a5ee2c87873
Author: Allen Bauer <kylixrd@chromium.org>
Date:   Tue Sep 3 20:15:58 2019 +0000

    Merge MaterialRefreshLayoutProvider into ChromeLayoutProvider.

    Bug: 940771

set_dark_mode was renamed to set_use_dark_colors as well.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/1edd4d0e8d2bb63d19058fe47c326f121bc33a62

commit 1edd4d0e8d2bb63d19058fe47c326f121bc33a62
Author: minch <minch@google.com>
Date:   Mon Aug 5 19:10:56 2019 +0000

    Rename NativeTheme::SystemDarkModeEnabled to ShouldUseDarkColors.

    Bug: 977430

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/0b653a39fe832ec8366948cc343f2b5a97ab57fa

commit 0b653a39fe832ec8366948cc343f2b5a97ab57fa
Author: Marc Treib <treib@chromium.org>
Date:   Tue Sep 3 11:00:37 2019 +0000

    Clear the account-scoped PasswordStore on signout

    This adds an "is_account_store" flag to LoginDatabase, which specifies
    whether this DB stores profile-scoped or Gaia-account-scoped data.
    Sync uses this flag to clear the account-scoped data on signout.
    In the future, the flag will also be used by the DB itself to "tag"
    credentials it returns as coming from the account or from the profile.

    Bug: 998455

https://chromium.googlesource.com/chromium/src/+/00380bfbde67971670a4e4afcaa513622905d8a5

commit 00380bfbde67971670a4e4afcaa513622905d8a5
Author: Marc Treib <treib@chromium.org>
Date:   Wed Sep 4 08:04:37 2019 +0000

    LoginDatabase: Use a strong alias for is_account_store param

    With this change, callers have to write
    new LoginDatabase(path, IsAccountStore(true))
    instead of
    new LoginDatabase(path, /*is_account_store=*/true)
    which is clearer (no way to forget the comment), especially if any
    other (boolean) parameters are added at any later point.

    Bug: 998455

Chromium change:

https://chromium.googlesource.com/chromium/src/+/32bb26026fb3fd768dda878f9193a5080593d5ec

commit 32bb26026fb3fd768dda878f9193a5080593d5ec
Author: Peter Kasting <pkasting@chromium.org>
Date:   Thu Aug 22 19:01:43 2019 +0000

    Update tab and frame context menus to match most recent UX specs.

    This removes four entries from the tab context menu; changes the text on several
    others to stop saying "tab(s)" explicitly; adds one entry to the frame context
    menu; and changes the bookmark-related menu entry strings from "page" to "tab"
    for consistency.

    Most of the file changes here are due to renaming enums/APIs to match the string
    changes.

    Bug: 515930

We used it as a param to URLPattern::Parse. Checked with Mark Pilgrim
and we don't need it any more.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/35f8e3712967bb475b8afbac870168c302713ab0

commit 35f8e3712967bb475b8afbac870168c302713ab0
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date:   Fri Aug 16 19:15:38 2019 +0000

    [Extensions] Remove wildcard TLD support from URLPatterns

    This was originally added for policy support, but has since been
    removed. The only usage now is in tests. Remove the support from
    URLPattern to reduce complexity and clean up dead code.

    Bug: None

Chromium change:

https://chromium.googlesource.com/chromium/src/+/e9f4007f07b25ac1c2c942f96ba834862f40f149

commit e9f4007f07b25ac1c2c942f96ba834862f40f149
Author: Dan Beam <dbeam@chromium.org>
Date:   Sat Aug 17 00:59:10 2019 +0000

    WebUI: convert SetJsonPath("strings.js") to UseStringsJs()

    rbpotter@ noticed that the only value SetJsonPath() is ever called with
    is "strings.js" (or a constant with that content). So just changed to
    UseStringsJs() instead and look for that constant in WebUIDataSource.

    Also, add loadTimeData import to strings file when using JS modules.

    The autogenerated strings file references loadTimeData.data without
    actually importing loadTimeData from load_time_data.m.js, because it
    does not expect to be imported as a module. Autogenerate the import if
    "strings.m.js" is requested so that UIs using JS modules can import the
    strings without needing to add a preceding load_time_data import.

    Based on https://crrev.com/c/1756607 by Rebekah Potter <rbpotter@chromium.org>

    BUG=965770

Chromium change:

https://chromium.googlesource.com/chromium/src/+/a077cdd7a4598db77fa54ddde207bb3a605233a9

commit a077cdd7a4598db77fa54ddde207bb3a605233a9
Author: Robert Liao <robliao@chromium.org>
Date:   Wed Aug 28 06:34:37 2019 +0000

    Promote ChromeTextStyle::STYLE_SECONDARY to views::styles::STYLE_SECONDARY

    This is a refactor change and is preparation for menu text to use
    STYLE_SECONDARY for minor labels (labels appearing alongside the main
    label in a menu like for keyboard shortcuts).

    This also fixes a definition in chrome/browser/ui/views/chrome_typography.h
    to correctly align CHROME_TEXT_STYLE_START with the beginning of the enum.

    BUG=865318

Chromium change:

https://chromium.googlesource.com/chromium/src/+/caf6c3ff2daa65b9a46597ce1fbce4ae5233b78b

commit caf6c3ff2daa65b9a46597ce1fbce4ae5233b78b
Author: Kelvin Jiang <kelvinjiang@chromium.org>
Date:   Tue Aug 13 21:49:50 2019 +0000

    [DNR] Implement storing/setting actions matched badge text

    This CL implements the logic to store the number of actions matched for
    an extension's ruleset and surface this count as a extension's badge
    text if the extension has called setActionCountAsBadgeText(true).

    Bug: 973211

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/d29f92a871f173276c4cfdfd0d05823986ea699a

commit d29f92a871f173276c4cfdfd0d05823986ea699a
Author: Charlene Yan <cyan@chromium.org>
Date:   Fri Apr 19 20:45:02 2019 +0000

    Changing MenuRunner::RunMenuAt to take in a MenuButtonController.

    This is needed so Buttons can be not a subclass of MenuButton but still
    install a MenuButtonController for the same behavior.

    Bug: 901183, 819854

https://chromium.googlesource.com/chromium/src/+/858114e992439c4897df9ecc7f910a8cb1840c65

commit 858114e992439c4897df9ecc7f910a8cb1840c65
Author: Charlene Yan <cyan@chromium.org>
Date:   Wed Aug 21 17:32:55 2019 +0000

    Add ExtensionsContextMenuController to avoid duplicating code.

    BUG: 985382

Shifted our addition beyond the new values.

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/a5972f337566c91d4b84ce0b02d094180d4262e4

commit a5972f337566c91d4b84ce0b02d094180d4262e4
Author: Andy Paicu <andypaicu@chromium.org>
Date:   Thu Aug 22 20:23:18 2019 +0000

    Add a quiet notification permission request for android

    This CL does the following:
    Adds the ability to display a permission request via a notification
    on android.
    Uses this ability to show notification permission requests (gated by
    feature flag).

    This will enable experimenting with this particular UI, and represents
    the reparo "Mobile Experimental Candidate 3": go/reparo-candidates

https://chromium.googlesource.com/chromium/src/+/5292deda734f728dec58c89eb755f71856dad524

commit 5292deda734f728dec58c89eb755f71856dad524
Author: Rayan Kanso <rayankans@chromium.org>
Date:   Wed Sep 4 11:37:17 2019 +0000

    [Sharing] Add a clipboard message handler for desktop.

    - Create an abstract message handler and move the Android specific
    implementation to its own file.
    - Use the NotificationDisplayService for the Desktop implementation.

    In the Desktop Handler:
    - Show a notification that the text has been shared.
    - Any click on the notification will dismiss it (or it will dismiss
    itself after a few seconds)
    - It uses a newly introduced `devices` material UI icon.

    Bug: 996325

Chromium change:

https://chromium.googlesource.com/chromium/src/+/21dd8c10f2d1f5b474eb83daf9b9d293775946a6

commit 21dd8c10f2d1f5b474eb83daf9b9d293775946a6
Author: Kristyn Hamasaki <khamasaki@google.com>
Date:   Fri Jul 26 19:40:07 2019 +0000

    Refactor Textfield::GetText and Textfield::GetReadOnly

    Change from text() to GetText() and read_only() to ReadOnly() in order
    to convert to properties.

    Bug: 979037

Chromium change:

https://chromium.googlesource.com/chromium/src/+/675389344b6e7b0af2c17b2dd8c865eb92c66bb1

commit 675389344b6e7b0af2c17b2dd8c865eb92c66bb1
Author: Jan Krcal <jkrcal@chromium.org>
Date:   Wed Jul 31 10:43:41 2019 +0000

    [Identity pill] Show the pill on sign-in / startup (no animation)

    This CL adds the first version of identity pill -- only the triggering
    logic to show and to hide the pill. No animation nor UI changes are
    included in this CL.

    Bug: 967317

https://chromium.googlesource.com/chromium/src/+/013c4006553be15c2feacc3ee98d7431561ae1bb

commit 013c4006553be15c2feacc3ee98d7431561ae1bb
Author: Rohan Pavone <rohpavone@chromium.org>
Date:   Wed Aug 21 20:13:52 2019 +0000

    [Permissions] Checks if permissions should be overridden.

    Determines if platform supports overridden status of permission by
    querying PermissionControllerDelegate. Since most delegates have static
    permission statuses, this queries the permission status by default.
    Overridden classes, such as PermissionManager (used for Chrome) and
    WebTestPermissionManager, have dynamic permission settings which are
    queried in a different fashion. If permission is not supported, this
    is indicated. PermissionControllerImpl, which controls overrides,
    uses this decision to choose whether or not to override, which is
    then forwarded to the callee. Browser.setPermission uses this to
    indicate if setting permission failed/succeeded. Browser.grantPermission
    ignores the result.

    Design doc: go/chromedriver-permissions-ext

    Bug: 976308

Cleaned up our override and test.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/b851acc052ee6a505d4f60fb9cc326c410b1285b

commit 2e9897792488b3940ebb18b0071cfced7e90e3b1
Author: David Benjamin <davidben@chromium.org>
Date:   Thu Aug 1 16:36:04 2019 +0000

    Remove GoogleURLTracker

    The class is now a no-op as of
    https://chromium-review.googlesource.com/c/chromium/src/+/1686726.
    It never fires its observer calls and always returns https://www.google.com/.
    Move that constant to google_util and unwind the rest.

    This ends up touching a lot of files. The two interesting parts:

    - Check that GoogleURLTracker is always created with ALWAYS_DOT_COM_MODE,
      and that, in ALWAYS_DOT_COM_MODE, it degenerates into return
      kDefaultGoogleHomepage. (Apart from test code which manually triggers
      bits of it.) That means we can replace all uses of
      GoogleURLTracker::google_url with the newly-added
      google_util::kGoogleHomepageURL and remove everything that registers
      callbacks.

    - Check that nothing else uses the prefs in google_pref_names.h, and
      thus they can be removed. Check that I've correctly replaced them with
      migration code in chrome/browser/prefs/browser_prefs.cc and
      ios/chrome/browser/prefs/browser_prefs.mm

    From there, this CL does that following:

    - Remove GoogleURLTracker and associated classes from tests and production
      code.

    - //components/google/core/browser got folded into
      //components/google/core/common

    - A bunch of test-only functions to simulate the Google URL changing are
      gone.

    - UIThreadSearchTermsData in both iOS and non-iOS no longer needs a Profile
      parameter.

    Hopefully that's enough context that one can review the bulk of the CL
    (which is fairly uninteresting) without too much trouble.

    Bug: 973591

Removed our override.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8

commit afb1ab4d73cca4aa533ac2dc0c47e11803cc1cc8
Author: Peter Beverloo <peter@chromium.org>
Date:   Mon Aug 20 13:03:45 2018 +0000

    Remove the Budget API

    The API hasn't been adopted by developers leading to practically zero
    usage. Given that there isn't a clear path to interoperability either,
    let's remove it. This has been approved per the following Intent to
    Remove on blink-dev:

    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/18r3whCBv0I

    The specification draft has been updated to mention its obsolescence:

    https://wicg.github.io/budget-api/

    There are a few bits of browser-side budget-related code that are being
    used by push messaging. This CL also moves the relevant class
    (BudgetDatabase) to the push messaging directory, and updated it to
    maintain logic, while removing the dependency on the Mojo types.

    Bug: 873540, 874450

Chromium change:

https://chromium.googlesource.com/chromium/src/+/c7dc655a55548274eec4d12c0244aa1c753688dc

commit c7dc655a55548274eec4d12c0244aa1c753688dc
Author: Tom Anderson <thomasanderson@chromium.org>
Date:   Fri Aug 9 20:29:20 2019 +0000

    Switch Linux/Ozone to build with GTK

    Tested basic GTK support builds and runs with X11 and Wayland ozone backends.

    BUG=877545

Chromium change:

https://chromium.googlesource.com/chromium/src/+/b571c555a376980d373055d73924f0543109767e

commit b571c555a376980d373055d73924f0543109767e
Author: Joshua Peraza <jperaza@chromium.org>
Date:   Mon May 6 21:45:39 2019 +0000

    Rename crashpad_linux.cc to crashpad_android.cc

    Android has unique requirements that make it very different from Linux,
    so give it its own Crashpad file.

    Also remove OS guards for that file and stop building Crashpad files
    on Linux (returning soon).

We were matching alert button highlight/pressed behavior to that of the
tab close button. The close button has been transitioned to use ink drop
and the hover/pressed colors were removed from the tab style. Changed
our override of the alert button GetBackgroundColor to approximately
match the close button. Might need more tweaking of the alpha channel.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/1d04bbbdf462225f239965eed6318937350f61f6

commit 1d04bbbdf462225f239965eed6318937350f61f6
Author: Peter Kasting <pkasting@chromium.org>
Date:   Fri Aug 16 19:23:59 2019 +0000

    Use ink drops for tab close buttons instead of manually drawing highlights.

    This should have minimal effect on the default theme, but improves behavior for
    custom themes and custom titlebar colors.  It's also simpler and more like how
    the NTB already works.

    This fractionally tweaks the NTB pressed opacity to more closely match the spec
    (spec = 16%, old = 10% + (90% * 8%) = 17.2%, new = 10% + (90% * 7%) = 16.3%) to
    keep the NTB and tab close button highlights aligned.  These will be tweaked
    further in a future patch.

    Bug: 883016

Chromium change:

https://chromium.googlesource.com/chromium/src/+/ddf8dfc20000e8b7771c39bab7a6b02a35a08d07

commit ddf8dfc20000e8b7771c39bab7a6b02a35a08d07
Author: Matt Menke <mmenke@chromium.org>
Date:   Tue Aug 13 17:44:48 2019 +0000

    Prevent untrusted consumers from setting a param on ResourceRequest.

    |update_network_isolation_key_on_redirect| should only be set on
    navigation requests, and renderers are not trusted to set it.

    This CL introduces ResourceRequest::TrustedParams, which contains fields
    only the browser process is trusted to set, and an |is_trusted| bit that
    can be set when creating URLLoaderFactories. If TrustedParams are sent
    to a URLLoaderFactory without that bit set, the request will fail.

    Bug: 991736

Chromium change:

https://chromium.googlesource.com/chromium/src/+/3e973f964e7712b9ac7ef02f77739f13ae8d1dff

commit 3e973f964e7712b9ac7ef02f77739f13ae8d1dff
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date:   Thu Aug 22 08:02:40 2019 +0000

    Convert WebSocketHandshakeClientPtr to new Mojo types

    This CL converts WebSocketHandshakeClientPtr to new Mojo types.
    It updates CreateWebSocket from network_context.mojom
    and Connect from websocket_connector.mojom and methods
    and members which implements them.

    Bug: 955171, 978694

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/26e73cfd90affbf1bdf3efbe80bf2903b0e866ae

commit 26e73cfd90affbf1bdf3efbe80bf2903b0e866ae
Author: Yutaka Hirano <yhirano@chromium.org>
Date:   Tue Aug 6 02:38:13 2019 +0000

    Stop giving WebSocketClient to WebSocket creation function

    Instead, give it as an argument  of
    mojom.WebSocketHandshakeClient.OnConnectionEstablished.

    This is a follow up CL for
    https://chromium-review.googlesource.com/c/chromium/src/+/1728917.
    Passing the mojo::InterfaceRequest<WebSocketClient> at
    OnConnectionEstablished is less error prone because

     1) It is unable to bind the implementation before that, and
     2) It is now clear that we should detect connection errors on
        |handshake_client| until the connection is established, and
        |client| after that.

    Bug: 989406, 967524

https://chromium.googlesource.com/chromium/src/+/1007403a797957b8af46e962cdfc1f6f671954a4

commit 1007403a797957b8af46e962cdfc1f6f671954a4
Author: Yoichi Osato <yoichio@chromium.org>
Date:   Thu Aug 8 13:11:57 2019 +0000

    [WebSocket] Use Datapipe to transfer DataFrame buffer instead of ReadOnlyBuffer

    This CL introduces mojo DataPipe instead of ReadOnlyBuffer.
    With DataPipe, we can reduce memory copy and optimize quota control.

    Unfortunately, this CL makes performance slower:
    ToT:   147 MB/s
    Patch: 128 MB/s
    That's because this CL replaces minimize part and we will do
    the optimization later on.
    If the optimization doesn't go over the original score before
    M78 (will be branch cut on Sep 5th), we will revert this change.

    Bug: 865001

https://chromium.googlesource.com/chromium/src/+/fcaa2a2c441e28a5cb95cc90946712efb0ce085f

commit fcaa2a2c441e28a5cb95cc90946712efb0ce085f
Author: Yoichi Osato <yoichio@chromium.org>
Date:   Wed Aug 28 08:22:36 2019 +0000

    [WebSocket] Remove manual quota control for receiving.

    Because we're using mojo data pipe, which has own quota control,
    to transfer received data, we don't have manual one, or
    mojom::WebSocket.AddReceiveFlowControlQuota().
    This CL does a sort of work removing the function.

    mojom::WebSocket.AddReceiveFlowControlQuota(quota) did 5 tasks:
    browser side(mainly on WebSocketChannel)
     1. Trigger the first ReadFrame if renderer gets not throttled.
    For #1, this patch moves the trigger to mojo WebSocket.StartReceiving.

     2. Trigger next ReadFrame if there is enough quota.
     3. Send pending dataframes based on added quota.
    This patch moves task #2 and #3 to websocket.cc and datapipe itself.

     4. Dropchannel if all pending frames are received by renderer when closed.
    Because we can care #4 w/o renderer ping back, this patch move
    RespondToClosingHandshake()to WebSocketChannel::ReadFrames().

    renderer side(mainly on WebSocketChannelImpl)
     5. Ping browser that backpressure is turned off.
    For task #5, this patch changes not to call the mojo but throttle
    datapipe reading with WebSocketHandleImpl::ConsumePendingDataFrames().

    receive-arraybuffer-1MBx100.htmll?iteration=100 measurement on local build:
    ToT:            144 MB/s (stdev: 4.56 MB/s)
    Patch:          208 MB/s (stdev: 6.15 MB/s)
      (+44% to ToT, +41% to ReadOnlyBuffer)
    ReadOnlyBuffer: 147 MB/s

https://chromium.googlesource.com/chromium/src/+/a461132e64f53f45997aaa4222e05cdf5d10ea56

commit a461132e64f53f45997aaa4222e05cdf5d10ea56
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date:   Fri Aug 30 04:13:36 2019 +0000

    Reland "Convert WebSocket to new Mojo types"

    This is a reland of 06a7200b370f38f39c97a4810d0931ab5596014e

    It updates WebSocketChannelImplTest::EstablishConnection
    with new Mojo types without InterfacePtr and MakeRequest.

    TBR=jam@chromium.org

    Original change's description:
    > Convert WebSocket to new Mojo types
    >
    > This CL converts WebSocketPtr, to new Mojo types and
    > updates OnConnectionEstablished from websocket.mojom.
    >
    > Bug: 955171, 978694
    > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016
    > Commit-Queue: Julie Kim <jkim@igalia.com>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@google.com>
    > Cr-Commit-Position: refs/heads/master@{#691574}

    Bug: 955171, 978694

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/3e973f964e7712b9ac7ef02f77739f13ae8d1dff

commit 3e973f964e7712b9ac7ef02f77739f13ae8d1dff
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date:   Thu Aug 22 08:02:40 2019 +0000

    Convert WebSocketHandshakeClientPtr to new Mojo types

    This CL converts WebSocketHandshakeClientPtr to new Mojo types.
    It updates CreateWebSocket from network_context.mojom
    and Connect from websocket_connector.mojom and methods
    and members which implements them.

    Bug: 955171, 978694

https://chromium.googlesource.com/chromium/src/+/147816a09da54ba5967f40161b0317a5217da1fe

commit 147816a09da54ba5967f40161b0317a5217da1fe
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date:   Wed Aug 28 00:43:47 2019 +0000

    Convert TrustedHeaderClient to new Mojo types

    This CL converts TrustedHeaderClientPtr and
    TrustedHeaderClientRequest to new Mojo types.
    It also updates OnLoaderCreated and CreateWebSocket
    from network_context.mojom.

    Bug: 955171, 978694

https://chromium.googlesource.com/chromium/src/+/ac7f47a5bc94c0f350891b4bfb6d6cbea6addf48

commit ac7f47a5bc94c0f350891b4bfb6d6cbea6addf48
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date:   Thu Aug 29 08:52:26 2019 +0000

    Convert AuthenticationHandlerPtr to new Mojo types

    This CL converts AuthenticationHandlerPtr to new Mojo types.
    It updates CreateWebSocket from network_context.mojom and
    methods and members with new Mojo types.

    It also renames |binding_as_handshake_client_| to
    |receiver_as_handshake_client_| from WebRequestProxyingWebSocket.

    Bug: 955171, 978694

https://chromium.googlesource.com/chromium/src/+/a461132e64f53f45997aaa4222e05cdf5d10ea56

commit a461132e64f53f45997aaa4222e05cdf5d10ea56
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date:   Fri Aug 30 04:13:36 2019 +0000

    Reland "Convert WebSocket to new Mojo types"

    This is a reland of 06a7200b370f38f39c97a4810d0931ab5596014e

    It updates WebSocketChannelImplTest::EstablishConnection
    with new Mojo types without InterfacePtr and MakeRequest.

    TBR=jam@chromium.org

    Original change's description:
    > Convert WebSocket to new Mojo types
    >
    > This CL converts WebSocketPtr, to new Mojo types and
    > updates OnConnectionEstablished from websocket.mojom.
    >
    > Bug: 955171, 978694
    > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016
    > Commit-Queue: Julie Kim <jkim@igalia.com>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@google.com>
    > Cr-Commit-Position: refs/heads/master@{#691574}

    Bug: 955171, 978694

Chromium change:

https://chromium.googlesource.com/chromium/src/+/346c99158a1ea8b52d4837dac679693289e5a308

commit 346c99158a1ea8b52d4837dac679693289e5a308
Author: John Abd-El-Malek <jam@chromium.org>
Date:   Wed Jul 31 20:48:58 2019 +0000

    Remove ResourceRequestInfo.

    Bug: 934009

net::CookieOptions param is no longer passed to CanonicalCookie::Create.
We used this param's exclude_httponly() method to adjust expiration
time.

Patched back the param everywhere CanonicalCookie::Create is called,
which is not a great solution.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/b851acc052ee6a505d4f60fb9cc326c410b1285b

commit b851acc052ee6a505d4f60fb9cc326c410b1285b
Author: Lily Chen <chlily@chromium.org>
Date:   Wed Aug 7 15:54:44 2019 +0000

    Split server_time out of net::CookieOptions

    CookieOptions had an optional server_time field, which was used for
    clock skew adjustments when creating a cookie, and nothing else.
    Since CanonicalCookie::Create no longer depends on the other fields of
    CookieOptions, this CL replaces its CookieOptions argument with a
    base::Optional<base::Time> server_time argument. The server_time field
    is removed from CookieOptions because nothing else needs it. This does
    mean that CookieStore::SetCookieWithOptionsAsync needs an additional
    server_time argument since CookieOptions no longer includes it. But
    that method needs to be removed anyways.

    Mostly but not entirely mechanical changes. This should not change any
    behavior.

    Bug: 989098

…tHarness.

We used RenderViewHostTestHarness to override CreateBrowserContext, but
it became `final`. Instead, we'll use content::RenderViewHostTestHarness
where the method can still be overriden and readd profle() method to the
test classes.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/330d05c61fd34b5d7845d536e7368b8bc456f754

commit 330d05c61fd34b5d7845d536e7368b8bc456f754
Author: Sylvain Defresne <sdefresne@chromium.org>
Date:   Wed Aug 7 12:36:37 2019 +0000

    Change RenderViewHostTestHarness::CreateBrowserContext prototype

    Change RenderViewHostTestHarness::CreateBrowserContext() to
    return std::unique_ptr<content::BrowserContext> instead of a
    raw pointer.

    This enforce the ownership in the API instead of leaving it
    as a simple comment in the method comment.

base/test/scoped_task_environment.h -> base/test/task_environment.h
content/public/test/test_browser_thread_bundle.h -> content/public/test/browser_task_environment.h
net/test/test_with_scoped_task_environment.h -> net/test/test_with_task_environment.h

Chromium change:

https://chromium.googlesource.com/chromium/src/+/c7108748948a6ab308f323d6e72c59d29c7e240a

commit c7108748948a6ab308f323d6e72c59d29c7e240a
Author: Gabriel Charette <gab@chromium.org>
Date:   Fri Aug 23 03:31:40 2019 +0000

    Reland "[TaskEnvironment] Complete migration with header rename"

    This is a reland of 18947083c7e75ec6d5e8c3b729515d83bde41c59

    The move_source_file.py script's formatting rules incorrectly
    formatted services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
    after all. But we also can't rely 100% on git cl format (crbug.com/997063)
    so I ended up performing a git cl format && git add -up
    (+interactive addition of missing blank line after foo.h when included
    from top of foo.cc)

    Also added
    $ tools/git/move_source_file.py net/test/test_with_scoped_task_environment.h net/test/test_with_task_environment.h

    Original change's description:
    > [TaskEnvironment] Complete migration with header rename
    >
    > This is merely:
    >
    > $ tools/git/move_source_file.py base/test/scoped_task_environment.h base/test/task_environment.h
    > $ tools/git/move_source_file.py base/test/scoped_task_environment.cc base/test/task_environment.cc
    > $ tools/git/move_source_file.py base/test/scoped_task_environment_unittest.cc base/test/task_environment_unittest.cc
    > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.h content/public/test/browser_task_environment.h
    > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle.cc content/public/test/browser_task_environment.cc
    > $ tools/git/move_source_file.py content/public/test/test_browser_thread_bundle_unittest.cc content/public/test/browser_task_environment_unittest.cc
    > $ tools/git/move_source_file.py ios/web/public/test/test_web_thread_bundle.h ios/web/public/test/web_task_environment.h
    > $ tools/git/move_source_file.py ios/web/test/test_web_thread_bundle.cc ios/web/test/web_task_environment.cc
    >
    > and a few manual renames in DEPS files missed by the script
    >
    > This CL uses --bypass-hooks to avoid having to git cl format because
    > many headers are being reordered by git cl format and it's too many to
    > figure out in a no-op CL which ones are okay with it.
    > windows.h for one should typically be first and another one of the
    > reorderings in PS3 even caused a compile failure:
    > https://chromium-review.googlesource.com/c/chromium/src/+/1764962/3/components/services/font/font_loader_unittest.cc
    >
    > TBR=dcheng@chromium.org
    >
    > Bug: 992483

Now takes and ID and a GUID.

Added static IDs, but ideally we'd want to add SyncHelperTest to
BookmarkModel and call model()->generate_next_node_id().

Chromium change:

https://chromium.googlesource.com/chromium/src/+/44f5a818f30d888dcab7fcf8e885b12045389300

commit 44f5a818f30d888dcab7fcf8e885b12045389300
Author: Pauline Leitao <psivieroleitao@google.com>
Date:   Tue Jul 30 10:49:51 2019 +0000

    Introduce a GUID to BookmarkNode

    BookmarkNodes currently have no GUID or ID consistent across different
    clients and that remains stable throughout the lifetime of the bookmark.
    This CL thus introduces such a GUID. This will allow for the insertion
    of logic geared towards avoiding bookmark duplicates when synced across
    different devices and also potentially substitute other identifier
    fields later on. GUIDs are randomly generated for each added bookmark,
    with the exception of BookmarkPermanentNodes, for whom hard-coded GUIDs
    are used instead.

    Objectively, this CL does the following:
    1. Introduces an immutable GUID to the BookmarkNode and a corresponding
    key to the persisted JSON object, in order to allow for
    encoding/decoding.
    2. Changes BookmarkNode constructors to always take in an ID and GUID to
    be set to the newly created node.
    3. Changes the BookmarkPermanentNode constructor to assign hard-coded
    GUIDs to PermanentNodes (stored in a map) based on their Type.

    Bug: 978430

Chromium change:

https://chromium.googlesource.com/chromium/src/+/0d23b8d4b1e67392c80f8add8da47d14a22cac0c

commit 0d23b8d4b1e67392c80f8add8da47d14a22cac0c
Author: Evan Stade <estade@chromium.org>
Date:   Wed Aug 14 17:13:41 2019 +0000

    Add the ability to use a VectorIcon in MenuModel.

    The color and size of the vector icon is controlled by the view, and is
    not a property of the model.

    This CL adds plumbing to RenderViewContextMenuModel, ui::MenuModel, and
    views::MenuItemView, and updates the click-to-call context menu to use
    the new abilities. The click-to-call menu icon is downsized from 20 to
    16, which matches other context menu icons.

    Just enough of the APIs are updated for purposes of the click to call
    menu. More can be added as needed for other menus and icons.

    Bug: 989353

Chromium change:

https://chromium.googlesource.com/chromium/src/+/cfde7b381975b4ce50338f97a7ed0547a9ab6fa3

commit cfde7b381975b4ce50338f97a7ed0547a9ab6fa3
Author: Alex Clarke <alexclarke@chromium.org>
Date:   Thu Aug 15 17:11:47 2019 +0000

    Remove RunLoop::RunWithTimeout from public API

    This API is not being used much and one of the tests is flaky. Rather
    than fix the test it has been decided to remove the API. The internal
    working is left untouched so it would be easy to add it back should the
    need arise.

    Bug: 970187

Chromium change:

https://chromium.googlesource.com/chromium/src/+/9ce426007956a2db57f880721c247c0c8a824de6

commit 9ce426007956a2db57f880721c247c0c8a824de6
Author: Evan Stade <estade@chromium.org>
Date:   Mon Jul 29 23:56:14 2019 +0000

    Remove test util class BrowserAddedObserver

    It used NOTIFICATION_BROWSER_OPENED.

    Most of the time in these tests, the new browser is opened
    with chrome::NewWindow or chrome::NewEmptyWindow, which
    are usually synchronous, so waiting is not needed. The
    exception is when they trigger session restore, and in
    those cases it's sufficient to use
    SessionRestoreTestHelper::Wait.

    Bug: 268984

Chromium change:

https://chromium.googlesource.com/chromium/src/+/d6b8adac674244c5c104cbd70bb7da0d4b6d4cab

commit d6b8adac674244c5c104cbd70bb7da0d4b6d4cab
Author: Eric Stevenson <estevenson@chromium.org>
Date:   Fri Jul 26 21:26:06 2019 +0000

    jni_generator: Fix jcaller usage.

    This CL changes static methods to not pass a jcaller object to
    the native side. This isn't necessary because there is no Java object
    instance for static methods and it was actually just passing a jclass
    as a jobject which was always unused.

    The @JCAller annotation is also removed. It isn't strictly necessary
    anymore and is often used incorrectly (i.e. using @JCAller and adding
    an unused param on the native side).

    All Java and native definitions and uses are also updated to reflect
    the changed logic.

    Tbr: agrieve@chromium.org  # Large mechanical refactor.
    Bug: 986930

Chromium change:

https://chromium.googlesource.com/chromium/src/+/e3f6e640902edcaa2d2cb431ae9d15b419303c1c

commit e3f6e640902edcaa2d2cb431ae9d15b419303c1c
Author: Natalie Chouinard <chouinard@chromium.org>
Date:   Fri Jul 26 20:42:38 2019 +0000

    Remove Compat suffix from Preferences

    Now that the preferences Support Library migration is complete, and
    duplicates have been removed (crrev.com/c/1709880), we can remove the
    Compat suffix from all methods and classes.

    Bug: 967022

Chromium changes:

https://chromium.googlesource.com/chromium/src/+/11320f06e117d93f40f0443cd67c55ad65c5943f

commit 11320f06e117d93f40f0443cd67c55ad65c5943f
Author: Pâris MEULEMAN <pmeuleman@chromium.org>
Date:   Fri Jul 26 17:11:09 2019 +0000

    Merge SigninManagerDelegate back into SigninManager

    This merges back SigninManagerDelegate.java into SigninManager.java and
    likewise for c++ code. This is in the scope of a change of strategy
    regarding the identityManager implementation on Android, using a
    layering strategy similar to what was done on iOS.

    The change consist in:
    * copy chrome_signin_manager_delegate.* methods to
      signin_manager_android.*
    * rename occurrences of ChromeSigninManagerDelegate to
      SigninManagerAndroid, in Java including JNI invocations and C++.
    * Directly invoke methods instead of calling mDelegate (java)
    * Update constructors to include the delegate dependencies.

    * A significant change that is not an obvious code move is the rollback of
      SigninManagerAndroid's constructor using
      SigninClient/PrefService(local_state) to Profile. This makes the
      remainder of the change much simpler, but does cascade to the factory.

    The above changes are described in their files in PS3:
    crrev.com/c/1700210/3

Chromium change:

https://chromium.googlesource.com/chromium/src/+/a95f3499

commit a95f349902f2775415fa5d3f7a5a843e45084292
Author: Avi Drissman <avi@chromium.org>
Date:   Mon Aug 26 19:36:13 2019 +0000

    Mac package installer: Generalize packaging.

    Generalize the concept of .dmg file creation as "packaging". Rename
    various concepts from "dmg_whatever" to "packaging_whatever", and
    allow individual distributions to specify whether they want to be
    packaged as .dmg files, .pkg files, or both.

    BUG=913074

Chromium change:

https://chromium.googlesource.com/chromium/src/+/4fb3c7d0bc048850885d403d7c4e333e595defe5

commit 4fb3c7d0bc048850885d403d7c4e333e595defe5
Author: Jordy Greenblatt <jordynass@chromium.org>
Date:   Fri Jul 26 20:07:56 2019 +0000

    Settings: Remove basic_page references to non-existent paths

    3 of the pageVisibility paths (search, androidApps, system) that are
    read by the settings-basic-page [1] are never defined and are not part
    of the PathVisibility typedef [2]. I think the dom-if they control were
    simply never removed when the paths ceased to be used.

    This CL cleans up settings-basic-page by removing the references to
    non-existent paths.

    [1] https://screenshot.googleplex.com/CPO8xHQ9WSx
    [2] https://screenshot.googleplex.com/nxGJbNy8vbx

… disallowed resource.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/9f06bf9c6072720ef3dbec5c06ba0b859dee6a8e

commit 9f06bf9c6072720ef3dbec5c06ba0b859dee6a8e
Author: Robert Liao <robliao@chromium.org>
Date:   Mon Aug 12 19:33:55 2019 +0000

    Add GetCreationTime() function to profile, which returns the date/time the user profile was created.

    This is needed for use in the trigger checks for HaTS.

    Bug: 807714

Network Audit fix for C78