Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask again in private window's translate bubble should modify or… #3673

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 11, 2019

…iginal profile's translate pref.

Fix brave/brave-browser#6428

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yrliou yrliou added this to the 0.72.x - Nightly milestone Oct 11, 2019
@yrliou yrliou requested a review from bsclifton October 11, 2019 06:50
@yrliou yrliou self-assigned this Oct 11, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 😄

@yrliou yrliou merged commit 7d7f4dc into master Oct 11, 2019
@yrliou yrliou deleted the fix_private_window_translate_dont_ask_again branch October 11, 2019 07:10
yrliou added a commit that referenced this pull request Oct 11, 2019
…_ask_again

Don't ask again in private window's translate bubble should modify or…
yrliou added a commit that referenced this pull request Oct 11, 2019
…_ask_again

Don't ask again in private window's translate bubble should modify or…
yrliou added a commit that referenced this pull request Oct 11, 2019
…_ask_again

Don't ask again in private window's translate bubble should modify or…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants