Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift don't ask again in private window fix to 0.71.x #3676

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 11, 2019

Uplift of #3673

…_ask_again

Don't ask again in private window's translate bubble should modify or…
@yrliou yrliou added this to the 0.71.x - Dev milestone Oct 11, 2019
@yrliou yrliou self-assigned this Oct 11, 2019
@yrliou yrliou requested a review from a team October 11, 2019 07:34
@yrliou
Copy link
Member Author

yrliou commented Oct 11, 2019

Only test failures are lint and seems impossible to be related to this PR.

01:17:52  + git -C src/brave config user.name jenkins
01:17:52  + git -C src/brave config user.email no@reply.com
01:17:52  + git -C src/brave checkout -b TEMP_LINT_BRANCH_1
01:17:52  Switched to a new branch 'TEMP_LINT_BRANCH_1'
01:17:52  M	package-lock.json
01:17:52  + npm run lint -- --base=origin/0.71.x
01:17:52  
01:17:52  > brave@0.71.90 lint /Users/jenkins/jenkins/workspace/ix_private_dont_ask_again_0.71.x
01:17:52  > node ./scripts/commands.js lint "--base=origin/0.71.x"
01:17:52  
01:17:52  /Users/jenkins/jenkins/workspace/ix_private_dont_ask_again_0.71.x/src/brave: python /Users/jenkins/jenkins/workspace/ix_private_dont_ask_again_0.71.x/scripts/lint.py --project_root=/Users/jenkins/jenkins/workspace/ix_private_dont_ask_again_0.71.x/src --base_branch=origin/0.71.x
01:17:53  Traceback (most recent call last):
01:17:53    File "/Users/jenkins/jenkins/workspace/ix_private_dont_ask_again_0.71.x/scripts/lint.py", line 20, in <module>
01:17:53      import git_cl
01:17:53    File "/Users/jenkins/jenkins/workspace/ix_private_dont_ask_again_0.71.x/vendor/depot_tools/git_cl.py", line 40, in <module>
01:17:53      import auth
01:17:53    File "/Users/jenkins/jenkins/workspace/ix_private_dont_ask_again_0.71.x/vendor/depot_tools/auth.py", line 12, in <module>
01:17:53      import httplib2
01:17:53  ImportError: No module named httplib2
01:17:53  null
01:17:53  null
01:17:53  npm ERR! code ELIFECYCLE
01:17:53  npm ERR! errno 1
01:17:53  npm ERR! brave@0.71.90 lint: `node ./scripts/commands.js lint "--base=origin/0.71.x"`
01:17:53  npm ERR! Exit status 1
01:17:53  npm ERR! 
01:17:53  npm ERR! Failed at the brave@0.71.90 lint script.
01:17:53  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
01:17:53  
01:17:53  npm ERR! A complete log of this run can be found in:
01:17:53  npm ERR!     /Users/jenkins/.npm/_logs/2019-10-11T08_17_52_824Z-debug.log

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes already merged to master and 0.69.x! Verified CI looks great 😄 Thanks!

@bsclifton bsclifton merged commit d01b0e4 into 0.71.x Oct 11, 2019
@bsclifton bsclifton deleted the fix_private_dont_ask_again_0.71.x branch October 11, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants