Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes hover card bubble chrome:// urls (0.72.x). #3732

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Oct 17, 2019

Fixes brave/brave-browser#6385
Uplift request from #3687

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes hover card bubble chrome:// urls.
@mkarolin mkarolin added this to the 0.72.x - Dev milestone Oct 17, 2019
@mkarolin mkarolin self-assigned this Oct 17, 2019
@mkarolin mkarolin changed the title WIP: Fixes hover card bubble chrome:// urls (0.72.x). Fixes hover card bubble chrome:// urls (0.72.x). Oct 17, 2019
@mkarolin mkarolin requested a review from a team October 17, 2019 23:01
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit c666f8d into 0.72.x Oct 18, 2019
@bsclifton bsclifton deleted the pr-3687-0.72.x branch October 18, 2019 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants