Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to publish GitHub pre-release as full release #3736

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Oct 17, 2019

Also fix tests.

Fixes: brave/brave-browser#6523

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton
Copy link
Member

Added the missing 0.73.x milestone (as that is when it was merged to master) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update publish_release.py to remove Preview from GitHub release
3 participants