Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to publish GitHub pre-release as full release (uplift to 0.72.x) #3742

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add ability to publish GitHub pre-release as full release (uplift to 0.72.x) #3742

merged 2 commits into from
Oct 28, 2019

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Oct 18, 2019

Uplift of #3736

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@mbacchi mbacchi self-assigned this Oct 18, 2019
@mbacchi mbacchi added this to the 0.72.x - Dev milestone Oct 18, 2019
@mihaiplesa mihaiplesa added the CI/skip Do not run CI builds (except noplatform) label Oct 28, 2019
kjozwiak
kjozwiak approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@mbacchi mbacchi merged commit 3f20419 into 0.72.x Oct 28, 2019
@mbacchi mbacchi deleted the pr3736_issue_6523_0.72.x branch October 28, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@mbacchi mbacchi

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mbacchi @kjozwiak @mihaiplesa