Ballots assigned incorrect proof

[jhoneycutt]

Submitter Checklist:

Resolves brave/brave-browser#6607

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

1. Enable rewards with short contribution interval on staging. Launched with --enable-logging=stderr --vmodule=rewards=6 --rewards=staging=true,reconcile-interval=10,short-retries=true to see log messages, use staging env, set short contribution interval, and short retry interval.
2. Recovered wallet with 30 BAT
3. Aet AC amount to Up to 20 BAT
4. Add verified and non verified publishers to AC table
5. Add verified recurring tips in this order (5, 10, 10, 10, 1)
6. Wait for monthly contribution to complete
7. Watch console window output. Verify that there are no messages containing the string "invalid surveyor proof"

Because this bug is timing related and not 100% reproducible, repeat the steps above several (5?) times.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[tmancey]

LGTM++

[jhoneycutt]

CI shows several unrelated test failures (timeouts). However, those failures cause the browser tests to abort early, meaning that the relevant browser tests to this PR are unable to run. The network audit step also fails for unrelated reasons.

[NejcZdovc]

code change looks good to me. I see that CI was aborted, so I restarted it. When CI passes we can merge it

[jhoneycutt]

All tests passed (after retries), but some pipeline steps related to publishing test results failed. Another step timed out with this error message:

09:56:44  Cannot contact i-09f79fb4f5b7386d4: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@7ead8495:i-09f79fb4f5b7386d4": Remote call on i-09f79fb4f5b7386d4 failed. The channel is closing down or has closed down
10:01:51  Could not connect to i-09f79fb4f5b7386d4 to send interrupt signal to process