Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ballots assigned incorrect proof (uplift to 0.73.x) #3947

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Ballots assigned incorrect proof (uplift to 0.73.x) #3947

merged 1 commit into from
Nov 10, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 8, 2019 •
edited by bsclifton
Loading

Uplift of #3820

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 8, 2019
@brave-builds brave-builds added this to the 0.73.x - Dev milestone Nov 8, 2019
@NejcZdovc NejcZdovc removed their request for review November 9, 2019 06:32
kjozwiak
kjozwiak approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.73.x approved after deliberating with @brave/uplift-approvers. This was also uplifted into 0.71.x as per #3923 so we'll need it in the other channels. Both CI/Jenkins and CI/Travis passed without any failures.

@kjozwiak kjozwiak merged commit 83b2b17 into 0.73.x Nov 10, 2019
@kjozwiak kjozwiak deleted the pr3820_issue-6607-ballots-assigned-incorrect-proof_0.73.x branch November 10, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases