Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating welcome page text for anon wallets #3897

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 6, 2019

Fixes: brave/brave-browser#6602

Submitter Checklist:

Test Plan:

  1. Open browser
  2. Wait for initialization
  3. Close browser
  4. Open Preferences file and search for countryid_at_install
  5. Replace current value with 19024
  6. Restart Browser
  7. Navigate to brave://rewards
  8. Confirm updated text is shown on welcome page

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.73.x - Dev milestone Nov 6, 2019
@ryanml ryanml requested a review from a team November 6, 2019 20:28
@ryanml ryanml requested a review from NejcZdovc as a code owner November 6, 2019 20:28
@ryanml ryanml self-assigned this Nov 6, 2019
@ryanml ryanml force-pushed the welcome-points branch 4 times, most recently from b581c2f to 9a141b1 Compare November 6, 2019 23:39
@ryanml ryanml added the CI/skip-android Do not run CI builds for Android label Nov 7, 2019
@ryanml ryanml requested a review from NejcZdovc November 7, 2019 14:50
@mihaiplesa
Copy link
Collaborator

Has passed for Linux so applied skip label and will need to be re-built only on iOS and macOS (unless no new changes pushed).

@ryanml ryanml merged commit 2b0f75c into master Nov 8, 2019
@ryanml ryanml deleted the welcome-points branch November 8, 2019 17:10
ryanml added a commit that referenced this pull request Nov 8, 2019
Updating welcome page text for anon wallets
ryanml added a commit that referenced this pull request Nov 8, 2019
Updating welcome page text for anon wallets
ryanml added a commit that referenced this pull request Nov 8, 2019
Updating welcome page text for anon wallets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAT Points text needed on BR slide of desktop onboarding flow
3 participants