Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating welcome page text for anon wallets (0.73) #3932

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Updating welcome page text for anon wallets (0.73) #3932

merged 1 commit into from
Nov 10, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 8, 2019

@ryanml
Merge pull request #3897 from brave/welcome-points
23297a3 
Updating welcome page text for anon wallets
@ryanml ryanml added this to the 0.73.x - Dev milestone Nov 8, 2019
@ryanml ryanml requested a review from a team November 8, 2019 17:16
@ryanml ryanml requested a review from NejcZdovc as a code owner November 8, 2019 17:16
@ryanml ryanml self-assigned this Nov 8, 2019
@NejcZdovc NejcZdovc removed their request for review November 9, 2019 06:33
@kjozwiak
Copy link
Member

Restarting macOS due to the following failures as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3897-73/1/execution/node/753/log/:

18:18:01  [59187:775:1108/151705.923604:ERROR:ads_serve.cc(100)] Failed to download catalog from:
18:18:01    url: https://ads-serve.brave.com/v1/catalog
18:18:01    response_status_code: -1
18:18:01    response: 
18:18:01    headers: 
18:18:01  [310/317] BraveRewardsBrowserTest.PendingContributionTip (TIMED OUT)
18:18:01  [311/317] BraveRewardsBrowserTest/BraveAdsBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsEnabledAndAdsDisabled_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled_ShouldNotShowOnboarding (1322 ms)
18:18:01  [312/317] BraveRewardsBrowserTest/BraveAdsBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsDisabled_ForUnsupportedLocale_RewardsShouldBeDisabled_AdsShouldBeDisabled_ShouldNotShowOnboarding (1584 ms)
18:18:01  [313/317] BraveRewardsBrowserTest/BraveAdsBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled_ShouldNotShowOnboarding (1323 ms)
18:18:02  [314/317] BraveRewardsBrowserTest/BraveAdsBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsDisabled_ForSupportedLocale_RewardsShouldBeDisabled_AdsShouldBeDisabled_ShouldNotShowOnboarding (1318 ms)
18:18:02  [315/317] BraveRewardsBrowserTest/BraveAdsBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsEnabledAndAdsDisabled_ForSupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled_ShouldShowOnboarding (1055 ms)
18:18:02  [316/317] BraveRewardsBrowserTest/BraveAdsBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForSupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled_ShouldNotShowOnboarding (1057 ms)
18:18:05  Sending interrupt signal to process
18:18:05  
18:18:05  Caught signal. Killing spawned test processes...
18:18:05  Sending SIGTERM to 1 child processes... done.
18:18:05  Giving processes a chance to terminate cleanly... Sending interrupt signal to process
18:18:05  script returned exit code 143

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 10, 2019
@kjozwiak
Copy link
Member

Restarting macOS again due to https://ci.brave.com/job/brave-browser-build-pr/job/pr3917_issue-6745-transactions-reset-after-restart_0.72.x/1/execution/node/582/log/ failing.

kjozwiak
kjozwiak approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.73.x approved after deliberating with @brave/uplift-approvers. This fix was also uplifted into 0.71.x as per #3934 so we'll need it in the other channels. Both CI/Jenkins and CI/Travis passed after several retries.

@kjozwiak kjozwiak merged commit 60aa025 into 0.73.x Nov 10, 2019
@kjozwiak kjozwiak deleted the uplift-3897-73 branch November 10, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak