Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 78.0.3904.97 to Chromium 79.0.3945.29 #3946

Closed
wants to merge 49 commits into from

Commits on Nov 13, 2019

  1. Updated grdp exclusions in transifex.py.

    Fixes brave/brave-browser#6907
    
    There is no need to exclude os_settings_strings.grdp and
    xr_consent_ui_strings.grdp.
    
    media_router_resources.grdp has been removed upstream.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/edcf55b10dfe41c3ffa18bfbca8f07e62532ef74
    
    commit edcf55b10dfe41c3ffa18bfbca8f07e62532ef74
    Author: Takumi Fujimoto <takumif@chromium.org>
    Date:   Tue Jul 9 16:36:20 2019 +0000
    
        Delete Media Router WebUI dialog resource files
    
        Delete JS/HTML/CSS files for chrome://media-router and its tests.
    
        We do not remove files related to chrome://media-router-internals
        because that is still in use.
    
        Bug: 900246
    mkarolin committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    63ff895 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9165e37 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Configuration menu
    Copy the full SHA
    795f909 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8140e6 View commit details
    Browse the repository at this point in the history
  3. ntp_tiles_strings.grdp has been removed.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/0da1b5287c24ac582760a40530a7811259558d17
    
    commit 0da1b5287c24ac582760a40530a7811259558d17
    Author: Kyle Milka <kmilka@chromium.org>
    Date:   Mon Oct 7 20:14:30 2019 +0000
    
        [NTP] Remove ShowFirstRunDefaultSearchShortcut
    
        Not launching.
    
        Bug: None
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4ab7f3e View commit details
    Browse the repository at this point in the history
  4. Added missing headers.

    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    be727e6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    20b1b2e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d0ceabc View commit details
    Browse the repository at this point in the history
  7. PostTaskWithTraits -> PostTask

    Also, Create*TaskRunnerWithTraits -> Create*TaskRunner.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/dd9428771eb0e498a401bbfaf6d247d051315e92
    
    commit dd9428771eb0e498a401bbfaf6d247d051315e92
    Author: Sami Kyostila <skyostil@chromium.org>
    Date:   Mon Sep 9 14:42:43 2019 +0000
    
        Reland "base: Remove temporary "WithTraits" task API wrappers"
    
        This is a reland of 0bf621ef56940ef6a05266527b189898cc7bbe11
    
        Original change's description:
        > base: Remove temporary "WithTraits" task API wrappers
        >
        > Now that everyone has been migrated to the renamed
        > PostTask/CreateTaskRunner APIs, we can remove these temporary wrappers.
        >
        > TBR=gab@chromium.org
        > (to apply side-effects of mechanical change in //base)
        >
        > Bug: 968047
        > Change-Id: I69c53abd899f37586f23ec295ffcc9bf12042c4a
        > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752787
        > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
        > Reviewed-by: Gabriel Charette <gab@chromium.org>
        > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
        > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
        > Cr-Commit-Position: refs/heads/master@{#693695}
    
        TBR=gab@chromium.org
        (reland without changes)
    
        Bug: 968047
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    26704dc View commit details
    Browse the repository at this point in the history
  8. syncer::Cryptographer became abstract.

    Use synber::DirectoryCryptographer implementation instead.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/60ad5e7ae3634951a77625d1c1c92a5e5cacebd5
    
    commit 60ad5e7ae3634951a77625d1c1c92a5e5cacebd5
    Author: Mikel Astiz <mastiz@chromium.org>
    Date:   Tue Sep 24 13:31:40 2019 +0000
    
        Introduce sync Cryptographer interface
    
        This reduces the exposure of a big API to many files that don't actually
        require it, and unblocks the redesign of the cryptographer in USS, which
        will be addressed in follow-up patches.
    
        Some trivial renames:
        Cryptographer --> DirectoryCryptographer
        Cryptographer::is_ready() --> Cryptographer::CanEncrypt()
        Cryptographer::GetDefaultNigoriKeyName() -->
          Cryptographer::GetDefaultEncryptionKeyName()
    
        Bug: 967417
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    0a88a0b View commit details
    Browse the repository at this point in the history
  9. Use HighlightPathGenerator.

    Instead of storing highlight path in a property (which was removed) use
    either one of the pre-made HighlightPath generators or add a custom one.
    Added custom generators for:
     * BraveTextButton
     * BraveActionView
     * BraveRewardsActionStubView
    
    Chromium bug:
    
    https://crbug.com/1007546
    
    https://chromium.googlesource.com/chromium/src.git/+/a934e7d7e0b1691c01b6728f6b02afeb1327b7bd
    
    commit a934e7d7e0b1691c01b6728f6b02afeb1327b7bd
    Author: Peter Boström <pbos@chromium.org>
    Date:   Tue Oct 1 19:07:13 2019 +0000
    
        Add a HighlightPathGenerator class
    
        This set of classes are intended to remove the need to override
        OnBoundsChanged on Views to set |kHighlightPathKey|. Whenever a path is
        needed the generator gets asked to generate one.
    
        Bug: chromium:1007546
    
    https://chromium.googlesource.com/chromium/src/+/cb413eeccc4f18057b565e4a270df55417988ab9
    
    commit cb413eeccc4f18057b565e4a270df55417988ab9
    Author: Peter Boström <pbos@chromium.org>
    Date:   Wed Oct 16 18:07:18 2019 +0000
    
        Remove kHighlightPathKey
    
        This has now been fully replaced with HighlightPathGenerator instances.
    
        Bug: chromium:1007546
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ea8def4 View commit details
    Browse the repository at this point in the history
  10. Use different AssociatedInterfaceProvider::GetInterfaces.

    The overload we were using was removed.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/b3b852f1911fe67e81b596da48e247d67220ac0d
    
    commit b3b852f1911fe67e81b596da48e247d67220ac0d
    Author: Mario Sanchez Prada <mario@igalia.com>
    Date:   Fri Oct 4 17:53:24 2019 +0000
    
        Remove AssociatedInterface{Registry,Provider}'s methods for old Mojo types
    
        This CL eliminates the need for having those versions of these templated
        methods available by migrating the few references to the old Mojo types
        in those places that interact with them, so we can remove them along
        with such migrations, all in one go.
    
        Bug: 955171, 978694, 936482
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    037c4a2 View commit details
    Browse the repository at this point in the history
  11. LookUpProxyForURL now takes PendingRemote.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/ed8d98f254f3a6f6df55d2665aa3e568b99b4c7e
    
    commit ed8d98f254f3a6f6df55d2665aa3e568b99b4c7e
    Author: Julie Jeongeun Kim <jkim@igalia.com>
    Date:   Mon Oct 14 11:11:33 2019 +0000
    
        Convert ProxyLookupClient to new Mojo types
    
        This CL converts ProxyLookupClient from proxy_lookup_client.mojom
        to new Mojo types using PendingRemote, Receiver, and Remote.
    
        Bug: 955171
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    c378d6c View commit details
    Browse the repository at this point in the history
  12. Socket::AcceptCompletionCallback now takes PendingRemote.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/29bf65088f1647dd53b90b9afb186a1015a591bc
    
    commit 29bf65088f1647dd53b90b9afb186a1015a591bc
    Author: Miyoung Shin <myid.shin@igalia.com>
    Date:   Tue Oct 15 01:37:57 2019 +0000
    
        Convert TCPConnectedSocket to new Mojo types
    
        This CL converts TCPConnectedSocket{Ptr, Request} in chrome,
        components, content, extensions and services to the new Mojo type,
        and uses pending_receiver<T> in network_context.mojom and
        pending_remote<T>, pending_receiver<T> in tcp_socket.mojom.
    
        Bug: 955171
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    14d64e0 View commit details
    Browse the repository at this point in the history
  13. CreatePrefService now thakes PendingRemote.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/9973fcb5cdd0f5ddd717d3b9a14ab51bfa3fe433
    
    commit 9973fcb5cdd0f5ddd717d3b9a14ab51bfa3fe433
    Author: Julie Jeongeun Kim <jkim@igalia.com>
    Date:   Sat Sep 21 10:03:49 2019 +0000
    
        Convert TrackedPreferenceValidationDelegate to new Mojo types
    
        This CL converts TrackedPreferenceValidationDelegatePtr and
        TrackedPreferenceValidationDelegateRequest to new Mojo types.
    
        It uses PendingRemote or Remote and ReceiverSet instead of
        TrackedPreferenceValidationDelegatePtr and BindingSet.
    
        Bug: 955171
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    6811fee View commit details
    Browse the repository at this point in the history
  14. AlertIndicator::alert_state_ is now base::Optional.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/a59e78e2fa83b6d2437ca4bd63a57d7bad243b4e
    
    commit a59e78e2fa83b6d2437ca4bd63a57d7bad243b4e
    Author: Collin Baker <collinbaker@chromium.org>
    Date:   Tue Oct 15 16:16:55 2019 +0000
    
        Remove GetHighestPriorityTabAlertStateForContents()
    
        This migrates callers to GetTabAlertStatesForContents(), which returns
        all the applicable TabAlertStates, or none at all. This also removes
    
        TabAlertState::NONE since this function will return an empty list
        instead. Use cases that needed TabAlertState::NONE are replaced with
        base::Optional<TabAlertState>.
    
        Bug: 1004983
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    22dd0e3 View commit details
    Browse the repository at this point in the history
  15. Profile menu's SetIdentityInfo signature change.

    Chromium changes:
    
    https://chromium.googlesource.com/chromium/src/+/e427f7c9ce109b071bd17183456d3015ef44ed71
    
    commit e427f7c9ce109b071bd17183456d3015ef44ed71
    Author: Thomas Tangl <tangltom@chromium.org>
    Date:   Wed Sep 25 16:15:57 2019 +0000
    
        [profile-menu] Add badge to identity image
    
        ...depending on the sync state.
    
        Screenshot:
        https://drive.google.com/file/d/1npd-N8-jGzMws9PtzpKZYyXrpeyGCRzj/view?usp=sharing
    
        Bug: 995720
    
    https://chromium.googlesource.com/chromium/src/+/f6a5f5b84a5ba341b49392b94c1865d09aa29b34
    
    commit f6a5f5b84a5ba341b49392b94c1865d09aa29b34
    Author: Thomas Tangl <tangltom@chromium.org>
    Date:   Wed Sep 25 16:37:10 2019 +0000
    
        [profile-menu] Refactor image cropping logic
    
        - To reduce conversions from gfx::ImageSkia to gfx::Image
        - To make image parameters of the ProfileMenuViewBase
          API consistent
    
        Bug: 995720
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7bec199 View commit details
    Browse the repository at this point in the history
  16. NewExtensionUpdaterService is not feature gated.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/5b200929900463e2d90c7c14bf9a3845ebed6662
    
    commit 5b200929900463e2d90c7c14bf9a3845ebed6662
    Author: Joshua Pawlicki <waffles@chromium.org>
    Date:   Fri Sep 6 19:50:57 2019 +0000
    
        Launch NewExtensionUpdater experiment.
    
        This required moving some ContentVerification tests that were using an
        interceptor in the old updater stack to use an interceptor for the new
        one.
    
        Otherwise, the change is very straightforward.
    
        Bug: 920775
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    c236bc7 View commit details
    Browse the repository at this point in the history
  17. HandleExternalProtocol now takes initiating_origin

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/13b66bdf6719bcfedf549ff8ce2b18d2279e0396
    
    commit    13b66bdf6719bcfedf549ff8ce2b18d2279e0396
    author    Emily Stark <estark@google.com>
    date      Mon Oct 14 11:11:33 2019
    
    Add origin to external protocol dialog
    
    This is a stopgap fix for the fact that it's unclear which frame
    triggered a navigation to an external protocol. Eventually, we want to
    implement some more robust fixes, like preventing a frame from
    navigating another cross-origin frame to an external protocol, but
    that'll involve a bit more investigation and metrics (to be added in a
    follow-up CL).
    
    Bug: 754304
    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    b3debd8 View commit details
    Browse the repository at this point in the history
  18. LOCATION_BAR_BUBBLE_CORNER_RADIUS was removed.

    Transitioned to ChromeLayoutProvider::GetCornerRadiusMetric instead.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/507d21a5f2df4e98ac7f37eb25594d01ff7f2a2b
    
    commit 507d21a5f2df4e98ac7f37eb25594d01ff7f2a2b
    Author: Peter Kasting <pkasting@chromium.org>
    Date:   Mon Sep 16 14:50:43 2019 +0000
    
        Make greater use of LayoutProvider::GetCornerRadiusMetric().
    
        This also collapses some overrides from ChromeLayoutProvider down into
        LayoutProvider when the LayoutProvider-side differences never had an
        effect.
    
        Bug: 940766
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ffbd4a0 View commit details
    Browse the repository at this point in the history
  19. webrtc_ip_handling_policy.h moved to blink.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/b5bf548f6b58ad35ec8dc8c9918939ac02bb794c
    
    commit b5bf548f6b58ad35ec8dc8c9918939ac02bb794c
    Author: Antonio Gomes <tonikitoo@igalia.com>
    Date:   Thu Sep 12 17:40:15 2019 +0000
    
        Move webrtc_ip_handling_policy.cc|h to Blink
    
        ... from content/public/common.
    
        This is another preliminary step to Onion souping
        peer_connection_dependency_factory.cc|h|unittest.
        No functionality change expected.
    
        The solution is described in section 5 of the design document [1].
    
        [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/
    
        BUG=787254
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4c3a387 View commit details
    Browse the repository at this point in the history
  20. Don't std::move temporary objects

    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    e534b81 View commit details
    Browse the repository at this point in the history
  21. LaunchUrl now takes initiating_origin

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/13b66bdf6719bcfedf549ff8ce2b18d2279e0396
    
    commit    13b66bdf6719bcfedf549ff8ce2b18d2279e0396
    author    Emily Stark <estark@google.com>
    date      Mon Oct 14 11:11:33 2019
    
    Add origin to external protocol dialog
    
    This is a stopgap fix for the fact that it's unclear which frame
    triggered a navigation to an external protocol. Eventually, we want to
    implement some more robust fixes, like preventing a frame from
    navigating another cross-origin frame to an external protocol, but
    that'll involve a bit more investigation and metrics (to be added in a
    follow-up CL).
    
    Bug: 754304
    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7940170 View commit details
    Browse the repository at this point in the history
  22. Profile attributes SetName -> SetLocalProfileName.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/bafd44c226f3a3406e4b70ed5fb1be662d4d416b
    
    commit bafd44c226f3a3406e4b70ed5fb1be662d4d416b
    Author: Monica Basta <msalama@chromium.org>
    Date:   Thu Oct 10 10:14:54 2019 +0000
    
        [Signin]: Show the concatenation of the GAIA name and profile name.
    
        Use the concatenation of GAIA name and profile name as the identity of
        the profile to be shown in the User Menu and the profile switcher. With
        the efforts towards encouraging the use of multiple profiles, it becomes
        more important to show a clear identity for the profile and clear
        transitions on events like sign in, enable sync, sign out. If no primary
        account or unconsented primary account exists for the profile, the local
        profile name is used. Otherwise, we show the concatenation of GAIA name
        and profile name in this format: |GAIA name (profile name)|. The only
        exception where we only show the GAIA name is if the profile name is a
        substring of the GAIA name. The implementation is behind a kill switch
        |kConcatenateGaiaAndProfileName| enabled by default.
    
        Bug: 1012182
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    5514724 View commit details
    Browse the repository at this point in the history
  23. URLLoaderFactory now takes PendingReceiver

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/7f8e26a2d575cb0e69a467bf4f3270a694f885a8
    
    commit    7f8e26a2d575cb0e69a467bf4f3270a694f885a8
    author    Julie Jeongeun Kim <jkim@igalia.com>
    date      Thu Oct 10 12:09:52 2019
    
    Convert Clone() in url_loader_factory.mojom to new Mojo types
    
    This CL converts URLLoaderFactoryRequest from Clone()
    in url_loader_factory.mojom using PendingReceiver and
    ReceiverSet.
    
    Bug: 955171
    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    9859869 View commit details
    Browse the repository at this point in the history
  24. ProxyWebSocket::OnConnectionEstablished now takes WebSocketHandshakeR…

    …esponsePtr response
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/06a7f290e23932b6c9835361aac9fbbf565813f0
    
    commit    06a7f290e23932b6c9835361aac9fbbf565813f0
    author    Yoichi Osato <yoichio@chromium.org>
    date      Sat Oct 12 01:41:14 2019
    
    [WebSocket] Do not send response headers for failed handshake.
    
    This patch changes network service to restrict sending the headers to
    the renderer not to leak info if handshake was failed.
    
    This also changes WebRequest API and devtools event listening as failed
    when handshake was failed.
    
    Change-Id: I03160b06546711365273180a8020239e09528a47
    Bug: 944619
    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    74c5d7a View commit details
    Browse the repository at this point in the history
  25. ProxyingWebSocket::OnHeadersReceived now takes remote_endpoint

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/832c8907284db238cec43d1ba0a3e8bb818c5cc3
    
    commit    832c8907284db238cec43d1ba0a3e8bb818c5cc3
    author    Yutaka Hirano <yhirano@chromium.org>
    date      Wed Oct 16 10:04:34 2019
    
    Allow extensions to modify CORS preflight with Web Request API (1/2)
    
    Supporting preflight is tricky because preflight requests are made in
    the network service, and they don't have request IDs. We are adding
    a new message, OnLoaderForCorsPreflightCreated, to
    TrustedURLLoaderHeaderClient to address that.
    
    We are using TrustedURLLoaderHeaderClient, which means this mechanism
    works only when "extraHeaders" is specified. Unlike for usual requests,
    WebRequestProxyingUrlLoaderFactory::InProgressRequest dispatches
     - onBeforeRequest when OnLoaderForCorsPreflightCreated is called,
     - onBeforeSendHeaders and onSendHeaders when OnBeforeSendHeaders
       is called, and
     - onHeadersReceived, onResponseStarted, and onCompleted when
       OnHeadersReceived is called.
    
    This CL is a preliminary change. It adds
     - TrustedURLLoaderHeaderClient.OnLoaderForCorsPreflightCreated
       as described above,
     - "remote_endpoint" param to TrustedHeaderClient.OnHeadersReceived
       to get endpoint information in OnHeadersReceived, and
     - kURLLoaderOptionAsCorsPreflight to mark a request as a CORS
       preflight.
    
    This CL doesn't change any behavior because we have not set
    kURLLoadOptionAsCorsPreflight and kURLLoadOptionUseHeaderClient in
    network::cors::PreflightController yet.
    
    The subsequent change is: https://crrev.com/c/1837561
    
    Bug: 1002884
    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2c52474 View commit details
    Browse the repository at this point in the history
  26. ProxyingWebSocket::OnResponseReceived no longer exists

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/06a7f290e23932b6c9835361aac9fbbf565813f0
    
    commit    06a7f290e23932b6c9835361aac9fbbf565813f0
    author    Yoichi Osato <yoichio@chromium.org>
    date      Sat Oct 12 01:41:14 2019
    
    [WebSocket] Do not send response headers for failed handshake.
    
    This patch changes network service to restrict sending the headers to
    the renderer not to leak info if handshake was failed.
    
    This also changes WebRequest API and devtools event listening as failed
    when handshake was failed.
    
    Change-Id: I03160b06546711365273180a8020239e09528a47
    Bug: 944619
    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    e675ed5 View commit details
    Browse the repository at this point in the history
  27. Moved overriding omnibox colors to theme service.

    Location bar no longer calculates tint nor passes it to GetOmniboxColor.
    Instead ThemeProvider is passed. Added an override for GetOmniboxColor
    to BraveThemeService.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/4604e331574e87ce8bf2b7dc66524c7398a96725
    
    commit 4604e331574e87ce8bf2b7dc66524c7398a96725
    Author: Tom Anderson <thomasanderson@chromium.org>
    Date:   Fri Sep 13 19:47:08 2019 +0000
    
        Allow custom themes to style the location bar
    
        * Add four new color constants that are overridable by custom themes.
        * Omnibox colors are calculated based on the given colors if they are provided,
          otherwise the default colors are used.
          - Calculated colors are identical to those of the pre-MD-refresh GTK theme.
    
        BUG=863230
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    81ccfa1 View commit details
    Browse the repository at this point in the history
  28. Avatar button changes.

    ShouldShowGenericIcon was removed and generic profile is now determined
    by IsGenericProfile which sadly is scoped to the .cc file. Instead of
    patching it overriding GetState which determines the type of profile. If
    the profile is determined to be generic, then do our normal check and
    change it to "normal".
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/a3b53120fca4a42f19afe4af29bc67a404581ec4
    
    commit a3b53120fca4a42f19afe4af29bc67a404581ec4
    Author: Jan Krcal <jkrcal@chromium.org>
    Date:   Fri Sep 6 10:55:43 2019 +0000
    
        [Avatar button] Extract the UI state into one enum
    
        This CL refactors the avatar toolbar button so that the UI state is
        extracted into one state getter which results in consistent treatment
        across different functions displaying the UI and simplifies the code.
    
        Bug: 967317
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    40029d3 View commit details
    Browse the repository at this point in the history
  29. ProfileAttributesStorage::AddProfile signature change.

    Now takes an extra bool is_consented_primary_account.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/9ca470473e8a57c36d39844fb5c47c1b26eb3f35
    
    commit 9ca470473e8a57c36d39844fb5c47c1b26eb3f35
    Author: Monica Basta <msalama@chromium.org>
    Date:   Mon Sep 16 17:36:51 2019 +0000
    
        [Signin]: Persist the Unconsented primary account to profile info cache.
    
        Persist the Unconsented primary account in the profile info cache the
        same way we do for the primary account. If the sync is off, and the user
        is signed in, the profile will be attached to the UPA. Once sync is on,
        the UPA will be equal to the primary account.
    
        Previously, we only persisted primary account in the profile info cache.
        It was enough to check if GAIA id or the username is not empty to
        determine if the user is syncing. This CL, persists as well the UPA.
        The check for GAIA id or the username is empty is no more sufficient, a
        new field is added |ProfileAttributesEntry::kIsConsentedPrimaryAccount|.
        If the GAIA id or the username is not empty, we can be in one the
        following cases:
        (1) |ProfileAttributesEntry::kIsConsentedPrimaryAccount| is true, then
        UPA is equal to the primary account and sync is on.
        (2) |ProfileAttributesEntry::kIsConsentedPrimaryAccount| is false, then
        this profile has no primary account and sync is off. The account
        persisted is the UPA.
    
        Bug: 1003308
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2202796 View commit details
    Browse the repository at this point in the history
  30. ExternalProcessImportBridge now uses mojom observer.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/aa59e9ec484ceff647a58e58fa16e1ee784d157f
    
    commit aa59e9ec484ceff647a58e58fa16e1ee784d157f
    Author: Henrique Ferreiro <hferreiro@igalia.com>
    Date:   Tue Sep 24 08:38:14 2019 +0000
    
        Migrate profile_import.mojom to the new Mojo types
    
        Convert the implementation and all users of the
        chrome::mojom::ProfileImportObserver interface.
    
        Bug: 955171
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    5eb0215 View commit details
    Browse the repository at this point in the history
  31. PageActionIcon interface changes.

    Also, Bookmark Star refactoring.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/c7f0eff7fa72fdacba77cfc4cc57dc3044ae5332
    
    commit c7f0eff7fa72fdacba77cfc4cc57dc3044ae5332
    Author: Alan Cutter <alancutter@chromium.org>
    Date:   Mon Sep 16 02:17:32 2019 +0000
    
        Make PageActionIcon interface on BrowserWindow agnostic to containers
    
        This CL replaces
    
        BrowserWindow::GetOmniboxPageActionIconContainer()
        BrowserWindow::GetToolbarPageActionIconContainer()
    
        with
    
        BrowserWindow::UpdatePageActionIcon(type)
        BrowserWindow::ExecutePageActionIconForTesting(type)
    
        in order to hide the implementation detail of which container any
        given icon resides in.
    
        This is in preparation for adding more page-action-icons to PWA windows
        which only have one container.
    
        This is a pure refactor with no behavioural changes.
    
        Bug: 788051
    
    https://chromium.googlesource.com/chromium/src/+/35e8900d3d909a7797eb7173d2cd6140813e5057
    
    commit 35e8900d3d909a7797eb7173d2cd6140813e5057
    Author: Alan Cutter <alancutter@chromium.org>
    Date:   Wed Sep 18 04:40:32 2019 +0000
    
        Refactor the bookmark star icon to match all other PageActionIconViews
    
        This is a cleanup refactor, the bookmark star is the last PageActionIconView
        that isn't contained by OmniboxPageActionIconContainerView.
    
        This CL updates its implementation to conform with all the other PAIVs
        and remove specialised LocationBar methods now that it fits
        generic interface.
    
        Bug: 788051
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    a60945e View commit details
    Browse the repository at this point in the history
  32. ProfileManager::CreateProfileHelper now returns unique_ptr.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/1173223de1ea3f27b6ec84495ff0368064e42e53
    
    commit 1173223de1ea3f27b6ec84495ff0368064e42e53
    Author: Lei Zhang <thestig@chromium.org>
    Date:   Tue Oct 8 17:22:54 2019 +0000
    
        Change ProfileManager::CreateProfileHelper() to return std::unique_ptr.
    
        Clearly indicate pointer ownership. Fix nits along the way.
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d3beb87 View commit details
    Browse the repository at this point in the history
  33. TestBrowserThreadBundle was removed.

    Along with a few other test classes, see below.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/2dfa2ba40a372f4a08ba0d051b5cbe5accf2c526
    
    commit 2dfa2ba40a372f4a08ba0d051b5cbe5accf2c526
    Author: Gabriel Charette <gab@chromium.org>
    Date:   Tue Sep 10 00:28:54 2019 +0000
    
        [TaskEnvironment] Remove old types
    
        Explicitly (to document for git log purposes), this removes:
          - base::test::ScopedTaskEnvironment
          - net::WithScopedTaskEnvironment
          - net::TestWithScopedTaskEnvironment
          - content::TestBrowserThreadBundle
          - web::TestWebThreadBundle
    
        Mass migrate stragglers which landed under old names after initial
        mass migration.
    
        TBR=dcheng@chromium.org
        (to bypass owners for mechanical changes outside //base)
    
        Bug: 992483
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ca3968c View commit details
    Browse the repository at this point in the history
  34. GetAvatarToolbarButton is now in ToolbarButtonProvider.

    Use the API in ToolbarButtonProvider instead of Toolbar where it became
    private.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/e6f29e1246c0bea4b457bbe551e16fcfc996f1ce
    
    commit e6f29e1246c0bea4b457bbe551e16fcfc996f1ce
    Author: siyua <siyua@chromium.org>
    Date:   Thu Oct 10 02:57:45 2019 +0000
    
        [Upstream Feedback] Refactor how browser window shows autofill bubbles.
    
        The idea is to move autofill bubble showing logic out of browser window
        to keep it short and clean. Also this extracted class can be a observer
        for autofill data saving and notify avatar so that avatar itself does
        not need to be such observers.
    
        Also add avatar button accessor in the ToolbarButtonProvider.
    
        Bug: 964127
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7e91f5c View commit details
    Browse the repository at this point in the history
  35. Removed MD_ prefix from overriden extension strings.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/38aaea4fdbab7f494e0f26a006d38769b1702e2e
    
    commit 38aaea4fdbab7f494e0f26a006d38769b1702e2e
    Author: dpapad <dpapad@chromium.org>
    Date:   Wed Apr 10 00:19:49 2019 +0000
    
        WebUI cleanup: Rename IDS_MD_EXTENSIONS_ to IDS_EXTENSIONS_.
    
        This is part of the effort to remove unnecessary "md_" prefixes from various
        parts of the WebUI codebase.
    
        Bug: 887150
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    0031ad1 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    cde6f78 View commit details
    Browse the repository at this point in the history
  37. Reworked ChromeTypographyProvider override.

    We were redefining GetColor, but the original function started calling
    GetColor of the base class and our #define didn't work right any more.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/9e0a0107df360d968b2c13815cf64dfec46f2f6a
    
    commit 9e0a0107df360d968b2c13815cf64dfec46f2f6a
    Author: Robert Liao <robliao@chromium.org>
    Date:   Fri Sep 6 16:53:00 2019 +0000
    
        Use views::style::GetColor in MenuItemView
    
        This change attempts to be a behavior preserving change at the views
        layer while allowing the Chrome Typography provider to specify colors
        for menu item text.
    
        The mapping of Native Color IDs to styles are as follows:
    
        kColorId_EnabledMenuItemForegroundColor     = CONTEXT_MENU + STYLE_PRIMARY
        kColorId_SelectedMenuItemForegroundColor    = CONTEXT_MENU + STYLE_SELECTED
        kColorId_DisabledMenuItemForegroundColor    = CONTEXT_MENU + STYLE_DISABLED
        kColorId_TouchableMenuItemLabelColor        = CONTEXT_TOUCH_MENU + STYLE_PRIMARY
        kColorId_MenuItemMinorTextColor             = CONTEXT_MENU + STYLE_SECONDARY
        kColorId_HighlightedMenuItemForegroundColor = CONTEXT_MENU + STYLE_HIGHLIGHTED
    
        The resultant colors are as follows, with views representing the old colors.
    
                                                     Light Mode       Light Mode
                                                     Default (Views)  Chrome
        kColorId_EnabledMenuItemForegroundColor      Black            GG900
        kColorId_SelectedMenuItemForegroundColor     Black            GG900
        kColorId_DisabledMenuItemForegroundColor     GG600 [1]        9e9e9e
        kColorId_TouchableMenuItemLabelColor         GG900            GG900
        kColorId_MenuItemMinorTextColor              Black A:0x89     GG700
        kColorId_HighlightedMenuItemForegroundColor  GG900            GG900
        * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255.
        [1] kDisabledTextColor
    
                                                     Dark Mode        Dark Mode
                                                     Default (Views)  Chrome
        kColorId_EnabledMenuItemForegroundColor      GG200            White A:0xDD
        kColorId_SelectedMenuItemForegroundColor     GG200            White A:0xDD
        kColorId_DisabledMenuItemForegroundColor     GG600            GG600 [2]
        kColorId_TouchableMenuItemLabelColor         GG900            White A:0xDD
        kColorId_MenuItemMinorTextColor              Black A:0x89     GG500
        kColorId_HighlightedMenuItemForegroundColor  GG200            White A:0xDD
        * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255.
        [2] Was GG800 by default, but changed to GG600 to maintain previous contrast.
    
        We can consider merging the colors after this change.
    
        BUG=865318
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    6096614 View commit details
    Browse the repository at this point in the history
  38. Fixes Avatar menu for c79.

    Switches to use SetHighligh instead of SetText to fix Tor button.
    Also, removes unnecessary code duplication.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/13ae4c227767cbe26b570fec9104a9c425bd2dde
    
    commit 13ae4c227767cbe26b570fec9104a9c425bd2dde
    Author: Jan Krcal <jkrcal@chromium.org>
    Date:   Mon Sep 16 13:59:04 2019 +0000
    
        [ToolbarButton] Change API to SetHighlight() and ClearHighlight()
    
        This CL prepares for animating highlight+background+label color whenever
        a non-empty text or highlight-color gets set and animating it back when
        it gets removed.
    
        This CL changes the API to better match this planned behavior. The new
        API sets (and clears) these two properties in one call.
    
        Bug: 967317
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7961775 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    c8ea441 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    0f64366 View commit details
    Browse the repository at this point in the history
  41. Workaround for build error on Linux.

    Unused private member in GpuMojoMediaClient because we use
    use_vaapi=true and Chromium doesn't. Injected a method into
    the class the "uses" the member.
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    9ce4956 View commit details
    Browse the repository at this point in the history
  42. Linux: add GetDesktopName to override of channel_info_posix.cc

    The function used to be defined elesewhere but was moved to
    chrome/commin/channel_info_posix.cc which we completely override
    in chromium_src. Added the definition to our override minus
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/b8a8603ff3b2caf0106edec3d33093125e4a67cf
    
    commit b8a8603ff3b2caf0106edec3d33093125e4a67cf
    Author: Tom Anderson <thomasanderson@chromium.org>
    Date:   Wed Oct 9 20:12:45 2019 +0000
    
        Move unity_service out of libgtkui
    
        unity_service didn't have any dependencies on GTK, so it doesn't belong
        there.  We want libgtkui to be as small as possible because in the
        future we want to have alternate implementations of LinuxUi for eg. QT5.
    
        BUG=None
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    0395c43 View commit details
    Browse the repository at this point in the history
  43. IsDefauleProfileName takes an additional param now.

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/6655884a725502961480d059d1d94fa959e47637
    
    commit 6655884a725502961480d059d1d94fa959e47637
    Author: Monica Basta <msalama@chromium.org>
    Date:   Tue Oct 29 10:38:39 2019 +0000
    
        [Signin]: Migrate Legacy default profile names to 'Person %n' on Desktop.
    
        This CL does the following:
        (1) If the user has not customized their local profile name |IsUsingDefaultName()
        == true| and their local profile name is not 'Person %n', we change the
        local profile name to 'Person %n'.
        (2) For newly created profiles, we set the local profile name to 'Person %n'
        unless the user specifies something else.
        (3) Fix some corner cases for the display profile name.
    
        Bug: 1018719
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bea3172 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    e62ff0f View commit details
    Browse the repository at this point in the history
  45. refactor SecurityIndicatorTest.CheckIndicatorText to use testing params

    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/62a443a72e951b7885f65ad631a3f5ac27185ae2
    
    commit    62a443a72e951b7885f65ad631a3f5ac27185ae2
    author    Ken Rockot <rockot@google.com>
    date      Fri Oct 11 17:13:10 2019
    
    Fix misc ScopedFeatureList usage (7/8)
    
    ScopedFeatureList is unsafe to use after browser threads have been
    started. This constraint will imminently be enforced by DCHECK to
    prevent further erroneous usage from landing.
    
    This CL corrects usage within chrome/browser/ui/
    
    This is split from a larger CL where in some rare cases, correction
    was too complex to resolve before landing the DCHECK, so corresponding
    test(s) may be disabled instead of fixed.
    
    Bug: 846380
    Change-Id: Icf7980a928f4462e21f6d252fc04170a79be9393
    pilgrim-brave authored and mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d197b86 View commit details
    Browse the repository at this point in the history
  46. Fixes Widevine on Linux.

    Chromium changes:
    
    https://chromium.googlesource.com/chromium/src/+/54c6ac50650c82426bcb363a57b18dc47a1dedc4
    
    commit 54c6ac50650c82426bcb363a57b18dc47a1dedc4
    Author: John Rummell <jrummell@chromium.org>
    Date:   Tue Sep 24 23:52:06 2019 +0000
    
        Use manifest.json to determine features supported by Widevine CDM on Linux
    
        Use the manifest.json file bundled with Widevine CDM (on Linux) to
        determine the features supported by Widevine rather than have them
        explicitly specified in code. This is handled by the component updater
        for Windows and Mac, so extending it to Linux now that the Widevine CDM
        for Linux is in a separate directory.
    
        Bug: 971433
    
    https://chromium.googlesource.com/chromium/src/+/a539416c1f041af93e054d1cd397f895762022bc
    
    commit a539416c1f041af93e054d1cd397f895762022bc
    Author: John Rummell <jrummell@chromium.org>
    Date:   Thu Oct 3 21:39:30 2019 +0000
    
        Enable component updated Widevine CDM on desktop Linux
    
        On Linux the Widevine CDM is loaded into the zygote at startup. When the
        component updater runs sometime later and finds a newer version of the
        Widevine CDM, don't register it as the newer version can't be used.
        Instead, similar to Flash, save the path to the new Widevine CDM in the
        file latest-component-updated-widevine-cdm. Next time at startup this
        file will be checked, and if it references a usable Widevine CDM, use
        this version instead of the bundled CDM.
    
        Tested this by running Chrome built with an older version of the
        Widevine CDM, and then checking chrome://components for a newer (QA)
        version. As there is one, it gets updated. When restarting Chrome, the
        newer version is loaded. In both cases Widevine content was played using
        Shaka.
    
        Bug: 971433
    mkarolin committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d40c305 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    ce7d5f6 View commit details
    Browse the repository at this point in the history