Fixes missing grdp files. #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
|
Only known, unrelated browser test failure in CI. |
mkarolin
force-pushed
the
maxk-fix-missing-grdp
branch
from
795f909
to
d06b90c
Compare
Fixes brave/brave-browser#6907 There is no need to exclude os_settings_strings.grdp and xr_consent_ui_strings.grdp. media_router_resources.grdp has been removed upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/edcf55b10dfe41c3ffa18bfbca8f07e62532ef74 commit edcf55b10dfe41c3ffa18bfbca8f07e62532ef74 Author: Takumi Fujimoto <takumif@chromium.org> Date: Tue Jul 9 16:36:20 2019 +0000 Delete Media Router WebUI dialog resource files Delete JS/HTML/CSS files for chrome://media-router and its tests. We do not remove files related to chrome://media-router-internals because that is still in use. Bug: 900246
mkarolin
force-pushed
the
maxk-fix-missing-grdp
branch
from
d06b90c
to
a8a3515
Compare
darkdh
approved these changes
Nov 18, 2019
mkarolin
added
CI/skip-ios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6907
Related PR: brave/brave-browser#6909
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.