Upgrade patches from Chromium 78.0.3904.97 to Chromium 79.0.3945.36 #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2019
mkarolin
force-pushed
the
79.0.3945.36
branch
4 times, most recently
from
14f1947
to
489af13
Compare
Chromium change: https://chromium.googlesource.com/chromium/src/+/0da1b5287c24ac582760a40530a7811259558d17 commit 0da1b5287c24ac582760a40530a7811259558d17 Author: Kyle Milka <kmilka@chromium.org> Date: Mon Oct 7 20:14:30 2019 +0000 [NTP] Remove ShowFirstRunDefaultSearchShortcut Not launching. Bug: None
Also, Create*TaskRunnerWithTraits -> Create*TaskRunner. Chromium change: https://chromium.googlesource.com/chromium/src/+/dd9428771eb0e498a401bbfaf6d247d051315e92 commit dd9428771eb0e498a401bbfaf6d247d051315e92 Author: Sami Kyostila <skyostil@chromium.org> Date: Mon Sep 9 14:42:43 2019 +0000 Reland "base: Remove temporary "WithTraits" task API wrappers" This is a reland of 0bf621ef56940ef6a05266527b189898cc7bbe11 Original change's description: > base: Remove temporary "WithTraits" task API wrappers > > Now that everyone has been migrated to the renamed > PostTask/CreateTaskRunner APIs, we can remove these temporary wrappers. > > TBR=gab@chromium.org > (to apply side-effects of mechanical change in //base) > > Bug: 968047 > Change-Id: I69c53abd899f37586f23ec295ffcc9bf12042c4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752787 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693695} TBR=gab@chromium.org (reland without changes) Bug: 968047
Use synber::DirectoryCryptographer implementation instead. Chromium change: https://chromium.googlesource.com/chromium/src/+/60ad5e7ae3634951a77625d1c1c92a5e5cacebd5 commit 60ad5e7ae3634951a77625d1c1c92a5e5cacebd5 Author: Mikel Astiz <mastiz@chromium.org> Date: Tue Sep 24 13:31:40 2019 +0000 Introduce sync Cryptographer interface This reduces the exposure of a big API to many files that don't actually require it, and unblocks the redesign of the cryptographer in USS, which will be addressed in follow-up patches. Some trivial renames: Cryptographer --> DirectoryCryptographer Cryptographer::is_ready() --> Cryptographer::CanEncrypt() Cryptographer::GetDefaultNigoriKeyName() --> Cryptographer::GetDefaultEncryptionKeyName() Bug: 967417
Instead of storing highlight path in a property (which was removed) use either one of the pre-made HighlightPath generators or add a custom one. Added custom generators for: * BraveTextButton * BraveActionView * BraveRewardsActionStubView Chromium bug: https://crbug.com/1007546 https://chromium.googlesource.com/chromium/src.git/+/a934e7d7e0b1691c01b6728f6b02afeb1327b7bd commit a934e7d7e0b1691c01b6728f6b02afeb1327b7bd Author: Peter Boström <pbos@chromium.org> Date: Tue Oct 1 19:07:13 2019 +0000 Add a HighlightPathGenerator class This set of classes are intended to remove the need to override OnBoundsChanged on Views to set |kHighlightPathKey|. Whenever a path is needed the generator gets asked to generate one. Bug: chromium:1007546 https://chromium.googlesource.com/chromium/src/+/cb413eeccc4f18057b565e4a270df55417988ab9 commit cb413eeccc4f18057b565e4a270df55417988ab9 Author: Peter Boström <pbos@chromium.org> Date: Wed Oct 16 18:07:18 2019 +0000 Remove kHighlightPathKey This has now been fully replaced with HighlightPathGenerator instances. Bug: chromium:1007546
The overload we were using was removed. Chromium change: https://chromium.googlesource.com/chromium/src/+/b3b852f1911fe67e81b596da48e247d67220ac0d commit b3b852f1911fe67e81b596da48e247d67220ac0d Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Oct 4 17:53:24 2019 +0000 Remove AssociatedInterface{Registry,Provider}'s methods for old Mojo types This CL eliminates the need for having those versions of these templated methods available by migrating the few references to the old Mojo types in those places that interact with them, so we can remove them along with such migrations, all in one go. Bug: 955171, 978694, 936482
Chromium change: https://chromium.googlesource.com/chromium/src/+/ed8d98f254f3a6f6df55d2665aa3e568b99b4c7e commit ed8d98f254f3a6f6df55d2665aa3e568b99b4c7e Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Mon Oct 14 11:11:33 2019 +0000 Convert ProxyLookupClient to new Mojo types This CL converts ProxyLookupClient from proxy_lookup_client.mojom to new Mojo types using PendingRemote, Receiver, and Remote. Bug: 955171
Chromium change: https://chromium.googlesource.com/chromium/src/+/29bf65088f1647dd53b90b9afb186a1015a591bc commit 29bf65088f1647dd53b90b9afb186a1015a591bc Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Oct 15 01:37:57 2019 +0000 Convert TCPConnectedSocket to new Mojo types This CL converts TCPConnectedSocket{Ptr, Request} in chrome, components, content, extensions and services to the new Mojo type, and uses pending_receiver<T> in network_context.mojom and pending_remote<T>, pending_receiver<T> in tcp_socket.mojom. Bug: 955171
Chromium change: https://chromium.googlesource.com/chromium/src/+/9973fcb5cdd0f5ddd717d3b9a14ab51bfa3fe433 commit 9973fcb5cdd0f5ddd717d3b9a14ab51bfa3fe433 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Sat Sep 21 10:03:49 2019 +0000 Convert TrackedPreferenceValidationDelegate to new Mojo types This CL converts TrackedPreferenceValidationDelegatePtr and TrackedPreferenceValidationDelegateRequest to new Mojo types. It uses PendingRemote or Remote and ReceiverSet instead of TrackedPreferenceValidationDelegatePtr and BindingSet. Bug: 955171
Chromium change: https://chromium.googlesource.com/chromium/src/+/a59e78e2fa83b6d2437ca4bd63a57d7bad243b4e commit a59e78e2fa83b6d2437ca4bd63a57d7bad243b4e Author: Collin Baker <collinbaker@chromium.org> Date: Tue Oct 15 16:16:55 2019 +0000 Remove GetHighestPriorityTabAlertStateForContents() This migrates callers to GetTabAlertStatesForContents(), which returns all the applicable TabAlertStates, or none at all. This also removes TabAlertState::NONE since this function will return an empty list instead. Use cases that needed TabAlertState::NONE are replaced with base::Optional<TabAlertState>. Bug: 1004983
Chromium changes: https://chromium.googlesource.com/chromium/src/+/e427f7c9ce109b071bd17183456d3015ef44ed71 commit e427f7c9ce109b071bd17183456d3015ef44ed71 Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Sep 25 16:15:57 2019 +0000 [profile-menu] Add badge to identity image ...depending on the sync state. Screenshot: https://drive.google.com/file/d/1npd-N8-jGzMws9PtzpKZYyXrpeyGCRzj/view?usp=sharing Bug: 995720 https://chromium.googlesource.com/chromium/src/+/f6a5f5b84a5ba341b49392b94c1865d09aa29b34 commit f6a5f5b84a5ba341b49392b94c1865d09aa29b34 Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Sep 25 16:37:10 2019 +0000 [profile-menu] Refactor image cropping logic - To reduce conversions from gfx::ImageSkia to gfx::Image - To make image parameters of the ProfileMenuViewBase API consistent Bug: 995720
Chromium change: https://chromium.googlesource.com/chromium/src/+/5b200929900463e2d90c7c14bf9a3845ebed6662 commit 5b200929900463e2d90c7c14bf9a3845ebed6662 Author: Joshua Pawlicki <waffles@chromium.org> Date: Fri Sep 6 19:50:57 2019 +0000 Launch NewExtensionUpdater experiment. This required moving some ContentVerification tests that were using an interceptor in the old updater stack to use an interceptor for the new one. Otherwise, the change is very straightforward. Bug: 920775
Chromium change: https://chromium.googlesource.com/chromium/src/+/13b66bdf6719bcfedf549ff8ce2b18d2279e0396 commit 13b66bdf6719bcfedf549ff8ce2b18d2279e0396 author Emily Stark <estark@google.com> date Mon Oct 14 11:11:33 2019 Add origin to external protocol dialog This is a stopgap fix for the fact that it's unclear which frame triggered a navigation to an external protocol. Eventually, we want to implement some more robust fixes, like preventing a frame from navigating another cross-origin frame to an external protocol, but that'll involve a bit more investigation and metrics (to be added in a follow-up CL). Bug: 754304
Transitioned to ChromeLayoutProvider::GetCornerRadiusMetric instead. Chromium change: https://chromium.googlesource.com/chromium/src/+/507d21a5f2df4e98ac7f37eb25594d01ff7f2a2b commit 507d21a5f2df4e98ac7f37eb25594d01ff7f2a2b Author: Peter Kasting <pkasting@chromium.org> Date: Mon Sep 16 14:50:43 2019 +0000 Make greater use of LayoutProvider::GetCornerRadiusMetric(). This also collapses some overrides from ChromeLayoutProvider down into LayoutProvider when the LayoutProvider-side differences never had an effect. Bug: 940766
Chromium change: https://chromium.googlesource.com/chromium/src/+/b5bf548f6b58ad35ec8dc8c9918939ac02bb794c commit b5bf548f6b58ad35ec8dc8c9918939ac02bb794c Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Sep 12 17:40:15 2019 +0000 Move webrtc_ip_handling_policy.cc|h to Blink ... from content/public/common. This is another preliminary step to Onion souping peer_connection_dependency_factory.cc|h|unittest. No functionality change expected. The solution is described in section 5 of the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254
Chromium change: https://chromium.googlesource.com/chromium/src/+/13b66bdf6719bcfedf549ff8ce2b18d2279e0396 commit 13b66bdf6719bcfedf549ff8ce2b18d2279e0396 author Emily Stark <estark@google.com> date Mon Oct 14 11:11:33 2019 Add origin to external protocol dialog This is a stopgap fix for the fact that it's unclear which frame triggered a navigation to an external protocol. Eventually, we want to implement some more robust fixes, like preventing a frame from navigating another cross-origin frame to an external protocol, but that'll involve a bit more investigation and metrics (to be added in a follow-up CL). Bug: 754304
Chromium change: https://chromium.googlesource.com/chromium/src/+/bafd44c226f3a3406e4b70ed5fb1be662d4d416b commit bafd44c226f3a3406e4b70ed5fb1be662d4d416b Author: Monica Basta <msalama@chromium.org> Date: Thu Oct 10 10:14:54 2019 +0000 [Signin]: Show the concatenation of the GAIA name and profile name. Use the concatenation of GAIA name and profile name as the identity of the profile to be shown in the User Menu and the profile switcher. With the efforts towards encouraging the use of multiple profiles, it becomes more important to show a clear identity for the profile and clear transitions on events like sign in, enable sync, sign out. If no primary account or unconsented primary account exists for the profile, the local profile name is used. Otherwise, we show the concatenation of GAIA name and profile name in this format: |GAIA name (profile name)|. The only exception where we only show the GAIA name is if the profile name is a substring of the GAIA name. The implementation is behind a kill switch |kConcatenateGaiaAndProfileName| enabled by default. Bug: 1012182
Chromium change: https://chromium.googlesource.com/chromium/src/+/7f8e26a2d575cb0e69a467bf4f3270a694f885a8 commit 7f8e26a2d575cb0e69a467bf4f3270a694f885a8 author Julie Jeongeun Kim <jkim@igalia.com> date Thu Oct 10 12:09:52 2019 Convert Clone() in url_loader_factory.mojom to new Mojo types This CL converts URLLoaderFactoryRequest from Clone() in url_loader_factory.mojom using PendingReceiver and ReceiverSet. Bug: 955171
Chromium change: https://chromium.googlesource.com/chromium/src/+/1173223de1ea3f27b6ec84495ff0368064e42e53 commit 1173223de1ea3f27b6ec84495ff0368064e42e53 Author: Lei Zhang <thestig@chromium.org> Date: Tue Oct 8 17:22:54 2019 +0000 Change ProfileManager::CreateProfileHelper() to return std::unique_ptr. Clearly indicate pointer ownership. Fix nits along the way.
Along with a few other test classes, see below. Chromium change: https://chromium.googlesource.com/chromium/src/+/2dfa2ba40a372f4a08ba0d051b5cbe5accf2c526 commit 2dfa2ba40a372f4a08ba0d051b5cbe5accf2c526 Author: Gabriel Charette <gab@chromium.org> Date: Tue Sep 10 00:28:54 2019 +0000 [TaskEnvironment] Remove old types Explicitly (to document for git log purposes), this removes: - base::test::ScopedTaskEnvironment - net::WithScopedTaskEnvironment - net::TestWithScopedTaskEnvironment - content::TestBrowserThreadBundle - web::TestWebThreadBundle Mass migrate stragglers which landed under old names after initial mass migration. TBR=dcheng@chromium.org (to bypass owners for mechanical changes outside //base) Bug: 992483
Use the API in ToolbarButtonProvider instead of Toolbar where it became private. Chromium change: https://chromium.googlesource.com/chromium/src/+/e6f29e1246c0bea4b457bbe551e16fcfc996f1ce commit e6f29e1246c0bea4b457bbe551e16fcfc996f1ce Author: siyua <siyua@chromium.org> Date: Thu Oct 10 02:57:45 2019 +0000 [Upstream Feedback] Refactor how browser window shows autofill bubbles. The idea is to move autofill bubble showing logic out of browser window to keep it short and clean. Also this extracted class can be a observer for autofill data saving and notify avatar so that avatar itself does not need to be such observers. Also add avatar button accessor in the ToolbarButtonProvider. Bug: 964127
Chromium change: https://chromium.googlesource.com/chromium/src/+/38aaea4fdbab7f494e0f26a006d38769b1702e2e commit 38aaea4fdbab7f494e0f26a006d38769b1702e2e Author: dpapad <dpapad@chromium.org> Date: Wed Apr 10 00:19:49 2019 +0000 WebUI cleanup: Rename IDS_MD_EXTENSIONS_ to IDS_EXTENSIONS_. This is part of the effort to remove unnecessary "md_" prefixes from various parts of the WebUI codebase. Bug: 887150
We were redefining GetColor, but the original function started calling GetColor of the base class and our #define didn't work right any more. Chromium change: https://chromium.googlesource.com/chromium/src/+/9e0a0107df360d968b2c13815cf64dfec46f2f6a commit 9e0a0107df360d968b2c13815cf64dfec46f2f6a Author: Robert Liao <robliao@chromium.org> Date: Fri Sep 6 16:53:00 2019 +0000 Use views::style::GetColor in MenuItemView This change attempts to be a behavior preserving change at the views layer while allowing the Chrome Typography provider to specify colors for menu item text. The mapping of Native Color IDs to styles are as follows: kColorId_EnabledMenuItemForegroundColor = CONTEXT_MENU + STYLE_PRIMARY kColorId_SelectedMenuItemForegroundColor = CONTEXT_MENU + STYLE_SELECTED kColorId_DisabledMenuItemForegroundColor = CONTEXT_MENU + STYLE_DISABLED kColorId_TouchableMenuItemLabelColor = CONTEXT_TOUCH_MENU + STYLE_PRIMARY kColorId_MenuItemMinorTextColor = CONTEXT_MENU + STYLE_SECONDARY kColorId_HighlightedMenuItemForegroundColor = CONTEXT_MENU + STYLE_HIGHLIGHTED The resultant colors are as follows, with views representing the old colors. Light Mode Light Mode Default (Views) Chrome kColorId_EnabledMenuItemForegroundColor Black GG900 kColorId_SelectedMenuItemForegroundColor Black GG900 kColorId_DisabledMenuItemForegroundColor GG600 [1] 9e9e9e kColorId_TouchableMenuItemLabelColor GG900 GG900 kColorId_MenuItemMinorTextColor Black A:0x89 GG700 kColorId_HighlightedMenuItemForegroundColor GG900 GG900 * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255. [1] kDisabledTextColor Dark Mode Dark Mode Default (Views) Chrome kColorId_EnabledMenuItemForegroundColor GG200 White A:0xDD kColorId_SelectedMenuItemForegroundColor GG200 White A:0xDD kColorId_DisabledMenuItemForegroundColor GG600 GG600 [2] kColorId_TouchableMenuItemLabelColor GG900 White A:0xDD kColorId_MenuItemMinorTextColor Black A:0x89 GG500 kColorId_HighlightedMenuItemForegroundColor GG200 White A:0xDD * (A:Value) means Alpha Set to Value, transparent at 0, fully opaque at 255. [2] Was GG800 by default, but changed to GG600 to maintain previous contrast. We can consider merging the colors after this change. BUG=865318
Switches to use SetHighligh instead of SetText to fix Tor button. Also, removes unnecessary code duplication. Chromium change: https://chromium.googlesource.com/chromium/src/+/13ae4c227767cbe26b570fec9104a9c425bd2dde commit 13ae4c227767cbe26b570fec9104a9c425bd2dde Author: Jan Krcal <jkrcal@chromium.org> Date: Mon Sep 16 13:59:04 2019 +0000 [ToolbarButton] Change API to SetHighlight() and ClearHighlight() This CL prepares for animating highlight+background+label color whenever a non-empty text or highlight-color gets set and animating it back when it gets removed. This CL changes the API to better match this planned behavior. The new API sets (and clears) these two properties in one call. Bug: 967317
Unused private member in GpuMojoMediaClient because we use use_vaapi=true and Chromium doesn't. Injected a method into the class the "uses" the member.
The function used to be defined elesewhere but was moved to chrome/commin/channel_info_posix.cc which we completely override in chromium_src. Added the definition to our override minus Chromium change: https://chromium.googlesource.com/chromium/src/+/b8a8603ff3b2caf0106edec3d33093125e4a67cf commit b8a8603ff3b2caf0106edec3d33093125e4a67cf Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Oct 9 20:12:45 2019 +0000 Move unity_service out of libgtkui unity_service didn't have any dependencies on GTK, so it doesn't belong there. We want libgtkui to be as small as possible because in the future we want to have alternate implementations of LinuxUi for eg. QT5. BUG=None
Chromium change: https://chromium.googlesource.com/chromium/src/+/6655884a725502961480d059d1d94fa959e47637 commit 6655884a725502961480d059d1d94fa959e47637 Author: Monica Basta <msalama@chromium.org> Date: Tue Oct 29 10:38:39 2019 +0000 [Signin]: Migrate Legacy default profile names to 'Person %n' on Desktop. This CL does the following: (1) If the user has not customized their local profile name |IsUsingDefaultName() == true| and their local profile name is not 'Person %n', we change the local profile name to 'Person %n'. (2) For newly created profiles, we set the local profile name to 'Person %n' unless the user specifies something else. (3) Fix some corner cases for the display profile name. Bug: 1018719
Chromium change: https://chromium.googlesource.com/chromium/src/+/62a443a72e951b7885f65ad631a3f5ac27185ae2 commit 62a443a72e951b7885f65ad631a3f5ac27185ae2 author Ken Rockot <rockot@google.com> date Fri Oct 11 17:13:10 2019 Fix misc ScopedFeatureList usage (7/8) ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within chrome/browser/ui/ This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Icf7980a928f4462e21f6d252fc04170a79be9393
Chromium changes: https://chromium.googlesource.com/chromium/src/+/54c6ac50650c82426bcb363a57b18dc47a1dedc4 commit 54c6ac50650c82426bcb363a57b18dc47a1dedc4 Author: John Rummell <jrummell@chromium.org> Date: Tue Sep 24 23:52:06 2019 +0000 Use manifest.json to determine features supported by Widevine CDM on Linux Use the manifest.json file bundled with Widevine CDM (on Linux) to determine the features supported by Widevine rather than have them explicitly specified in code. This is handled by the component updater for Windows and Mac, so extending it to Linux now that the Widevine CDM for Linux is in a separate directory. Bug: 971433 https://chromium.googlesource.com/chromium/src/+/a539416c1f041af93e054d1cd397f895762022bc commit a539416c1f041af93e054d1cd397f895762022bc Author: John Rummell <jrummell@chromium.org> Date: Thu Oct 3 21:39:30 2019 +0000 Enable component updated Widevine CDM on desktop Linux On Linux the Widevine CDM is loaded into the zygote at startup. When the component updater runs sometime later and finds a newer version of the Widevine CDM, don't register it as the newer version can't be used. Instead, similar to Flash, save the path to the new Widevine CDM in the file latest-component-updated-widevine-cdm. Next time at startup this file will be checked, and if it references a usable Widevine CDM, use this version instead of the bundled CDM. Tested this by running Chrome built with an older version of the Widevine CDM, and then checking chrome://components for a newer (QA) version. As there is one, it gets updated. When restarting Chrome, the newer version is loaded. In both cases Widevine content was played using Shaka. Bug: 971433
Two methods are no longer static. Chromium change: https://chromium.googlesource.com/chromium/src/+/4df5dfe5a79d0e553e63d29490f4668bfa20082d commit 4df5dfe5a79d0e553e63d29490f4668bfa20082d Author: Joshua Peraza <jperaza@chromium.org> Date: Wed Sep 11 19:57:20 2019 +0000 Update Crashpad to 06fdbdecdc5d94989543bcec197752fdea2fbd9d e3bf3a5fde91 Roll crashpad/third_party/mini_chromium/mini_chromium/ 588976752..660b43a77 (2 commits) 9a6234461201 [Log minidump] OutputStream interface and zlib implementation 9b314d5fa819 cros: Pass a dir for minidumps to crash_reporter fc44a3747cf5 linux: Allow configuring unhandled signals abeccef1efdb [fuchsia] fix crashpad_use_boringssl_for_http_transport_socket path 06fdbdecdc5d android, chromeos: fix build breakages
Chromium changes: https://chromium.googlesource.com/chromium/src/+/096447f8e752a02e0747fad77e09a402c4a6c763 commit 096447f8e752a02e0747fad77e09a402c4a6c763 Author: Pâris MEULEMAN <pmeuleman@chromium.org> Date: Mon Sep 9 16:20:50 2019 +0000 Use IdentityManager.java observer in SigninManager SigninManager uses IdentityManager's observer (onPrimaryAccountSet/Cleared) through IdentityManager.java instead of signin_manager_android. Bug: 934688 https://chromium.googlesource.com/chromium/src/+/3a0b072b97a29d01dc10ddec116170e10d411316 commit 3a0b072b97a29d01dc10ddec116170e10d411316 Author: Pâris MEULEMAN <pmeuleman@chromium.org> Date: Mon Sep 16 10:13:30 2019 +0000 Pass IdentityMutator.java to SigninManager.java directly Avoid exposing getIdentityMutator in IdentityManager.java by passing the IdentityMutator reference directly in SigninManagerAndroid's and SigninManager.java's constructors. Bug: 934688 https://chromium.googlesource.com/chromium/src/+/d84b95f4198a6904a4938dd494d946f07d82c33c commit d84b95f4198a6904a4938dd494d946f07d82c33c Author: Boris Sazonov <bsazonov@chromium.org> Date: Thu Sep 26 18:40:22 2019 +0000 [Signin][Android] Remove redundant Context field from SigninManager SigninManager should always use application context, thus there's no need to pass it to the ctor and ContextUtils.getApplicationContext can be used instead. Bug: 1007415
Chromium change: https://chromium.googlesource.com/chromium/src/+/933d2b3b05dad21b8fe319f26657034d667e9c7e commit 933d2b3b05dad21b8fe319f26657034d667e9c7e Author: Theresa Wellington <twellington@chromium.org> Date: Thu Oct 3 22:50:19 2019 +0000 Move even more widgets to chrome/browser/ui/widget/android/ - ArrowBubbleDrawable - ImageTextBubble - PulseDrawable - PulseInterpolator - RoundedIconGenerator - TextBubble - ViewHighlighter - ViewHighlighterTest - ViewHighlighterTestUtils BUG=951455
Chromium change: https://chromium.googlesource.com/chromium/src/+/6e011bf45c6cb082083110c4885ca135f37c4202 commit 6e011bf45c6cb082083110c4885ca135f37c4202 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Fri Sep 27 16:51:35 2019 +0000 Extract code in showAccessibilityToast() to showAnchoredToast(). showAnchoredToast() is in Toast and can be used by other callers since it does not contain anything specific to accessibility. Bug: 995916
Chromium change: https://chromium.googlesource.com/chromium/src/+/bcf46e036b818232376174e0e002cfc67f2e337c commit bcf46e036b818232376174e0e002cfc67f2e337c Author: Theresa Wellington <twellington@chromium.org> Date: Thu Oct 17 14:43:33 2019 +0000 Clean-up some app menu dependencies in preparation for modularization - Move OverviewModeObserver that dismisses menu when overview mode changes from appmenu/ to RootUiCoordinator. - Remove unneeded ToolbarManager import (only used in comments). - Create TranslateUtil with static utility for determining if translate is available for the current Tab. - Use ObservableSupplier to pass BookmarkBridge to AppMenuPropertiesDelegateImpl instead of using interface method. - Rename AppMenuTest to TabbedAppMenuTest since this is really an integration test shown for the app menu in ChromeTabbedActivity. - Update AppMenuTest to remove dependency on ChromeActivity and avoid exposing future internal classes. - Create javatests/res/values/ids.xml with test ids for use in modal dialog tests. BUG=966644
Chromium change: https://chromium.googlesource.com/chromium/src/+/d42cfe13da276154cb9cfbf3d7b9db9bf006f5ec commit d42cfe13da276154cb9cfbf3d7b9db9bf006f5ec Author: Andrew Grieve <agrieve@google.com> Date: Wed Sep 25 19:15:58 2019 +0000 Prevent verification errors from ApiCompatibilityUtils.java More hardening against verification failures caused by inlining. Also removes some unnecessary passing around of Application context. TBR=agrieve # Trivial change to ui/android Bug: 1006812
Fixes brave/brave-browser#6627 The label used to be set based on a flag that's no longer available causing our label in OnExit tab to differ from the Advanced tab. Chromium change: https://chromium.googlesource.com/chromium/src/+/a3f57021dd6ac0f0df8e473da36f874d4132819f commit a3f57021dd6ac0f0df8e473da36f874d4132819f Author: Maggie Cai <mxcai@chromium.org> Date: Wed Jul 17 01:03:22 2019 +0000 Settings: Remove site-settings flag. All sites is launched in M74, this CL removes site-settings flag. BUG=980426
mkarolin
force-pushed
the
79.0.3945.36
branch
from
489af13
to
9b05cf5
Compare
The API was changed in C78, but missed this instance of it because it only happens in x64 build. C78 change: fabfe6c Chromium change: https://chromium.googlesource.com/chromium/src/+/b851acc052ee6a505d4f60fb9cc326c410b1285b commit b851acc052ee6a505d4f60fb9cc326c410b1285b Author: Lily Chen <chlily@chromium.org> Date: Wed Aug 7 15:54:44 2019 +0000 Split server_time out of net::CookieOptions CookieOptions had an optional server_time field, which was used for clock skew adjustments when creating a cookie, and nothing else. Since CanonicalCookie::Create no longer depends on the other fields of CookieOptions, this CL replaces its CookieOptions argument with a base::Optional<base::Time> server_time argument. The server_time field is removed from CookieOptions because nothing else needs it. This does mean that CookieStore::SetCookieWithOptionsAsync needs an additional server_time argument since CookieOptions no longer includes it. But that method needs to be removed anyways. Mostly but not entirely mechanical changes. This should not change any behavior. Bug: 989098
|
Closing in favor of #4043 |
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
Revert "Make build step sign binaries and generate widevine sig files on Windows"
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
Revert "Make build step sign binaries and generate widevine sig files on Windows"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6588
Related PR brave/brave-browser#6928
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.